From: Will Deacon <will.deacon@arm.com>
To: "Jonathan (Zhixiong) Zhang" <zjzhang@codeaurora.org>
Cc: Matt Fleming <matt.fleming@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
"tony.luck@gmail.com" <tony.luck@gmail.com>,
"ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>,
"fu.wei@linaro.org" <fu.wei@linaro.org>,
"al.stone@linaro.org" <al.stone@linaro.org>,
"bp@alien8.de" <bp@alien8.de>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"lenb@kernel.org" <lenb@kernel.org>,
"ying.huang@intel.com" <ying.huang@intel.com>,
Catalin Marinas <Catalin.Marinas@arm.com>,
"leif.lindholm@linaro.org" <leif.lindholm@linaro.org>,
"hanjun.guo@linaro.org" <hanjun.guo@linaro.org>,
"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
linux-arm-msm@vger.kernel.or
Subject: Re: [PATCH V9 0/5] map GHES memory region according to EFI memory map
Date: Mon, 3 Aug 2015 12:26:58 +0100 [thread overview]
Message-ID: <20150803112658.GE10501@arm.com> (raw)
In-Reply-To: <1438292109-4170-1-git-send-email-zjzhang@codeaurora.org>
Hi Jonathan,
On Thu, Jul 30, 2015 at 10:35:04PM +0100, Jonathan (Zhixiong) Zhang wrote:
> From: "Jonathan (Zhixiong) Zhang" <zjzhang@codeaurora.org>
>
> On a platform with APEI (ACPI Platform Error Interface) enabled, firmware
> updates a memory region with hardware error record using nocache
> attribute. When OS reads the region, since it maps the region with
> cacahed attribute even though EFI memory map defines this region as
> uncached, OS gets stale data and errorneously reports there is no new
> HW error.
>
> When ghes driver maps the memory region, it uses the cache attribute
> according to EFI memory map, if EFI memory map feature is enabled
> at runtime.
>
> Since both arch/x86 and arch/ia64 implemented architecture agnostic EFI
> memory map attribue lookup function efi_memattributes(), the code is
> moved from arch/x86 into EFI subsystem and is declared as __weak; archs
> other than ia64 should not override the default implementation.
>
> V9:
> 1. Rebased to arm64-upstream-14543 of arm64/master.
> 2. Match strict MM type in arch_apei_get_mem_attribute().
I guess this is all going via Matt's tree? I'm happy to take the new
memory type in arch/arm64/ if there's nothing currently queued, but I
suspect it makes more sense for it to stay together.
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: "Jonathan (Zhixiong) Zhang" <zjzhang@codeaurora.org>
Cc: Matt Fleming <matt.fleming@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
"tony.luck@gmail.com" <tony.luck@gmail.com>,
"ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>,
"fu.wei@linaro.org" <fu.wei@linaro.org>,
"al.stone@linaro.org" <al.stone@linaro.org>,
"bp@alien8.de" <bp@alien8.de>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"lenb@kernel.org" <lenb@kernel.org>,
"ying.huang@intel.com" <ying.huang@intel.com>,
Catalin Marinas <Catalin.Marinas@arm.com>,
"leif.lindholm@linaro.org" <leif.lindholm@linaro.org>,
"hanjun.guo@linaro.org" <hanjun.guo@linaro.org>,
"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"linaro-acpi@lists.linaro.org" <linaro-acpi@lists.linaro.org>,
"vgandhi@codeaurora.org" <vgandhi@codeaurora.org>,
"timur@codeaurora.org" <timur@codeaurora.org>
Subject: Re: [PATCH V9 0/5] map GHES memory region according to EFI memory map
Date: Mon, 3 Aug 2015 12:26:58 +0100 [thread overview]
Message-ID: <20150803112658.GE10501@arm.com> (raw)
In-Reply-To: <1438292109-4170-1-git-send-email-zjzhang@codeaurora.org>
Hi Jonathan,
On Thu, Jul 30, 2015 at 10:35:04PM +0100, Jonathan (Zhixiong) Zhang wrote:
> From: "Jonathan (Zhixiong) Zhang" <zjzhang@codeaurora.org>
>
> On a platform with APEI (ACPI Platform Error Interface) enabled, firmware
> updates a memory region with hardware error record using nocache
> attribute. When OS reads the region, since it maps the region with
> cacahed attribute even though EFI memory map defines this region as
> uncached, OS gets stale data and errorneously reports there is no new
> HW error.
>
> When ghes driver maps the memory region, it uses the cache attribute
> according to EFI memory map, if EFI memory map feature is enabled
> at runtime.
>
> Since both arch/x86 and arch/ia64 implemented architecture agnostic EFI
> memory map attribue lookup function efi_memattributes(), the code is
> moved from arch/x86 into EFI subsystem and is declared as __weak; archs
> other than ia64 should not override the default implementation.
>
> V9:
> 1. Rebased to arm64-upstream-14543 of arm64/master.
> 2. Match strict MM type in arch_apei_get_mem_attribute().
I guess this is all going via Matt's tree? I'm happy to take the new
memory type in arch/arm64/ if there's nothing currently queued, but I
suspect it makes more sense for it to stay together.
Will
next prev parent reply other threads:[~2015-08-03 11:27 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 21:35 [PATCH V9 0/5] map GHES memory region according to EFI memory map Jonathan (Zhixiong) Zhang
2015-07-30 21:35 ` Jonathan (Zhixiong) Zhang
2015-07-30 21:35 ` [PATCH V9 1/5] efi: x86: rearrange efi_mem_attributes() Jonathan (Zhixiong) Zhang
2015-07-30 21:35 ` [PATCH V9 2/5] x86: acpi: implement arch_apei_get_mem_attributes() Jonathan (Zhixiong) Zhang
2015-08-03 16:22 ` Matt Fleming
2015-07-30 21:35 ` [PATCH V9 3/5] arm64: mm: add PROT_DEVICE_nGnRnE and PROT_NORMAL_WT Jonathan (Zhixiong) Zhang
2015-07-30 21:35 ` [PATCH V9 4/5] arm64: apei: implement arch_apei_get_mem_attributes() Jonathan (Zhixiong) Zhang
2015-07-30 21:35 ` [PATCH V9 5/5] acpi, apei: use appropriate pgprot_t to map GHES memory Jonathan (Zhixiong) Zhang
2015-08-03 11:26 ` Will Deacon [this message]
2015-08-03 11:26 ` [PATCH V9 0/5] map GHES memory region according to EFI memory map Will Deacon
[not found] ` <20150803112658.GE10501-5wv7dgnIgG8@public.gmane.org>
2015-08-03 16:23 ` Matt Fleming
2015-08-03 16:23 ` Matt Fleming
2015-08-04 4:25 ` Borislav Petkov
2015-08-04 4:25 ` Borislav Petkov
2015-08-04 15:41 ` Zhang, Jonathan Zhixiong
2015-08-04 15:41 ` Zhang, Jonathan Zhixiong
[not found] ` <55C0DD30.9070800-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-08-05 9:21 ` Matt Fleming
2015-08-05 9:21 ` Matt Fleming
[not found] ` <20150805092125.GB4332-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2015-08-05 15:58 ` Zhang, Jonathan Zhixiong
2015-08-05 15:58 ` Zhang, Jonathan Zhixiong
2015-08-05 16:10 ` Matt Fleming
2015-08-05 16:10 ` Matt Fleming
2015-08-05 16:13 ` Matt Fleming
2015-08-05 16:13 ` Matt Fleming
2015-08-06 13:47 ` Zhang, Jonathan Zhixiong
2015-08-06 13:47 ` Zhang, Jonathan Zhixiong
2015-08-05 9:21 ` Matt Fleming
2015-08-05 9:21 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150803112658.GE10501@arm.com \
--to=will.deacon@arm.com \
--cc=Catalin.Marinas@arm.com \
--cc=al.stone@linaro.org \
--cc=ard.biesheuvel@linaro.org \
--cc=bp@alien8.de \
--cc=fu.wei@linaro.org \
--cc=hanjun.guo@linaro.org \
--cc=hpa@zytor.com \
--cc=leif.lindholm@linaro.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.or \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mingo@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=tony.luck@gmail.com \
--cc=x86@kernel.org \
--cc=ying.huang@intel.com \
--cc=zjzhang@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.