* [PATCH V2] efi: fix 32bit kernel boot failed problem using efi
@ 2015-08-03 2:02 ` fupan.li
0 siblings, 0 replies; 7+ messages in thread
From: fupan.li-CWA4WttNNZF54TAoqtyWWQ @ 2015-08-03 2:02 UTC (permalink / raw)
To: matt-mF/unelCI9GS6iBeEJttW/XRex20P6io
Cc: jslaby-AlSwsSmVLrQ, linux-efi-u79uwXL29TY76Z2rM5mHXA,
stable-u79uwXL29TY76Z2rM5mHXA,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
fupanli-Re5JQEeQqe8AvxtiuMwx3w
From: fli <fupan.li-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
Commit 35d5134b7d5a
("x86/efi: Correct EFI boot stub use of code32_start")
imported a bug, which will cause 32bit kernel boot failed
using efi method. It should use the label's address instead
of the value stored in the label to caculate the address of
code32_start.
Signed-off-by: Fupan Li <fupan.li-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
---
arch/x86/boot/compressed/head_32.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/boot/compressed/head_32.S b/arch/x86/boot/compressed/head_32.S
index abb988a..3b28eff 100644
--- a/arch/x86/boot/compressed/head_32.S
+++ b/arch/x86/boot/compressed/head_32.S
@@ -54,7 +54,7 @@ ENTRY(efi_pe_entry)
call reloc
reloc:
popl %ecx
- subl reloc, %ecx
+ subl $reloc, %ecx
movl %ecx, BP_code32_start(%eax)
sub $0x4, %esp
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH V2] efi: fix 32bit kernel boot failed problem using efi
@ 2015-08-03 2:02 ` fupan.li
0 siblings, 0 replies; 7+ messages in thread
From: fupan.li @ 2015-08-03 2:02 UTC (permalink / raw)
To: matt; +Cc: jslaby, linux-efi, stable, gregkh, linux-kernel, fupanli
From: fli <fupan.li@windriver.com>
Commit 35d5134b7d5a
("x86/efi: Correct EFI boot stub use of code32_start")
imported a bug, which will cause 32bit kernel boot failed
using efi method. It should use the label's address instead
of the value stored in the label to caculate the address of
code32_start.
Signed-off-by: Fupan Li <fupan.li@windriver.com>
---
arch/x86/boot/compressed/head_32.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/boot/compressed/head_32.S b/arch/x86/boot/compressed/head_32.S
index abb988a..3b28eff 100644
--- a/arch/x86/boot/compressed/head_32.S
+++ b/arch/x86/boot/compressed/head_32.S
@@ -54,7 +54,7 @@ ENTRY(efi_pe_entry)
call reloc
reloc:
popl %ecx
- subl reloc, %ecx
+ subl $reloc, %ecx
movl %ecx, BP_code32_start(%eax)
sub $0x4, %esp
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread[parent not found: <1438567369-23332-1-git-send-email-fupan.li-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>]
* Re: [PATCH V2] efi: fix 32bit kernel boot failed problem using efi
2015-08-03 2:02 ` fupan.li
@ 2015-08-03 11:39 ` Matt Fleming
-1 siblings, 0 replies; 7+ messages in thread
From: Matt Fleming @ 2015-08-03 11:39 UTC (permalink / raw)
To: fupan.li-CWA4WttNNZF54TAoqtyWWQ
Cc: jslaby-AlSwsSmVLrQ, linux-efi-u79uwXL29TY76Z2rM5mHXA,
stable-u79uwXL29TY76Z2rM5mHXA,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
fupanli-Re5JQEeQqe8AvxtiuMwx3w
On Mon, 03 Aug, at 10:02:49AM, fupan.li-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org wrote:
> From: fli <fupan.li-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
>
> Commit 35d5134b7d5a
> ("x86/efi: Correct EFI boot stub use of code32_start")
> imported a bug, which will cause 32bit kernel boot failed
> using efi method. It should use the label's address instead
> of the value stored in the label to caculate the address of
> code32_start.
>
> Signed-off-by: Fupan Li <fupan.li-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
> ---
> arch/x86/boot/compressed/head_32.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Matt Fleming <matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
--
Matt Fleming, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH V2] efi: fix 32bit kernel boot failed problem using efi
@ 2015-08-03 11:39 ` Matt Fleming
0 siblings, 0 replies; 7+ messages in thread
From: Matt Fleming @ 2015-08-03 11:39 UTC (permalink / raw)
To: fupan.li; +Cc: jslaby, linux-efi, stable, gregkh, linux-kernel, fupanli
On Mon, 03 Aug, at 10:02:49AM, fupan.li@windriver.com wrote:
> From: fli <fupan.li@windriver.com>
>
> Commit 35d5134b7d5a
> ("x86/efi: Correct EFI boot stub use of code32_start")
> imported a bug, which will cause 32bit kernel boot failed
> using efi method. It should use the label's address instead
> of the value stored in the label to caculate the address of
> code32_start.
>
> Signed-off-by: Fupan Li <fupan.li@windriver.com>
> ---
> arch/x86/boot/compressed/head_32.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Matt Fleming <matt.fleming@intel.com>
--
Matt Fleming, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH V2] efi: fix 32bit kernel boot failed problem using efi
2015-08-03 2:02 ` fupan.li
(?)
(?)
@ 2015-08-03 16:15 ` Greg KH
[not found] ` <20150803161509.GA18377-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
-1 siblings, 1 reply; 7+ messages in thread
From: Greg KH @ 2015-08-03 16:15 UTC (permalink / raw)
To: fupan.li; +Cc: matt, jslaby, linux-efi, stable, linux-kernel, fupanli
On Mon, Aug 03, 2015 at 10:02:49AM +0800, fupan.li@windriver.com wrote:
> From: fli <fupan.li@windriver.com>
This needs to match the signed-off-by line, otherwise I can't take it :(
Please fix up and resend.
And what -stable tree is this for?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-08-03 22:15 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-03 2:02 [PATCH V2] efi: fix 32bit kernel boot failed problem using efi fupan.li-CWA4WttNNZF54TAoqtyWWQ
2015-08-03 2:02 ` fupan.li
[not found] ` <1438567369-23332-1-git-send-email-fupan.li-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
2015-08-03 11:39 ` Matt Fleming
2015-08-03 11:39 ` Matt Fleming
2015-08-03 16:15 ` Greg KH
[not found] ` <20150803161509.GA18377-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-08-03 22:15 ` Ben Hutchings
2015-08-03 22:15 ` Ben Hutchings
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.