From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Kees Cook <keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] iommu: avoid format string leaks into iommu_device_create
Date: Mon, 3 Aug 2015 16:16:26 +0200 [thread overview]
Message-ID: <20150803141625.GB20968@8bytes.org> (raw)
In-Reply-To: <20150724232757.GA14747-0X9Bc/hWBUTk6RaD4rd5nQ@public.gmane.org>
On Fri, Jul 24, 2015 at 04:27:57PM -0700, Kees Cook wrote:
> This makes sure it won't be possible to accidentally leak format
> strings into iommu device names. Current name allocations are safe,
> but this makes the "%s" explicit.
>
> Signed-off-by: Kees Cook <keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> ---
> drivers/iommu/dmar.c | 2 +-
> drivers/iommu/intel-iommu.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Kees Cook <keescook@chromium.org>
Cc: linux-kernel@vger.kernel.org,
David Woodhouse <dwmw2@infradead.org>,
iommu@lists.linux-foundation.org
Subject: Re: [PATCH] iommu: avoid format string leaks into iommu_device_create
Date: Mon, 3 Aug 2015 16:16:26 +0200 [thread overview]
Message-ID: <20150803141625.GB20968@8bytes.org> (raw)
In-Reply-To: <20150724232757.GA14747@www.outflux.net>
On Fri, Jul 24, 2015 at 04:27:57PM -0700, Kees Cook wrote:
> This makes sure it won't be possible to accidentally leak format
> strings into iommu device names. Current name allocations are safe,
> but this makes the "%s" explicit.
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> drivers/iommu/dmar.c | 2 +-
> drivers/iommu/intel-iommu.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
next prev parent reply other threads:[~2015-08-03 14:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-24 23:27 [PATCH] iommu: avoid format string leaks into iommu_device_create Kees Cook
[not found] ` <20150724232757.GA14747-0X9Bc/hWBUTk6RaD4rd5nQ@public.gmane.org>
2015-08-03 14:16 ` Joerg Roedel [this message]
2015-08-03 14:16 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150803141625.GB20968@8bytes.org \
--to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
--cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.