Re: [PATCH v3 1/3] PM / devfreq: cache the last call to get_dev_status()

[Javi Merino <javi.merino@arm.com>]

On Mon, Aug 03, 2015 at 06:30:53AM +0100, MyungJoo Ham wrote:
> > The return value of get_dev_status() can be reused.  Cache it so that
> > other parts of the kernel can reuse it instead of having to call the
> > same function again.
> > 
> > Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
> > Cc: Kyungmin Park <kyungmin.park@samsung.com>
> > Signed-off-by: Javi Merino <javi.merino@arm.com>
> 
> Your patch introduces build errors if you try to compile governors as
> modules. Please fix it.

Ok, with your suggestion to make devfreq_update_stats() a static
inline function this will be solved.  Sorry for that.

> And..
> > +int devfreq_update_stats(struct devfreq *df)
> > +{
> > +	return df->profile->get_dev_status(df->dev.parent, &df->last_status);
> > +}
> This seems a good candidate for a macro or a static inline function.

I'll turn it into a static inline function in <linux/devfreq.h>

> Modifications in governor_simpleondemand.c looks good.

Ok, so you are happy with this only working for that governor?

> Please add some explanations at the definition of devfreq_update_stats()
> as well in devfreq.c

I'll add kerneldoc for it.  Cheers,
Javi