Re: [PATCH v3 1/3] PM / devfreq: cache the last call to get_dev_status()

[MyungJoo Ham <myungjoo.ham@samsung.com>]

> The return value of get_dev_status() can be reused.  Cache it so that
> other parts of the kernel can reuse it instead of having to call the
> same function again.
> 
> Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
> Cc: Kyungmin Park <kyungmin.park@samsung.com>
> Signed-off-by: Javi Merino <javi.merino@arm.com>

Your patch introduces build errors if you try to compile governors as
modules. Please fix it.


And..
> +int devfreq_update_stats(struct devfreq *df)
> +{
> +	return df->profile->get_dev_status(df->dev.parent, &df->last_status);
> +}
This seems a good candidate for a macro or a static inline function.

Modifications in governor_simpleondemand.c looks good.


Please add some explanations at the definition of devfreq_update_stats()
as well in devfreq.c


Cheers,
MyungJoo.