[Buildroot] [PATCH v2 1/1] dawgdic: new package

[Buildroot] [PATCH v2 1/1] dawgdic: new package

[Jonathan Ben-Avraham]

From: Jonathan Ben Avraham <yba@tkos.co.il>

The dawgdic package provides object files and utilities for building and
accessing directed acyclical word graph (DAWG) dictionaries.

This version of the patch uses the updated GitHub dawgdic repo instead of the
Google Code repo used in the previous version of this patch.

Signed-off-by: Jonathan Ben Avraham <yba@tkos.co.il>
---
 package/Config.in          |    1 +
 package/dawgdic/Config.in  |   13 +++++++++++++
 package/dawgdic/dawgdic.mk |   17 +++++++++++++++++
 3 files changed, 31 insertions(+)
 create mode 100644 package/dawgdic/Config.in
 create mode 100644 package/dawgdic/dawgdic.mk

diff --git a/package/Config.in b/package/Config.in
index 1e39c74..ef257c1 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1041,6 +1041,7 @@ menu "Other"
 	source "package/clapack/Config.in"
 	source "package/classpath/Config.in"
 	source "package/cppcms/Config.in"
+	source "package/dawgdic/Config.in"
 	source "package/ding-libs/Config.in"
 	source "package/eigen/Config.in"
 	source "package/elfutils/Config.in"
diff --git a/package/dawgdic/Config.in b/package/dawgdic/Config.in
new file mode 100644
index 0000000..209f11a
--- /dev/null
+++ b/package/dawgdic/Config.in
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_DAWGDIC
+	bool "dawgdic"
+	help
+	  dawgdic provides a library for building and accessing
+	  dictionaries implemented with directed acyclic word graphs
+	  (DAWG). A dawg is constructed by minimizing a trie as a
+	  deterministic finite automaton (DFA), and thus the dawg has
+	  an advantage in memory usage. In addition, dawgdic uses a
+	  double-array as a base data structure, so its retrieval
+	  speed is as fast as that of Darts, a library for building
+	  and accessing double-array tries.
+
+	  https://github.com/stil/dawgdic
diff --git a/package/dawgdic/dawgdic.mk b/package/dawgdic/dawgdic.mk
new file mode 100644
index 0000000..f9b468e
--- /dev/null
+++ b/package/dawgdic/dawgdic.mk
@@ -0,0 +1,17 @@
+################################################################################
+#
+# dawgdic
+#
+################################################################################
+
+#DAWGDIC_SITE = http://dawgdic.googlecode.com/svn/trunk
+DAWGDIC_SITE = https://github.com/stil/dawgdic.git
+DAWGDIC_SITE_METHOD = git
+DAWGDIC_VERSION = 16ac537ba9883ff01b63b6d1fdc3072150c68fee
+DAWGDIC_LICENSE = GPLv3
+DAWGDIC_LICENSE_FILES = COPYING
+
+DAWGDIC_AUTORECONF = YES
+DAWGDIC_INSTALL_STAGING = YES
+
+$(eval $(autotools-package))
-- 
1.7.9.5

[Buildroot] [PATCH v2 1/1] dawgdic: new package

[Baruch Siach]

Hi Yonatan,

On Mon, Aug 03, 2015 at 12:16:03PM +0300, Jonathan Ben-Avraham wrote:
> diff --git a/package/dawgdic/dawgdic.mk b/package/dawgdic/dawgdic.mk
> new file mode 100644
> index 0000000..f9b468e
> --- /dev/null
> +++ b/package/dawgdic/dawgdic.mk
> @@ -0,0 +1,17 @@
> +################################################################################
> +#
> +# dawgdic
> +#
> +################################################################################
> +
> +#DAWGDIC_SITE = http://dawgdic.googlecode.com/svn/trunk

Please remove.

> +DAWGDIC_SITE = https://github.com/stil/dawgdic.git
> +DAWGDIC_SITE_METHOD = git
> +DAWGDIC_VERSION = 16ac537ba9883ff01b63b6d1fdc3072150c68fee

Please use the github helper. See 
http://nightly.buildroot.org/manual.html#github-download-url.

> +DAWGDIC_LICENSE = GPLv3
> +DAWGDIC_LICENSE_FILES = COPYING
> +
> +DAWGDIC_AUTORECONF = YES

Why is that needed? Please explain in a comment.

> +DAWGDIC_INSTALL_STAGING = YES
> +
> +$(eval $(autotools-package))

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

[Buildroot] [PATCH v2 1/1] dawgdic: new package

[Thomas Petazzoni]

Dear Jonathan Ben-Avraham,

On Mon,  3 Aug 2015 12:16:03 +0300, Jonathan Ben-Avraham wrote:
> From: Jonathan Ben Avraham <yba@tkos.co.il>
> 
> The dawgdic package provides object files and utilities for building and
> accessing directed acyclical word graph (DAWG) dictionaries.
> 
> This version of the patch uses the updated GitHub dawgdic repo instead of the
> Google Code repo used in the previous version of this patch.
> 
> Signed-off-by: Jonathan Ben Avraham <yba@tkos.co.il>

Patch applied, but I had to do quite a bit of changes:

    [Thomas:
      - use the github macro for <pkg>_SITE
      - remove <pkg>_SITE_METHOD, useless once you use the github macro
        for <pkg>_SITE
      - fix the license, it is BSD-3c and not GPLv3
      - remove commented <pkg>_SITE in the .mk file
      - add missing dependency on C++.]

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH v2 1/1] dawgdic: new package

[Jonathan Ben Avraham]

Hi Thomas,
Thanks.
Hold off on the other patches that I submitted. Baruch will provide 
feedback on what needs to be done and I will do the work myself from now 
on.

  - yba


On Tue, 4 Aug 2015, Thomas Petazzoni wrote:

> Date: Tue, 4 Aug 2015 11:18:48 +0200
> From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> To: Jonathan Ben-Avraham <yba@tkos.co.il>
> Cc: buildroot at busybox.net
> Subject: Re: [Buildroot] [PATCH v2 1/1] dawgdic: new package
> 
> Dear Jonathan Ben-Avraham,
>
> On Mon,  3 Aug 2015 12:16:03 +0300, Jonathan Ben-Avraham wrote:
>> From: Jonathan Ben Avraham <yba@tkos.co.il>
>>
>> The dawgdic package provides object files and utilities for building and
>> accessing directed acyclical word graph (DAWG) dictionaries.
>>
>> This version of the patch uses the updated GitHub dawgdic repo instead of the
>> Google Code repo used in the previous version of this patch.
>>
>> Signed-off-by: Jonathan Ben Avraham <yba@tkos.co.il>
>
> Patch applied, but I had to do quite a bit of changes:
>
>    [Thomas:
>      - use the github macro for <pkg>_SITE
>      - remove <pkg>_SITE_METHOD, useless once you use the github macro
>        for <pkg>_SITE
>      - fix the license, it is BSD-3c and not GPLv3
>      - remove commented <pkg>_SITE in the .mk file
>      - add missing dependency on C++.]
>
> Thanks!
>
> Thomas
>

-- 
  9590 8E58 D30D 1660 C349  673D B205 4FC4 B8F5 B7F9  ~. .~  Tk Open Systems
=}-------- Jonathan Ben-Avraham ("yba") ----------ooO--U--Ooo------------{=
mailto:yba at tkos.co.il tel:+972.52.486.3386 http://tkos.co.il skype:benavrhm

[Buildroot] [PATCH v2 1/1] dawgdic: new package

[Thomas Petazzoni]

Jonathan,

On Tue, 4 Aug 2015 12:24:29 +0300 (IDT), Jonathan Ben Avraham wrote:

> Hold off on the other patches that I submitted. Baruch will provide 
> feedback on what needs to be done and I will do the work myself from now 
> on.

Well, that's OK, I don't mind doing a bit of rework. Having perfect
patches is indeed better, but it's perfectly fine for me that new
contributors don't yet know all the "rules" / best practices.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com