From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 19/20] clocksource: atmel-st: get and use slow clock
Date: Tue, 4 Aug 2015 13:00:44 +0200 [thread overview]
Message-ID: <20150804110044.GK3486@piout.net> (raw)
In-Reply-To: <55C09477.3080209@linaro.org>
On 04/08/2015 at 12:31:19 +0200, Daniel Lezcano wrote :
> On 07/30/2015 02:22 AM, Alexandre Belloni wrote:
> >The current slow clock rate is hardcoded. Properly get the slow clock
> >and use its rate.
> >
> >Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> >---
>
> [ ... ]
>
> >+struct clk *sclk;
>
> Do you need this variable global ? AFAICS, its scope is in the init
> function, no ?
>
Indeed.
> >+int timer_latch;
>
> static.
>
Yeah, this was changed in v2 (that I forgot to label as v2).
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 19/20] clocksource: atmel-st: get and use slow clock
Date: Tue, 4 Aug 2015 13:00:44 +0200 [thread overview]
Message-ID: <20150804110044.GK3486@piout.net> (raw)
In-Reply-To: <55C09477.3080209@linaro.org>
On 04/08/2015 at 12:31:19 +0200, Daniel Lezcano wrote :
> On 07/30/2015 02:22 AM, Alexandre Belloni wrote:
> >The current slow clock rate is hardcoded. Properly get the slow clock
> >and use its rate.
> >
> >Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> >---
>
> [ ... ]
>
> >+struct clk *sclk;
>
> Do you need this variable global ? AFAICS, its scope is in the init
> function, no ?
>
Indeed.
> >+int timer_latch;
>
> static.
>
Yeah, this was changed in v2 (that I forgot to label as v2).
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-08-04 11:00 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 0:21 [PATCH 00/20] ARM: at91: Properly handle slow clock Alexandre Belloni
2015-07-30 0:21 ` Alexandre Belloni
2015-07-30 0:21 ` Alexandre Belloni
2015-07-30 0:21 ` [rtc-linux] " Alexandre Belloni
2015-07-30 0:21 ` Alexandre Belloni
2015-07-30 0:21 ` [PATCH 01/20] Documentation: dt: atmel-at91: add clocks to system timer, rstc and shdwc Alexandre Belloni
2015-07-30 0:21 ` Alexandre Belloni
2015-07-30 0:21 ` Alexandre Belloni
2015-07-30 0:21 ` [PATCH 02/20] Documentation: watchdog: at91sam9_wdt: add clocks property Alexandre Belloni
2015-07-30 0:21 ` Alexandre Belloni
2015-07-30 1:02 ` Guenter Roeck
2015-07-30 1:02 ` Guenter Roeck
2015-07-30 0:21 ` [rtc-linux] [PATCH 03/20] Documentation: dt: rtc: at91rm9200: " Alexandre Belloni
2015-07-30 0:21 ` Alexandre Belloni
2015-07-30 0:21 ` Alexandre Belloni
2015-07-30 0:21 ` [PATCH 04/20] ARM: at91/dt: at91rm9200: use slow clock where necessary Alexandre Belloni
2015-07-30 0:21 ` Alexandre Belloni
2015-07-30 0:21 ` [PATCH 05/20] ARM: at91/dt: at91sam9260: " Alexandre Belloni
2015-07-30 0:21 ` Alexandre Belloni
2015-07-30 0:21 ` [PATCH 06/20] ARM: at91/dt: at91sam9261: " Alexandre Belloni
2015-07-30 0:21 ` Alexandre Belloni
2015-07-30 0:21 ` [PATCH 07/20] ARM: at91/dt: at91sam9263: " Alexandre Belloni
2015-07-30 0:21 ` Alexandre Belloni
2015-07-30 0:21 ` [PATCH 08/20] ARM: at91/dt: at91sam9g45: " Alexandre Belloni
2015-07-30 0:21 ` Alexandre Belloni
2015-07-30 0:21 ` [PATCH 09/20] ARM: at91/dt: at91sam9n12: " Alexandre Belloni
2015-07-30 0:21 ` Alexandre Belloni
2015-07-30 0:21 ` [PATCH 10/20] ARM: at91/dt: at91sam9rl: " Alexandre Belloni
2015-07-30 0:21 ` Alexandre Belloni
2015-07-30 0:21 ` [PATCH 11/20] ARM: at91/dt: at91sam9x5: " Alexandre Belloni
2015-07-30 0:21 ` Alexandre Belloni
2015-07-30 0:21 ` [PATCH 12/20] ARM: at91/dt: sama5d3: " Alexandre Belloni
2015-07-30 0:21 ` Alexandre Belloni
2015-07-30 0:21 ` [PATCH 13/20] ARM: at91/dt: sama5d4: " Alexandre Belloni
2015-07-30 0:21 ` Alexandre Belloni
2015-07-30 0:22 ` [rtc-linux] [PATCH 14/20] rtc: at91rm9200: get and use slow clock Alexandre Belloni
2015-07-30 0:22 ` Alexandre Belloni
2015-07-30 0:22 ` Alexandre Belloni
2015-07-30 0:22 ` [PATCH 15/20] watchdog: at91sam9: " Alexandre Belloni
2015-07-30 0:22 ` Alexandre Belloni
2015-07-30 1:03 ` Guenter Roeck
2015-07-30 1:03 ` Guenter Roeck
2015-07-30 0:22 ` [PATCH 16/20] power/reset: at91-reset: remove useless at91_reset_platform_probe() Alexandre Belloni
2015-07-30 0:22 ` Alexandre Belloni
2015-07-30 9:40 ` Thomas Petazzoni
2015-07-30 9:40 ` Thomas Petazzoni
2015-07-30 0:22 ` [PATCH 17/20] power/reset: at91-reset: get and use slow clock Alexandre Belloni
2015-07-30 0:22 ` Alexandre Belloni
2015-07-30 0:22 ` [PATCH 18/20] power/reset: at91-poweroff: " Alexandre Belloni
2015-07-30 0:22 ` Alexandre Belloni
2015-07-30 0:22 ` [PATCH 19/20] clocksource: atmel-st: " Alexandre Belloni
2015-07-30 0:22 ` Alexandre Belloni
2015-07-30 9:41 ` Thomas Petazzoni
2015-07-30 9:41 ` Thomas Petazzoni
2015-08-04 10:31 ` Daniel Lezcano
2015-08-04 10:31 ` Daniel Lezcano
2015-08-04 11:00 ` Alexandre Belloni [this message]
2015-08-04 11:00 ` Alexandre Belloni
2015-07-30 0:22 ` [PATCH 20/20] clk: at91: Revert "keep slow clk enabled to prevent system hang" Alexandre Belloni
2015-07-30 0:22 ` Alexandre Belloni
2015-08-11 23:26 ` Michael Turquette
2015-08-11 23:26 ` Michael Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150804110044.GK3486@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.