From: Simon Horman <horms@verge.net.au>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org, linux-sh@vger.kernel.org,
Magnus Damm <magnus.damm@gmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [RFT 1/2] i2c: rcar: add support for r8a7795 (R-Car H3)
Date: Thu, 6 Aug 2015 09:30:41 +0900 [thread overview]
Message-ID: <20150806003041.GA17231@verge.net.au> (raw)
In-Reply-To: <1438780706-20945-2-git-send-email-wsa@the-dreams.de>
On Wed, Aug 05, 2015 at 03:18:25PM +0200, Wolfram Sang wrote:
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> Enable the I2C core for this SoC. I add a new type because this version
> has new features (e.g. DMA) which will be added somewhen later.
Minor nit: s/somewhen/sometime/
or: s/somewhen //
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> Documentation/devicetree/bindings/i2c/i2c-rcar.txt | 1 +
> drivers/i2c/busses/i2c-rcar.c | 3 +++
> 2 files changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-rcar.txt b/Documentation/devicetree/bindings/i2c/i2c-rcar.txt
> index 16b3e07aa98fdd..ea406eb20fa5ad 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-rcar.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-rcar.txt
> @@ -10,6 +10,7 @@ Required properties:
> "renesas,i2c-r8a7792"
> "renesas,i2c-r8a7793"
> "renesas,i2c-r8a7794"
> + "renesas,i2c-r8a7795"
> - reg: physical base address of the controller and length of memory mapped
> region.
> - interrupts: interrupt specifier.
> diff --git a/drivers/i2c/busses/i2c-rcar.c b/drivers/i2c/busses/i2c-rcar.c
> index d8361dada58455..3e125654bb288a 100644
> --- a/drivers/i2c/busses/i2c-rcar.c
> +++ b/drivers/i2c/busses/i2c-rcar.c
> @@ -103,6 +103,7 @@
> enum rcar_i2c_type {
> I2C_RCAR_GEN1,
> I2C_RCAR_GEN2,
> + I2C_RCAR_GEN3,
> };
>
> struct rcar_i2c_priv {
> @@ -178,6 +179,7 @@ static int rcar_i2c_clock_calculate(struct rcar_i2c_priv *priv,
> cdf_width = 2;
> break;
> case I2C_RCAR_GEN2:
> + case I2C_RCAR_GEN3:
> cdf_width = 3;
> break;
> default:
> @@ -625,6 +627,7 @@ static const struct of_device_id rcar_i2c_dt_ids[] = {
> { .compatible = "renesas,i2c-r8a7792", .data = (void *)I2C_RCAR_GEN2 },
> { .compatible = "renesas,i2c-r8a7793", .data = (void *)I2C_RCAR_GEN2 },
> { .compatible = "renesas,i2c-r8a7794", .data = (void *)I2C_RCAR_GEN2 },
> + { .compatible = "renesas,i2c-r8a7795", .data = (void *)I2C_RCAR_GEN3 },
> {},
> };
> MODULE_DEVICE_TABLE(of, rcar_i2c_dt_ids);
> --
> 2.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@verge.net.au>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org, linux-sh@vger.kernel.org,
Magnus Damm <magnus.damm@gmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [RFT 1/2] i2c: rcar: add support for r8a7795 (R-Car H3)
Date: Thu, 06 Aug 2015 00:30:41 +0000 [thread overview]
Message-ID: <20150806003041.GA17231@verge.net.au> (raw)
In-Reply-To: <1438780706-20945-2-git-send-email-wsa@the-dreams.de>
On Wed, Aug 05, 2015 at 03:18:25PM +0200, Wolfram Sang wrote:
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> Enable the I2C core for this SoC. I add a new type because this version
> has new features (e.g. DMA) which will be added somewhen later.
Minor nit: s/somewhen/sometime/
or: s/somewhen //
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> Documentation/devicetree/bindings/i2c/i2c-rcar.txt | 1 +
> drivers/i2c/busses/i2c-rcar.c | 3 +++
> 2 files changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-rcar.txt b/Documentation/devicetree/bindings/i2c/i2c-rcar.txt
> index 16b3e07aa98fdd..ea406eb20fa5ad 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-rcar.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-rcar.txt
> @@ -10,6 +10,7 @@ Required properties:
> "renesas,i2c-r8a7792"
> "renesas,i2c-r8a7793"
> "renesas,i2c-r8a7794"
> + "renesas,i2c-r8a7795"
> - reg: physical base address of the controller and length of memory mapped
> region.
> - interrupts: interrupt specifier.
> diff --git a/drivers/i2c/busses/i2c-rcar.c b/drivers/i2c/busses/i2c-rcar.c
> index d8361dada58455..3e125654bb288a 100644
> --- a/drivers/i2c/busses/i2c-rcar.c
> +++ b/drivers/i2c/busses/i2c-rcar.c
> @@ -103,6 +103,7 @@
> enum rcar_i2c_type {
> I2C_RCAR_GEN1,
> I2C_RCAR_GEN2,
> + I2C_RCAR_GEN3,
> };
>
> struct rcar_i2c_priv {
> @@ -178,6 +179,7 @@ static int rcar_i2c_clock_calculate(struct rcar_i2c_priv *priv,
> cdf_width = 2;
> break;
> case I2C_RCAR_GEN2:
> + case I2C_RCAR_GEN3:
> cdf_width = 3;
> break;
> default:
> @@ -625,6 +627,7 @@ static const struct of_device_id rcar_i2c_dt_ids[] = {
> { .compatible = "renesas,i2c-r8a7792", .data = (void *)I2C_RCAR_GEN2 },
> { .compatible = "renesas,i2c-r8a7793", .data = (void *)I2C_RCAR_GEN2 },
> { .compatible = "renesas,i2c-r8a7794", .data = (void *)I2C_RCAR_GEN2 },
> + { .compatible = "renesas,i2c-r8a7795", .data = (void *)I2C_RCAR_GEN3 },
> {},
> };
> MODULE_DEVICE_TABLE(of, rcar_i2c_dt_ids);
> --
> 2.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2015-08-06 0:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-05 13:18 [RFT 0/2] i2c: add support for r8a7795 (RCar H3) Wolfram Sang
2015-08-05 13:18 ` Wolfram Sang
2015-08-05 13:18 ` [RFT 1/2] i2c: rcar: add support for r8a7795 (R-Car H3) Wolfram Sang
2015-08-05 13:18 ` Wolfram Sang
2015-08-06 0:30 ` Simon Horman [this message]
2015-08-06 0:30 ` Simon Horman
2015-08-06 0:34 ` Laurent Pinchart
2015-08-06 0:34 ` Laurent Pinchart
2015-08-06 0:38 ` Wolfram Sang
2015-08-06 0:38 ` Wolfram Sang
2015-08-06 0:45 ` Laurent Pinchart
2015-08-06 0:45 ` Laurent Pinchart
2015-08-06 0:52 ` Wolfram Sang
2015-08-06 0:52 ` Wolfram Sang
[not found] ` <1438780706-20945-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2015-08-05 13:18 ` [RFT 2/2] i2c: sh_mobile: " Wolfram Sang
2015-08-05 13:18 ` Wolfram Sang
2015-09-17 5:08 ` [RFT 0/2] i2c: add support for r8a7795 (RCar H3) Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150806003041.GA17231@verge.net.au \
--to=horms@verge.net.au \
--cc=geert@linux-m68k.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.