From: Guenter Roeck <linux@roeck-us.net>
To: James Hogan <james.hogan@imgtec.com>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
linux-mips@linux-mips.org, Kees Cook <keescook@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 0/7] test_user_copy improvements
Date: Thu, 6 Aug 2015 02:50:09 -0700 [thread overview]
Message-ID: <20150806095009.GA8498@roeck-us.net> (raw)
In-Reply-To: <1438789735-4643-1-git-send-email-james.hogan@imgtec.com>
Hi James,
On Wed, Aug 05, 2015 at 04:48:48PM +0100, James Hogan wrote:
> These patches extend the test_user_copy test module to handle lots more
> cases of user accessors which architectures can override separately, and
> in particular those which are important for checking the MIPS Enhanced
> Virtual Addressing (EVA) implementations, which need to handle
> overlapping user and kernel address spaces, with special instructions
> for accessing user address space from kernel mode.
>
> - Checking that kernel pointers are accepted when user address limit is
> set to KERNEL_DS, as done by the kernel when it internally invokes
> system calls with kernel pointers.
> - Checking of the unchecked accessors (which don't call access_ok()).
> Some of the tests are special cased for EVA at the moment which has
> stricter hardware guarantees for bad user accesses than other
> configurations.
> - Checking of other sets of user accessors, including the inatomic user
> copies, copy_in_user, clear_user, the user string accessors, and the
> user checksum functions, all of which need special handling in arch
> code with EVA.
>
> Tested on MIPS with and without EVA, and on x86_64.
>
The series causes several build failures with other architectures.
From next-20150806:
Build results:
total: 152 pass: 138 fail: 14
Failed builds:
alpha:allmodconfig (*)
arm:allmodconfig (*)
arm:omap2plus_defconfig
arm64:allmodconfig
i386:allyesconfig (*)
i386:allmodconfig (*)
m68k:defconfig (*)
m68k:allmodconfig (*)
m68k:sun3_defconfig (*)
mips:allmodconfig
parisc:allmodconfig
s390:allmodconfig
sparc32:allmodconfig (*)
xtensa:allmodconfig (*)
The builds marked with (*) fail because of your patch series.
Guenter
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: James Hogan <james.hogan@imgtec.com>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
linux-mips@linux-mips.org, Kees Cook <keescook@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 0/7] test_user_copy improvements
Date: Thu, 6 Aug 2015 02:50:09 -0700 [thread overview]
Message-ID: <20150806095009.GA8498@roeck-us.net> (raw)
Message-ID: <20150806095009.wlxYjlaWRT5Rwdw3nnxucq-J0OmxrxciVRTbQgsn4gg@z> (raw)
In-Reply-To: <1438789735-4643-1-git-send-email-james.hogan@imgtec.com>
Hi James,
On Wed, Aug 05, 2015 at 04:48:48PM +0100, James Hogan wrote:
> These patches extend the test_user_copy test module to handle lots more
> cases of user accessors which architectures can override separately, and
> in particular those which are important for checking the MIPS Enhanced
> Virtual Addressing (EVA) implementations, which need to handle
> overlapping user and kernel address spaces, with special instructions
> for accessing user address space from kernel mode.
>
> - Checking that kernel pointers are accepted when user address limit is
> set to KERNEL_DS, as done by the kernel when it internally invokes
> system calls with kernel pointers.
> - Checking of the unchecked accessors (which don't call access_ok()).
> Some of the tests are special cased for EVA at the moment which has
> stricter hardware guarantees for bad user accesses than other
> configurations.
> - Checking of other sets of user accessors, including the inatomic user
> copies, copy_in_user, clear_user, the user string accessors, and the
> user checksum functions, all of which need special handling in arch
> code with EVA.
>
> Tested on MIPS with and without EVA, and on x86_64.
>
The series causes several build failures with other architectures.
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: James Hogan <james.hogan@imgtec.com>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
linux-mips@linux-mips.org, Kees Cook <keescook@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 0/7] test_user_copy improvements
Date: Thu, 6 Aug 2015 02:50:09 -0700 [thread overview]
Message-ID: <20150806095009.GA8498@roeck-us.net> (raw)
In-Reply-To: <1438789735-4643-1-git-send-email-james.hogan@imgtec.com>
Hi James,
On Wed, Aug 05, 2015 at 04:48:48PM +0100, James Hogan wrote:
> These patches extend the test_user_copy test module to handle lots more
> cases of user accessors which architectures can override separately, and
> in particular those which are important for checking the MIPS Enhanced
> Virtual Addressing (EVA) implementations, which need to handle
> overlapping user and kernel address spaces, with special instructions
> for accessing user address space from kernel mode.
>
> - Checking that kernel pointers are accepted when user address limit is
> set to KERNEL_DS, as done by the kernel when it internally invokes
> system calls with kernel pointers.
> - Checking of the unchecked accessors (which don't call access_ok()).
> Some of the tests are special cased for EVA at the moment which has
> stricter hardware guarantees for bad user accesses than other
> configurations.
> - Checking of other sets of user accessors, including the inatomic user
> copies, copy_in_user, clear_user, the user string accessors, and the
> user checksum functions, all of which need special handling in arch
> code with EVA.
>
> Tested on MIPS with and without EVA, and on x86_64.
>
The series causes several build failures with other architectures.
>From next-20150806:
Build results:
total: 152 pass: 138 fail: 14
Failed builds:
alpha:allmodconfig (*)
arm:allmodconfig (*)
arm:omap2plus_defconfig
arm64:allmodconfig
i386:allyesconfig (*)
i386:allmodconfig (*)
m68k:defconfig (*)
m68k:allmodconfig (*)
m68k:sun3_defconfig (*)
mips:allmodconfig
parisc:allmodconfig
s390:allmodconfig
sparc32:allmodconfig (*)
xtensa:allmodconfig (*)
The builds marked with (*) fail because of your patch series.
Guenter
next prev parent reply other threads:[~2015-08-06 9:50 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-05 15:48 [PATCH 0/7] test_user_copy improvements James Hogan
2015-08-05 15:48 ` James Hogan
2015-08-05 15:48 ` [PATCH 1/7] test_user_copy: Check legit kernel accesses James Hogan
2015-08-05 15:48 ` James Hogan
2015-08-05 15:48 ` [PATCH 2/7] test_user_copy: Check unchecked accessors James Hogan
2015-08-05 15:48 ` James Hogan
2015-08-05 15:48 ` [PATCH 3/7] test_user_copy: Check __clear_user()/clear_user() James Hogan
2015-08-05 15:48 ` James Hogan
2015-08-05 15:48 ` [PATCH 4/7] test_user_copy: Check __copy_in_user()/copy_in_user() James Hogan
2015-08-05 15:48 ` James Hogan
2015-08-05 15:48 ` [PATCH 5/7] test_user_copy: Check __copy_{to,from}_user_inatomic() James Hogan
2015-08-05 15:48 ` James Hogan
2015-08-05 15:48 ` [PATCH 6/7] test_user_copy: Check user string accessors James Hogan
2015-08-05 15:48 ` James Hogan
2015-08-05 15:48 ` [PATCH 7/7] test_user_copy: Check user checksum functions James Hogan
2015-08-05 15:48 ` James Hogan
2015-08-05 20:26 ` [PATCH 0/7] test_user_copy improvements Kees Cook
2015-08-06 16:28 ` James Hogan
2015-08-06 9:50 ` Guenter Roeck [this message]
2015-08-06 9:50 ` Guenter Roeck
2015-08-06 9:50 ` Guenter Roeck
2015-08-06 10:01 ` James Hogan
2015-08-06 10:01 ` James Hogan
2015-08-06 15:02 ` James Hogan
2015-08-06 15:02 ` James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150806095009.GA8498@roeck-us.net \
--to=linux@roeck-us.net \
--cc=akpm@linux-foundation.org \
--cc=james.hogan@imgtec.com \
--cc=keescook@chromium.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.