All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH kvmtool] kvm__emulate_io: Don't fall through from IO in to IO out if no handler
@ 2015-08-06 18:39 Josh Triplett
  0 siblings, 0 replies; only message in thread
From: Josh Triplett @ 2015-08-06 18:39 UTC (permalink / raw)
  To: kvm; +Cc: Will Deacon

If an IO port device has no io_in handler, kvm__emulate_io would fall
through and call the io_out handler instead.  Fix to only call the
handler for the appropriate direction.

If no handler exists, kvm__emulate_io will automatically treat it as an
IO error (due to the default "ret = false").

Signed-off-by: Josh Triplett <josh@joshtriplett.org>
---
 ioport.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ioport.c b/ioport.c
index 8c55a84..263fe50 100644
--- a/ioport.c
+++ b/ioport.c
@@ -192,7 +192,7 @@ bool kvm__emulate_io(struct kvm_cpu *vcpu, u16 port, void *data, int direction,
 	while (count--) {
 		if (direction == KVM_EXIT_IO_IN && ops->io_in)
 				ret = ops->io_in(entry, vcpu, port, ptr, size);
-		else if (ops->io_out)
+		else if (direction == KVM_EXIT_IO_OUT && ops->io_out)
 				ret = ops->io_out(entry, vcpu, port, ptr, size);
 
 		ptr += size;
-- 
2.5.0


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2015-08-06 18:40 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-06 18:39 [PATCH kvmtool] kvm__emulate_io: Don't fall through from IO in to IO out if no handler Josh Triplett

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.