From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Takashi Iwai <tiwai@suse.com>,
Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
patches@opensource.wolfsonmicro.com, linux-input@vger.kernel.org,
alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: ac97: Switch to dev_pm_ops
Date: Fri, 7 Aug 2015 09:30:29 -0700 [thread overview]
Message-ID: <20150807163029.GA30852@dtor-ws> (raw)
In-Reply-To: <20150807133005.GG10301@sirena.org.uk>
On Fri, Aug 07, 2015 at 02:30:05PM +0100, Mark Brown wrote:
> On Fri, Aug 07, 2015 at 10:13:48AM +0200, Lars-Peter Clausen wrote:
> > On 08/07/2015 12:55 AM, Dmitry Torokhov wrote:
>
> > > Pull this out of #ifdef block and kill entire #else/endif along with
> > > WM97XX_PM_OPS define: SIMPLE_DEV_PM_OPS will result in an empty
> > > structure if CONFIG_PM_SLEEP is not set.
>
> > It will create a struct dev_pm_ops full of NULLs. That's kind of
> > counterproductive to removing PM related data and functions from the kernel
> > if PM support is no enabled.
>
> Indeed, a major goal of disabling PM support is to save space.
Then maybe we should adjust dev_pm_ops definition to omit members that
are not used if given state is not supported? We have a lot of drivers
that are not doing silly pointer #define games.
--
Dmitry
next prev parent reply other threads:[~2015-08-07 16:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-06 19:42 [PATCH] ALSA: ac97: Switch to dev_pm_ops Lars-Peter Clausen
2015-08-06 22:55 ` Dmitry Torokhov
2015-08-07 8:13 ` Lars-Peter Clausen
2015-08-07 13:30 ` Mark Brown
2015-08-07 16:30 ` Dmitry Torokhov [this message]
2015-08-07 16:38 ` Mark Brown
2015-08-07 16:32 ` Dmitry Torokhov
2015-08-20 16:33 ` Mark Brown
2015-08-20 16:35 ` Lars-Peter Clausen
2015-08-20 17:18 ` Mark Brown
2015-08-20 16:35 ` Applied "ALSA: ac97: Switch to dev_pm_ops" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150807163029.GA30852@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=lars@metafoo.de \
--cc=linux-input@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.