From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Takashi Iwai <tiwai@suse.com>,
Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
patches@opensource.wolfsonmicro.com, linux-input@vger.kernel.org,
alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: ac97: Switch to dev_pm_ops
Date: Thu, 20 Aug 2015 18:35:24 +0200 [thread overview]
Message-ID: <55D601CC.4030707@metafoo.de> (raw)
In-Reply-To: <20150820163301.GA12027@sirena.org.uk>
[-- Attachment #1: Type: text/plain, Size: 847 bytes --]
On 08/20/2015 06:33 PM, Mark Brown wrote:
> On Fri, Aug 07, 2015 at 09:32:13AM -0700, Dmitry Torokhov wrote:
>> On Fri, Aug 07, 2015 at 10:13:48AM +0200, Lars-Peter Clausen wrote:
>
>>> We know that it is used when CONFIG_PM_SLEEP is defined and we know that it
>>> is unused CONFIG_PM_SLEEP is not defined. Marking the function as
>>> __maybe_unused will cause the compiler to not generate a warning when the
>>> function is really unused. Making this explicit works much better.
>
>> It will also drop the code form the final image and having the functions
>> in provides better compile coverage.
>
> Just discussed this in person with Dmitry: I'll apply the patch just now
> for v4.3 and we can incrementally improve the ifdef handling after.
Great, thanks. I was about to send a patch with the ifdefs removed tomorrow.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-08-20 16:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-06 19:42 [PATCH] ALSA: ac97: Switch to dev_pm_ops Lars-Peter Clausen
2015-08-06 22:55 ` Dmitry Torokhov
2015-08-07 8:13 ` Lars-Peter Clausen
2015-08-07 13:30 ` Mark Brown
2015-08-07 16:30 ` Dmitry Torokhov
2015-08-07 16:38 ` Mark Brown
2015-08-07 16:32 ` Dmitry Torokhov
2015-08-20 16:33 ` Mark Brown
2015-08-20 16:35 ` Lars-Peter Clausen [this message]
2015-08-20 17:18 ` Mark Brown
2015-08-20 16:35 ` Applied "ALSA: ac97: Switch to dev_pm_ops" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55D601CC.4030707@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.