From: Wolfram Sang <wsa@the-dreams.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux I2C <linux-i2c@vger.kernel.org>,
Linux-sh list <linux-sh@vger.kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
Simon Horman <horms@verge.net.au>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Andrey Danin <danindrey@mail.ru>,
Stephen Warren <swarren@wwwdotorg.org>
Subject: Re: [PATCH 08/10] i2c: support 10 bit and slave addresses in sysfs 'new_device'
Date: Mon, 10 Aug 2015 16:00:22 +0200 [thread overview]
Message-ID: <20150810140022.GA7159@katana> (raw)
In-Reply-To: <CAMuHMdWfL3SwzZ=Wu5X96Npf9RHmVWc7o7R+uLfvuiRRSpQR9w@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1297 bytes --]
On Mon, Aug 10, 2015 at 03:17:03PM +0200, Geert Uytterhoeven wrote:
> Hi Wolfram,
>
> On Sat, Aug 8, 2015 at 10:33 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
> > diff --git a/Documentation/i2c/slave-interface b/Documentation/i2c/slave-interface
> > index 2dee4e2d62df19..61ed05cd95317f 100644
> > --- a/Documentation/i2c/slave-interface
> > +++ b/Documentation/i2c/slave-interface
> > @@ -31,10 +31,13 @@ User manual
> > ===========
> >
> > I2C slave backends behave like standard I2C clients. So, you can instantiate
> > -them as described in the document 'instantiating-devices'. A quick example for
> > -instantiating the slave-eeprom driver from userspace at address 0x64 on bus 1:
> > +them as described in the document 'instantiating-devices'. The only difference
> > +is that i2c slave backends have their own address space. So, you have to add
> > +0x1000 to the address you would originally request. An example for
> > +instantiating the slave-eeprom driver from userspace at the 7 bit address 0x64
> > +on bus 1:
> >
> > - # echo slave-24c02 0x64 > /sys/bus/i2c/devices/i2c-1/new_device
> > + # echo slave-24c02 0x1064 > /sys/bus/i2c/devices/i2c-1/new_device
>
> Does 0x64 still work? It's an ABI since v4.1.
Yes, you'll see the warning from patch 9.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux I2C <linux-i2c@vger.kernel.org>,
Linux-sh list <linux-sh@vger.kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
Simon Horman <horms@verge.net.au>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Andrey Danin <danindrey@mail.ru>,
Stephen Warren <swarren@wwwdotorg.org>
Subject: Re: [PATCH 08/10] i2c: support 10 bit and slave addresses in sysfs 'new_device'
Date: Mon, 10 Aug 2015 14:00:22 +0000 [thread overview]
Message-ID: <20150810140022.GA7159@katana> (raw)
In-Reply-To: <CAMuHMdWfL3SwzZ=Wu5X96Npf9RHmVWc7o7R+uLfvuiRRSpQR9w@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1297 bytes --]
On Mon, Aug 10, 2015 at 03:17:03PM +0200, Geert Uytterhoeven wrote:
> Hi Wolfram,
>
> On Sat, Aug 8, 2015 at 10:33 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
> > diff --git a/Documentation/i2c/slave-interface b/Documentation/i2c/slave-interface
> > index 2dee4e2d62df19..61ed05cd95317f 100644
> > --- a/Documentation/i2c/slave-interface
> > +++ b/Documentation/i2c/slave-interface
> > @@ -31,10 +31,13 @@ User manual
> > ===========
> >
> > I2C slave backends behave like standard I2C clients. So, you can instantiate
> > -them as described in the document 'instantiating-devices'. A quick example for
> > -instantiating the slave-eeprom driver from userspace at address 0x64 on bus 1:
> > +them as described in the document 'instantiating-devices'. The only difference
> > +is that i2c slave backends have their own address space. So, you have to add
> > +0x1000 to the address you would originally request. An example for
> > +instantiating the slave-eeprom driver from userspace at the 7 bit address 0x64
> > +on bus 1:
> >
> > - # echo slave-24c02 0x64 > /sys/bus/i2c/devices/i2c-1/new_device
> > + # echo slave-24c02 0x1064 > /sys/bus/i2c/devices/i2c-1/new_device
>
> Does 0x64 still work? It's an ABI since v4.1.
Yes, you'll see the warning from patch 9.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-08-10 14:00 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-08 20:33 [PATCH 00/10] i2c: improve i2c client address spaces and their DT support Wolfram Sang
2015-08-08 20:33 ` Wolfram Sang
2015-08-08 20:33 ` [PATCH 01/10] dt-bindings: add header for generic I2C flags in bindings Wolfram Sang
2015-08-08 20:33 ` Wolfram Sang
2015-08-08 20:33 ` [PATCH 02/10] i2c: add a flag to mark clients as slaves Wolfram Sang
2015-08-08 20:33 ` Wolfram Sang
[not found] ` <1439066007-13951-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2015-08-08 20:33 ` [PATCH 03/10] i2c: apply address offset for slaves, too Wolfram Sang
2015-08-08 20:33 ` Wolfram Sang
2015-08-08 20:33 ` [PATCH 09/10] i2c: slave: print warning if slave flag not set Wolfram Sang
2015-08-08 20:33 ` Wolfram Sang
2015-08-08 20:33 ` [PATCH 04/10] i2c: rename address check functions Wolfram Sang
2015-08-08 20:33 ` Wolfram Sang
2015-08-08 20:33 ` [PATCH 05/10] i2c: make address check indpendent from client struct Wolfram Sang
2015-08-08 20:33 ` Wolfram Sang
2015-08-08 20:33 ` [PATCH 06/10] i2c: apply DT flags when probing Wolfram Sang
2015-08-08 20:33 ` Wolfram Sang
2015-08-08 20:33 ` [PATCH 07/10] i2c: take address space into account when checking for used addresses Wolfram Sang
2015-08-08 20:33 ` Wolfram Sang
2015-08-08 20:33 ` [PATCH 08/10] i2c: support 10 bit and slave addresses in sysfs 'new_device' Wolfram Sang
2015-08-08 20:33 ` Wolfram Sang
2015-08-10 13:17 ` Geert Uytterhoeven
2015-08-10 13:17 ` Geert Uytterhoeven
2015-08-10 14:00 ` Wolfram Sang [this message]
2015-08-10 14:00 ` Wolfram Sang
2015-08-08 20:33 ` [PATCH 10/10] i2c: dt: describe generic bindings Wolfram Sang
2015-08-08 20:33 ` Wolfram Sang
2015-08-09 9:51 ` Vaibhav Hiremath
2015-08-09 9:51 ` Vaibhav Hiremath
2015-08-09 12:15 ` Wolfram Sang
2015-08-09 12:15 ` Wolfram Sang
2015-08-09 12:17 ` Vaibhav Hiremath
2015-08-09 12:29 ` Vaibhav Hiremath
2015-08-14 18:22 ` [PATCH 00/10] i2c: improve i2c client address spaces and their DT support Wolfram Sang
2015-08-14 18:22 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150810140022.GA7159@katana \
--to=wsa@the-dreams.de \
--cc=danindrey@mail.ru \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.