From: Lee Jones <lee.jones@linaro.org>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/4] mfd: max77686: Use a generic name for the PMIC node in the example
Date: Tue, 11 Aug 2015 12:48:40 +0100 [thread overview]
Message-ID: <20150811114840.GC18282@x1> (raw)
In-Reply-To: <1438252327-28427-3-git-send-email-javier@osg.samsung.com>
On Thu, 30 Jul 2015, Javier Martinez Canillas wrote:
> The ePAPR standard says that: "the name of a node should be somewhat
> generic, reflecting the function of the device and not its precise
> programming model."
>
> So, change the max77686 binding document example to use a generic
> node name instead of using the chip's name.
>
> Suggested-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> Changes in v3:
> - Fix typo in ePAPR document name. Suggested by Sergei Shtylyov
>
> Changes in v2: None
>
> Documentation/devicetree/bindings/mfd/max77686.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Lee Jones <lee.jones@linaro.org>
> diff --git a/Documentation/devicetree/bindings/mfd/max77686.txt b/Documentation/devicetree/bindings/mfd/max77686.txt
> index 8221102d3fc2..d2ed3c20a5c3 100644
> --- a/Documentation/devicetree/bindings/mfd/max77686.txt
> +++ b/Documentation/devicetree/bindings/mfd/max77686.txt
> @@ -48,7 +48,7 @@ to get matched with their hardware counterparts as follow:
>
> Example:
>
> - max77686@09 {
> + max77686: pmic@09 {
> compatible = "maxim,max77686";
> interrupt-parent = <&wakeup_eint>;
> interrupts = <26 0>;
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/4] mfd: max77686: Use a generic name for the PMIC node in the example
Date: Tue, 11 Aug 2015 12:48:40 +0100 [thread overview]
Message-ID: <20150811114840.GC18282@x1> (raw)
In-Reply-To: <1438252327-28427-3-git-send-email-javier@osg.samsung.com>
On Thu, 30 Jul 2015, Javier Martinez Canillas wrote:
> The ePAPR standard says that: "the name of a node should be somewhat
> generic, reflecting the function of the device and not its precise
> programming model."
>
> So, change the max77686 binding document example to use a generic
> node name instead of using the chip's name.
>
> Suggested-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> Changes in v3:
> - Fix typo in ePAPR document name. Suggested by Sergei Shtylyov
>
> Changes in v2: None
>
> Documentation/devicetree/bindings/mfd/max77686.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Lee Jones <lee.jones@linaro.org>
> diff --git a/Documentation/devicetree/bindings/mfd/max77686.txt b/Documentation/devicetree/bindings/mfd/max77686.txt
> index 8221102d3fc2..d2ed3c20a5c3 100644
> --- a/Documentation/devicetree/bindings/mfd/max77686.txt
> +++ b/Documentation/devicetree/bindings/mfd/max77686.txt
> @@ -48,7 +48,7 @@ to get matched with their hardware counterparts as follow:
>
> Example:
>
> - max77686 at 09 {
> + max77686: pmic at 09 {
> compatible = "maxim,max77686";
> interrupt-parent = <&wakeup_eint>;
> interrupts = <26 0>;
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2015-08-11 11:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 10:32 [PATCH v3 0/4] mfd: Improve DT binding docs for max77686 and max77802 Javier Martinez Canillas
2015-07-30 10:32 ` Javier Martinez Canillas
2015-07-30 10:32 ` [PATCH v3 1/4] mfd: max77686: Don't suggest in binding to use a deprecated property Javier Martinez Canillas
2015-07-30 10:32 ` Javier Martinez Canillas
2015-08-11 11:49 ` Lee Jones
2015-08-11 11:49 ` Lee Jones
2015-07-30 10:32 ` [PATCH v3 2/4] mfd: max77686: Use a generic name for the PMIC node in the example Javier Martinez Canillas
2015-07-30 10:32 ` Javier Martinez Canillas
2015-08-11 11:48 ` Lee Jones [this message]
2015-08-11 11:48 ` Lee Jones
2015-07-30 10:32 ` [PATCH v3 3/4] mfd: Add DT binding for Maxim MAX77802 IC Javier Martinez Canillas
2015-07-30 10:32 ` Javier Martinez Canillas
2015-08-11 11:47 ` Lee Jones
2015-08-11 11:47 ` Lee Jones
2015-08-11 15:25 ` Javier Martinez Canillas
2015-08-11 15:25 ` Javier Martinez Canillas
2015-07-30 10:32 ` [PATCH v3 4/4] mfd: max77686: Split out regulator part from the DT binding Javier Martinez Canillas
2015-07-30 10:32 ` Javier Martinez Canillas
2015-08-11 10:26 ` [PATCH v3 0/4] mfd: Improve DT binding docs for max77686 and max77802 Javier Martinez Canillas
2015-08-11 10:26 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150811114840.GC18282@x1 \
--to=lee.jones@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=javier@osg.samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.