All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-kernel@vger.kernel.org, Adrian Huang <ahuang12@lenovo.com>,
	Egbert Eich <eich@suse.de>,
	Diego Ercolani <diego.ercolani@gmail.com>,
	Borislav Petkov <bp@suse.de>,
	Alessandro Zummo <a.zummo@towertech.it>,
	rtc-linux@googlegroups.com
Subject: [rtc-linux] Re: [PATCH] drivers/rtc: fix compile warning introduced by 1s reboot fix
Date: Tue, 11 Aug 2015 16:15:47 +0200	[thread overview]
Message-ID: <20150811141547.GP3411@piout.net> (raw)
In-Reply-To: <1439301844-22710-1-git-send-email-paul.gortmaker@windriver.com>

Hi Paul,

On 11/08/2015 at 10:04:04 -0400, Paul Gortmaker wrote :
> We currently see this warning:
> 
> drivers/rtc/rtc-cmos.c:851:7: warning: unused variable 'err'
> 
> introduced by commit 7b4a008088a28ea936fffbbfa770d0184468a0ce ("rtc-cmos:
> Cancel alarm timer if alarm time is equal to now+1 seconds").
> 
> Presumably some WIP version of the commit was doing error checking
> but then the variable was not removed prior to submission, and the
> pending commits weren't on kernel.org for kbuild bot to spot the new
> warning created.
> 
> Cc: Adrian Huang <ahuang12@lenovo.com>
> Cc: Egbert Eich <eich@suse.de>
> Cc: Diego Ercolani <diego.ercolani@gmail.com>
> Cc: Borislav Petkov <bp@suse.de>
> Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> Cc: Alessandro Zummo <a.zummo@towertech.it>
> Cc: rtc-linux@googlegroups.com
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
> 
> [Note: patch is against linux-next, so if the rtc tree is rebased,
>  then the above commit ID reference will be stale.  Feel free to
>  adjust the commit log appropriately, if need be, or even squash
>  this into the original offending patch, if rebasing back that far.
>  Also ensuring your tree is on kernel.org will allow kbuild bot
>  to spot these on your behalf via the zero day builds.]
> 

I'm pretty sure my rtc-next branch on kernel.org already carry the fix.
I fixed it on monday: 2015-08-10 07:12:44 (GMT). It just seems that
linux-next has not been updated since then.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

-- 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-kernel@vger.kernel.org, Adrian Huang <ahuang12@lenovo.com>,
	Egbert Eich <eich@suse.de>,
	Diego Ercolani <diego.ercolani@gmail.com>,
	Borislav Petkov <bp@suse.de>,
	Alessandro Zummo <a.zummo@towertech.it>,
	rtc-linux@googlegroups.com
Subject: Re: [PATCH] drivers/rtc: fix compile warning introduced by 1s reboot fix
Date: Tue, 11 Aug 2015 16:15:47 +0200	[thread overview]
Message-ID: <20150811141547.GP3411@piout.net> (raw)
In-Reply-To: <1439301844-22710-1-git-send-email-paul.gortmaker@windriver.com>

Hi Paul,

On 11/08/2015 at 10:04:04 -0400, Paul Gortmaker wrote :
> We currently see this warning:
> 
> drivers/rtc/rtc-cmos.c:851:7: warning: unused variable 'err'
> 
> introduced by commit 7b4a008088a28ea936fffbbfa770d0184468a0ce ("rtc-cmos:
> Cancel alarm timer if alarm time is equal to now+1 seconds").
> 
> Presumably some WIP version of the commit was doing error checking
> but then the variable was not removed prior to submission, and the
> pending commits weren't on kernel.org for kbuild bot to spot the new
> warning created.
> 
> Cc: Adrian Huang <ahuang12@lenovo.com>
> Cc: Egbert Eich <eich@suse.de>
> Cc: Diego Ercolani <diego.ercolani@gmail.com>
> Cc: Borislav Petkov <bp@suse.de>
> Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> Cc: Alessandro Zummo <a.zummo@towertech.it>
> Cc: rtc-linux@googlegroups.com
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
> 
> [Note: patch is against linux-next, so if the rtc tree is rebased,
>  then the above commit ID reference will be stale.  Feel free to
>  adjust the commit log appropriately, if need be, or even squash
>  this into the original offending patch, if rebasing back that far.
>  Also ensuring your tree is on kernel.org will allow kbuild bot
>  to spot these on your behalf via the zero day builds.]
> 

I'm pretty sure my rtc-next branch on kernel.org already carry the fix.
I fixed it on monday: 2015-08-10 07:12:44 (GMT). It just seems that
linux-next has not been updated since then.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-08-11 14:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-11 14:04 [rtc-linux] [PATCH] drivers/rtc: fix compile warning introduced by 1s reboot fix Paul Gortmaker
2015-08-11 14:04 ` Paul Gortmaker
2015-08-11 14:15 ` Alexandre Belloni [this message]
2015-08-11 14:15   ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150811141547.GP3411@piout.net \
    --to=alexandre.belloni@free-electrons.com \
    --cc=a.zummo@towertech.it \
    --cc=ahuang12@lenovo.com \
    --cc=bp@suse.de \
    --cc=diego.ercolani@gmail.com \
    --cc=eich@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.