From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 3/3] device property: attach 'else if' to the proper 'if'
Date: Wed, 12 Aug 2015 14:52:18 +0300 [thread overview]
Message-ID: <20150812115218.GR1541@lahna.fi.intel.com> (raw)
In-Reply-To: <1439225808-132916-3-git-send-email-andriy.shevchenko@linux.intel.com>
On Mon, Aug 10, 2015 at 07:56:48PM +0300, Andy Shevchenko wrote:
> Obviously in the current place the 'else' keyword is redundant, though it seems
> quite correct when we check if nval is in allowed range.
>
> Reattach the condition branch there.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
When the leftovers you mentioned are dropped you can add my,
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
next prev parent reply other threads:[~2015-08-12 11:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-10 16:56 [PATCH v1 1/3] device property: check fwnode type in to_of_node() Andy Shevchenko
2015-08-10 16:56 ` [PATCH v1 2/3] device property: fallback to pset when gettng one string Andy Shevchenko
2015-08-12 11:48 ` Mika Westerberg
2015-08-10 16:56 ` [PATCH v1 3/3] device property: attach 'else if' to the proper 'if' Andy Shevchenko
2015-08-10 17:05 ` Andy Shevchenko
2015-08-12 11:52 ` Mika Westerberg [this message]
2015-08-12 11:47 ` [PATCH v1 1/3] device property: check fwnode type in to_of_node() Mika Westerberg
2015-08-26 0:17 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150812115218.GR1541@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.