From: Thierry Reding <thierry.reding@gmail.com>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: linux-pm@vger.kernel.org,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Russell King <linux@arm.linux.org.uk>,
Stephen Warren <swarren@wwwdotorg.org>,
Alexandre Courbot <gnurou@gmail.com>,
Kukjin Kim <kgene.kim@samsung.com>,
Ingo Molnar <mingo@kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] ARM: tegra: cpuidle: implement cpuidle_state.enter_freeze()
Date: Thu, 13 Aug 2015 16:54:47 +0200 [thread overview]
Message-ID: <20150813145446.GD26559@ulmo> (raw)
In-Reply-To: <1432046953-12945-1-git-send-email-tomeu.vizoso@collabora.com>
[-- Attachment #1: Type: text/plain, Size: 943 bytes --]
On Tue, May 19, 2015 at 04:49:12PM +0200, Tomeu Vizoso wrote:
> This callback is expected to do the same as enter() but it has to
> guarantee that interrupts aren't enabled at any point in its execution,
> as the tick is frozen.
>
> It will be called when the system goes to suspend-to-idle and will
> reduce power usage because CPUs won't be awaken for unnecessary IRQs.
>
> By setting the CPUIDLE_FLAG_TIMER_STOP flag, we can reuse the same code
> for both the enter() and enter_freeze() callbacks.
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> ---
>
> v3: * Set CPUIDLE_FLAG_TIMER_STOP to simplify things as suggested by
> Lorenzo Pieralisi
> v2: * Disable FIQs also when suspending-to-idle
> ---
> arch/arm/mach-tegra/cpuidle-tegra114.c | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] ARM: tegra: cpuidle: implement cpuidle_state.enter_freeze()
Date: Thu, 13 Aug 2015 16:54:47 +0200 [thread overview]
Message-ID: <20150813145446.GD26559@ulmo> (raw)
In-Reply-To: <1432046953-12945-1-git-send-email-tomeu.vizoso@collabora.com>
On Tue, May 19, 2015 at 04:49:12PM +0200, Tomeu Vizoso wrote:
> This callback is expected to do the same as enter() but it has to
> guarantee that interrupts aren't enabled at any point in its execution,
> as the tick is frozen.
>
> It will be called when the system goes to suspend-to-idle and will
> reduce power usage because CPUs won't be awaken for unnecessary IRQs.
>
> By setting the CPUIDLE_FLAG_TIMER_STOP flag, we can reuse the same code
> for both the enter() and enter_freeze() callbacks.
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> ---
>
> v3: * Set CPUIDLE_FLAG_TIMER_STOP to simplify things as suggested by
> Lorenzo Pieralisi
> v2: * Disable FIQs also when suspending-to-idle
> ---
> arch/arm/mach-tegra/cpuidle-tegra114.c | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)
Applied, thanks.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150813/06f41e28/attachment.sig>
next prev parent reply other threads:[~2015-08-13 14:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 14:49 [PATCH v3] ARM: tegra: cpuidle: implement cpuidle_state.enter_freeze() Tomeu Vizoso
2015-05-19 14:49 ` Tomeu Vizoso
[not found] ` <1432046953-12945-1-git-send-email-tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2015-05-20 8:44 ` Lorenzo Pieralisi
2015-05-20 8:44 ` Lorenzo Pieralisi
2015-05-20 8:44 ` Lorenzo Pieralisi
2015-05-20 8:55 ` Tomeu Vizoso
2015-05-20 8:55 ` Tomeu Vizoso
2015-05-20 8:55 ` Tomeu Vizoso
2015-05-20 9:04 ` Lorenzo Pieralisi
2015-05-20 9:04 ` Lorenzo Pieralisi
2015-05-21 1:02 ` Rafael J. Wysocki
2015-05-21 1:02 ` Rafael J. Wysocki
2015-05-21 1:02 ` Rafael J. Wysocki
2015-06-18 7:09 ` Tomeu Vizoso
2015-06-18 7:09 ` Tomeu Vizoso
2015-06-29 9:00 ` Thierry Reding
2015-06-29 9:00 ` Thierry Reding
2015-06-29 9:18 ` Tomeu Vizoso
2015-06-29 9:18 ` Tomeu Vizoso
2015-06-29 9:18 ` Tomeu Vizoso
2015-08-13 14:54 ` Thierry Reding [this message]
2015-08-13 14:54 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150813145446.GD26559@ulmo \
--to=thierry.reding@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=daniel.lezcano@linaro.org \
--cc=gnurou@gmail.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=lorenzo.pieralisi@arm.com \
--cc=mingo@kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=swarren@wwwdotorg.org \
--cc=tglx@linutronix.de \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.