From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jonathan Cameron <jic23@kernel.org>, Peter Meerwald <pmeerw@pmeerw.net>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Dan Murphy <dmurphy@ti.com>,
linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch] iio: tsl4531: fix error handling in tsl4531_check_id()
Date: Thu, 13 Aug 2015 20:21:53 +0000 [thread overview]
Message-ID: <20150813202027.GA4385@mwanda> (raw)
The caller expect us to return zero if the ID doesn't match. Negative
error codes are treated as success.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/iio/light/tsl4531.c b/drivers/iio/light/tsl4531.c
index 2697918..730fd2b 100644
--- a/drivers/iio/light/tsl4531.c
+++ b/drivers/iio/light/tsl4531.c
@@ -151,7 +151,7 @@ static int tsl4531_check_id(struct i2c_client *client)
{
int ret = i2c_smbus_read_byte_data(client, TSL4531_ID);
if (ret < 0)
- return ret;
+ return 0;
switch (ret >> TSL4531_ID_SHIFT) {
case TSL45311_ID:
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jonathan Cameron <jic23@kernel.org>, Peter Meerwald <pmeerw@pmeerw.net>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Dan Murphy <dmurphy@ti.com>,
linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch] iio: tsl4531: fix error handling in tsl4531_check_id()
Date: Thu, 13 Aug 2015 23:21:53 +0300 [thread overview]
Message-ID: <20150813202027.GA4385@mwanda> (raw)
The caller expect us to return zero if the ID doesn't match. Negative
error codes are treated as success.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/iio/light/tsl4531.c b/drivers/iio/light/tsl4531.c
index 2697918..730fd2b 100644
--- a/drivers/iio/light/tsl4531.c
+++ b/drivers/iio/light/tsl4531.c
@@ -151,7 +151,7 @@ static int tsl4531_check_id(struct i2c_client *client)
{
int ret = i2c_smbus_read_byte_data(client, TSL4531_ID);
if (ret < 0)
- return ret;
+ return 0;
switch (ret >> TSL4531_ID_SHIFT) {
case TSL45311_ID:
next reply other threads:[~2015-08-13 20:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-13 20:21 Dan Carpenter [this message]
2015-08-13 20:21 ` [patch] iio: tsl4531: fix error handling in tsl4531_check_id() Dan Carpenter
2015-08-13 21:03 ` Dan Murphy
2015-08-13 21:03 ` Dan Murphy
2015-08-15 14:36 ` Jonathan Cameron
2015-08-15 14:36 ` Jonathan Cameron
2015-08-15 14:35 ` Jonathan Cameron
2015-08-15 14:35 ` Jonathan Cameron
2015-08-17 14:38 ` [patch v2] " Dan Carpenter
2015-08-17 14:38 ` Dan Carpenter
2015-08-17 14:51 ` Peter Meerwald
2015-08-17 14:51 ` Peter Meerwald
2015-08-17 15:05 ` Dan Murphy
2015-08-17 15:05 ` Dan Murphy
2015-08-18 9:16 ` [patch v3] " Dan Carpenter
2015-08-18 9:16 ` Dan Carpenter
2015-08-31 15:30 ` Jonathan Cameron
2015-08-31 15:30 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150813202027.GA4385@mwanda \
--to=dan.carpenter@oracle.com \
--cc=dmurphy@ti.com \
--cc=jic23@kernel.org \
--cc=k.kozlowski@samsung.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.