From: Dave Chinner <david@fromorbit.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] ext4: ratelimit the file system mounted message
Date: Mon, 17 Aug 2015 11:12:15 +1000 [thread overview]
Message-ID: <20150817011215.GA714@dastard> (raw)
In-Reply-To: <1439665197-10766-1-git-send-email-tytso@mit.edu>
On Sat, Aug 15, 2015 at 02:59:57PM -0400, Theodore Ts'o wrote:
> The xfstests ext4/305 will mount and unmount the same file system over
> 4,000 times, and each one of these will cause a system log message.
> Ratelimit this message since if we are getting more than a few dozen
> of these messages, they probably aren't going to be helpful.
Perhaps you should look at fixing the test or making it a more
targetted reproducer. Tests that do "loop doing something basic
while looping doing something else basic for X minutes to try to
trip a race condition" aren't very good regression tests....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2015-08-17 1:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-15 18:59 [PATCH] ext4: ratelimit the file system mounted message Theodore Ts'o
2015-08-17 1:12 ` Dave Chinner [this message]
2015-08-17 14:50 ` Theodore Ts'o
2015-08-17 23:07 ` Dave Chinner
2015-08-18 1:18 ` Theodore Ts'o
2015-08-18 3:55 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150817011215.GA714@dastard \
--to=david@fromorbit.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.