From: "Theodore Ts'o" <tytso@mit.edu>
To: Dave Chinner <david@fromorbit.com>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>,
Eryu Guan <eguan@redhat.com>,
fstests@vger.kernel.org
Subject: Re: [PATCH] ext4: ratelimit the file system mounted message
Date: Mon, 17 Aug 2015 21:18:07 -0400 [thread overview]
Message-ID: <20150818011807.GC7535@thunk.org> (raw)
In-Reply-To: <20150817230752.GB3902@dastard>
On Tue, Aug 18, 2015 at 09:07:52AM +1000, Dave Chinner wrote:
> Yup. A lot of regression tests get written to tick a process box
> (i.e. did we fix regression X?), not because they provide on-going
> value to prevent future regressions. I try to push back against
> tests that won't provide us with useful protection against future
> regressions....
Yeah, that wasn't the case here. The bug was fixed by Salman Qazi at
Google in May 2012. The test was created by Eryu nearly a year later
in April 2013.
> Rather than time limiting, how about bounding the number of
> mount/unmount cycles?
Sure, that makes sense.
- Ted
next prev parent reply other threads:[~2015-08-18 1:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-15 18:59 [PATCH] ext4: ratelimit the file system mounted message Theodore Ts'o
2015-08-17 1:12 ` Dave Chinner
2015-08-17 14:50 ` Theodore Ts'o
2015-08-17 23:07 ` Dave Chinner
2015-08-18 1:18 ` Theodore Ts'o [this message]
2015-08-18 3:55 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150818011807.GC7535@thunk.org \
--to=tytso@mit.edu \
--cc=david@fromorbit.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.