drm-next amdgpu warning

drm-next amdgpu warning

[Dave Airlie]

Hey Alex,

this seems valid,

/home/airlied/devel/kernel/drm-next/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:
In function ‘amdgpu_uvd_cs_pass2’:
/home/airlied/devel/kernel/drm-next/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:491:17:
warning: ‘min_ctx_size’ may be used uninitialized in this function
[-Wmaybe-uninitialized]
  buf_sizes[0x4] = min_ctx_size;
                 ^
/home/airlied/devel/kernel/drm-next/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:377:58:
note: ‘min_ctx_size’ was declared here
  unsigned image_size, tmp, min_dpb_size, num_dpb_buffer, min_ctx_size;
                                                          ^
Dave.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: drm-next amdgpu warning

[Thierry Reding]

[-- Attachment #1.1: Type: text/plain, Size: 960 bytes --]

On Mon, Aug 17, 2015 at 03:58:10PM +1000, Dave Airlie wrote:
> Hey Alex,
> 
> this seems valid,
> 
> /home/airlied/devel/kernel/drm-next/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:
> In function ‘amdgpu_uvd_cs_pass2’:
> /home/airlied/devel/kernel/drm-next/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:491:17:
> warning: ‘min_ctx_size’ may be used uninitialized in this function
> [-Wmaybe-uninitialized]
>   buf_sizes[0x4] = min_ctx_size;
>                  ^
> /home/airlied/devel/kernel/drm-next/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:377:58:
> note: ‘min_ctx_size’ was declared here
>   unsigned image_size, tmp, min_dpb_size, num_dpb_buffer, min_ctx_size;
>                                                           ^

There's a patch for this here:

	https://patchwork.kernel.org/patch/7014391/

There's apparently also an internal patch that fixes this, but it wasn't
clear yet which one was going to be picked up.

Thierry

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: drm-next amdgpu warning

[Alex Deucher]

On Mon, Aug 17, 2015 at 6:48 AM, Thierry Reding
<thierry.reding@gmail.com> wrote:
> On Mon, Aug 17, 2015 at 03:58:10PM +1000, Dave Airlie wrote:
>> Hey Alex,
>>
>> this seems valid,
>>
>> /home/airlied/devel/kernel/drm-next/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:
>> In function ‘amdgpu_uvd_cs_pass2’:
>> /home/airlied/devel/kernel/drm-next/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:491:17:
>> warning: ‘min_ctx_size’ may be used uninitialized in this function
>> [-Wmaybe-uninitialized]
>>   buf_sizes[0x4] = min_ctx_size;
>>                  ^
>> /home/airlied/devel/kernel/drm-next/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:377:58:
>> note: ‘min_ctx_size’ was declared here
>>   unsigned image_size, tmp, min_dpb_size, num_dpb_buffer, min_ctx_size;
>>                                                           ^
>
> There's a patch for this here:
>
>         https://patchwork.kernel.org/patch/7014391/
>
> There's apparently also an internal patch that fixes this, but it wasn't
> clear yet which one was going to be picked up.
>
> Thierry

Fixed here:
http://cgit.freedesktop.org/~agd5f/linux/commit/?h=drm-next-4.3-wip&id=21df89a5667de5fcd061753d3833e7dfcf5509d3

It's included in the -next pull I'll be sending out today.

Alex
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel