* [PATCH] drm/sti: Do not export symbols
@ 2015-08-14 12:05 Thierry Reding
2015-08-14 12:36 ` Benjamin Gaignard
0 siblings, 1 reply; 3+ messages in thread
From: Thierry Reding @ 2015-08-14 12:05 UTC (permalink / raw)
To: dri-devel; +Cc: Benjamin Gaignard
From: Thierry Reding <treding@nvidia.com>
None of these exported symbols are used outside of the drm-sti driver,
so there is no reason to export them.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
drivers/gpu/drm/sti/sti_drm_crtc.c | 3 ---
drivers/gpu/drm/sti/sti_drm_plane.c | 1 -
drivers/gpu/drm/sti/sti_hqvdp.c | 1 -
drivers/gpu/drm/sti/sti_layer.c | 2 --
drivers/gpu/drm/sti/sti_vtg.c | 6 ------
5 files changed, 13 deletions(-)
diff --git a/drivers/gpu/drm/sti/sti_drm_crtc.c b/drivers/gpu/drm/sti/sti_drm_crtc.c
index 155b91bf16ba..58bc190b2191 100644
--- a/drivers/gpu/drm/sti/sti_drm_crtc.c
+++ b/drivers/gpu/drm/sti/sti_drm_crtc.c
@@ -259,7 +259,6 @@ int sti_drm_crtc_enable_vblank(struct drm_device *dev, unsigned int pipe)
return 0;
}
-EXPORT_SYMBOL(sti_drm_crtc_enable_vblank);
void sti_drm_crtc_disable_vblank(struct drm_device *dev, unsigned int pipe)
{
@@ -279,7 +278,6 @@ void sti_drm_crtc_disable_vblank(struct drm_device *dev, unsigned int pipe)
compo->mixer[pipe]->pending_event = NULL;
}
}
-EXPORT_SYMBOL(sti_drm_crtc_disable_vblank);
static struct drm_crtc_funcs sti_crtc_funcs = {
.set_config = drm_atomic_helper_set_config,
@@ -300,7 +298,6 @@ bool sti_drm_crtc_is_main(struct drm_crtc *crtc)
return false;
}
-EXPORT_SYMBOL(sti_drm_crtc_is_main);
int sti_drm_crtc_init(struct drm_device *drm_dev, struct sti_mixer *mixer,
struct drm_plane *primary, struct drm_plane *cursor)
diff --git a/drivers/gpu/drm/sti/sti_drm_plane.c b/drivers/gpu/drm/sti/sti_drm_plane.c
index 64d4ed43dda3..051deee7e44a 100644
--- a/drivers/gpu/drm/sti/sti_drm_plane.c
+++ b/drivers/gpu/drm/sti/sti_drm_plane.c
@@ -248,4 +248,3 @@ struct drm_plane *sti_drm_plane_init(struct drm_device *dev,
return &layer->plane;
}
-EXPORT_SYMBOL(sti_drm_plane_init);
diff --git a/drivers/gpu/drm/sti/sti_hqvdp.c b/drivers/gpu/drm/sti/sti_hqvdp.c
index b0eb62de1b2e..9dc0aea7911f 100644
--- a/drivers/gpu/drm/sti/sti_hqvdp.c
+++ b/drivers/gpu/drm/sti/sti_hqvdp.c
@@ -816,7 +816,6 @@ struct sti_layer *sti_hqvdp_create(struct device *dev)
return &hqvdp->layer;
}
-EXPORT_SYMBOL(sti_hqvdp_create);
static void sti_hqvdp_init_plugs(struct sti_hqvdp *hqvdp)
{
diff --git a/drivers/gpu/drm/sti/sti_layer.c b/drivers/gpu/drm/sti/sti_layer.c
index 899104f9d4bc..480ec1c974e2 100644
--- a/drivers/gpu/drm/sti/sti_layer.c
+++ b/drivers/gpu/drm/sti/sti_layer.c
@@ -40,7 +40,6 @@ const char *sti_layer_to_str(struct sti_layer *layer)
return "<UNKNOWN LAYER>";
}
}
-EXPORT_SYMBOL(sti_layer_to_str);
struct sti_layer *sti_layer_create(struct device *dev, int desc,
void __iomem *baseaddr)
@@ -78,7 +77,6 @@ struct sti_layer *sti_layer_create(struct device *dev, int desc,
return layer;
}
-EXPORT_SYMBOL(sti_layer_create);
int sti_layer_prepare(struct sti_layer *layer,
struct drm_crtc *crtc,
diff --git a/drivers/gpu/drm/sti/sti_vtg.c b/drivers/gpu/drm/sti/sti_vtg.c
index aa8097137701..ab215d50452a 100644
--- a/drivers/gpu/drm/sti/sti_vtg.c
+++ b/drivers/gpu/drm/sti/sti_vtg.c
@@ -110,7 +110,6 @@ struct sti_vtg *of_vtg_find(struct device_node *np)
}
return NULL;
}
-EXPORT_SYMBOL(of_vtg_find);
static void vtg_reset(struct sti_vtg *vtg)
{
@@ -242,7 +241,6 @@ void sti_vtg_set_config(struct sti_vtg *vtg,
else
vtg_enable_irq(vtg);
}
-EXPORT_SYMBOL(sti_vtg_set_config);
/**
* sti_vtg_get_line_number
@@ -265,7 +263,6 @@ u32 sti_vtg_get_line_number(struct drm_display_mode mode, int y)
return start_line + y;
}
-EXPORT_SYMBOL(sti_vtg_get_line_number);
/**
* sti_vtg_get_pixel_number
@@ -281,7 +278,6 @@ u32 sti_vtg_get_pixel_number(struct drm_display_mode mode, int x)
{
return mode.htotal - mode.hsync_start + x;
}
-EXPORT_SYMBOL(sti_vtg_get_pixel_number);
int sti_vtg_register_client(struct sti_vtg *vtg,
struct notifier_block *nb, int crtc_id)
@@ -292,7 +288,6 @@ int sti_vtg_register_client(struct sti_vtg *vtg,
vtg->crtc_id = crtc_id;
return raw_notifier_chain_register(&vtg->notifier_list, nb);
}
-EXPORT_SYMBOL(sti_vtg_register_client);
int sti_vtg_unregister_client(struct sti_vtg *vtg, struct notifier_block *nb)
{
@@ -301,7 +296,6 @@ int sti_vtg_unregister_client(struct sti_vtg *vtg, struct notifier_block *nb)
return raw_notifier_chain_unregister(&vtg->notifier_list, nb);
}
-EXPORT_SYMBOL(sti_vtg_unregister_client);
static irqreturn_t vtg_irq_thread(int irq, void *arg)
{
--
2.4.5
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/sti: Do not export symbols
2015-08-14 12:05 [PATCH] drm/sti: Do not export symbols Thierry Reding
@ 2015-08-14 12:36 ` Benjamin Gaignard
2015-08-17 11:34 ` Thierry Reding
0 siblings, 1 reply; 3+ messages in thread
From: Benjamin Gaignard @ 2015-08-14 12:36 UTC (permalink / raw)
To: Thierry Reding, Vincent Abriou; +Cc: dri-devel@lists.freedesktop.org
This patch break sti driver compilation when it is compile as module.
The root cause is that sti driver is split in 4 modules (hdmi, dvo,
compositor and driver)...
Maybe that is something we could fix since binding issue has been fix
in previous patch.
Benjamin
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/sti: Do not export symbols
2015-08-14 12:36 ` Benjamin Gaignard
@ 2015-08-17 11:34 ` Thierry Reding
0 siblings, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2015-08-17 11:34 UTC (permalink / raw)
To: Benjamin Gaignard; +Cc: dri-devel@lists.freedesktop.org
[-- Attachment #1.1: Type: text/plain, Size: 646 bytes --]
On Fri, Aug 14, 2015 at 02:36:53PM +0200, Benjamin Gaignard wrote:
> This patch break sti driver compilation when it is compile as module.
> The root cause is that sti driver is split in 4 modules (hdmi, dvo,
> compositor and driver)...
> Maybe that is something we could fix since binding issue has been fix
> in previous patch.
Closing the loop on this: Benjamin and I discussed this on IRC and
agreed that we can drop this for now and revisit after the merge window.
As Benjamin points out the driver is currently split into 4 modules but
that may no longer be necessary. If so, having a single module seems
like the simpler option.
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-08-17 11:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-14 12:05 [PATCH] drm/sti: Do not export symbols Thierry Reding
2015-08-14 12:36 ` Benjamin Gaignard
2015-08-17 11:34 ` Thierry Reding
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.