Re: [PATCH 10/37] watchdog: st_lpc: Fix parent of watchdog_device

[Lee Jones <lee.jones@linaro.org>]

On Tue, 18 Aug 2015, Pratyush Anand wrote:

> Fix parent of watchdog_device so that /sys/class/watchdog/watchdogn/device
> is populated.
> 
> cc: David Paris <david.paris@st.com>
> cc: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: Pratyush Anand <panand@redhat.com>
> ---
>  drivers/watchdog/st_lpc_wdt.c | 1 +
>  1 file changed, 1 insertion(+)

[Cc'ing the ST list, so they can have their say]

Looks reasonable.  At least, it's what most of the other drivers do.

Acked-by: Lee Jones <lee.jones@linaro.org>

> diff --git a/drivers/watchdog/st_lpc_wdt.c b/drivers/watchdog/st_lpc_wdt.c
> index 6785afdc0fca..14e9badf2bfa 100644
> --- a/drivers/watchdog/st_lpc_wdt.c
> +++ b/drivers/watchdog/st_lpc_wdt.c
> @@ -241,6 +241,7 @@ static int st_wdog_probe(struct platform_device *pdev)
>  		return -EINVAL;
>  	}
>  	st_wdog_dev.max_timeout = 0xFFFFFFFF / st_wdog->clkrate;
> +	st_wdog_dev.parent = &pdev->dev;
>  
>  	ret = clk_prepare_enable(clk);
>  	if (ret) {

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog