All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Thumshirn <jthumshirn@suse.de>
To: Pratyush Anand <panand@redhat.com>
Cc: linux-watchdog@vger.kernel.org, dyoung@redhat.com, dzickus@redhat.com
Subject: Re: [PATCH 22/37] watchdog: mena21: Fix parent of watchdog_device
Date: Tue, 18 Aug 2015 08:48:11 +0200	[thread overview]
Message-ID: <mqdbne55bys.fsf@c203.arch.suse.de> (raw)
In-Reply-To: <a49b0e0f3d04f1e4e55b3694aed8e687010b6110.1439524806.git.panand@redhat.com> (Pratyush Anand's message of "Tue, 18 Aug 2015 10:17:55 +0530")

Pratyush Anand <panand@redhat.com> writes:

> Fix parent of watchdog_device so that /sys/class/watchdog/watchdogn/device
> is populated.
>
> cc: Johannes Thumshirn <jthumshirn@suse.de>
> Signed-off-by: Pratyush Anand <panand@redhat.com>
> ---
>  drivers/watchdog/mena21_wdt.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/mena21_wdt.c b/drivers/watchdog/mena21_wdt.c
> index d193a5e79c38..69013007dc47 100644
> --- a/drivers/watchdog/mena21_wdt.c
> +++ b/drivers/watchdog/mena21_wdt.c
> @@ -197,6 +197,7 @@ static int a21_wdt_probe(struct platform_device *pdev)
>  	watchdog_init_timeout(&a21_wdt, 30, &pdev->dev);
>  	watchdog_set_nowayout(&a21_wdt, nowayout);
>  	watchdog_set_drvdata(&a21_wdt, drv);
> +	a21_wdt.parent = &pdev->dev;
>  
>  	reset = a21_wdt_get_bootstatus(drv);
>  	if (reset == 2)

Good catch

Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>

-- 
Johannes Thumshirn                                           Storage
jthumshirn@suse.de                                 +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600  D0D0 0393 969D 2D76 0850

  reply	other threads:[~2015-08-18  6:48 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-18  4:47 [PATCH 00/37] watchdog: Fix parent of watchdog devices Pratyush Anand
2015-08-18  4:47 ` [PATCH 01/37] mei: wd: Fix parent of watchdog_device Pratyush Anand
2015-08-18  4:47 ` [PATCH 02/37] watchdog: wm8350: " Pratyush Anand
2015-08-18  4:47 ` [PATCH 03/37] watchdog: wm831x: " Pratyush Anand
2015-08-18  4:47 ` [PATCH 04/37] watchdog: via: " Pratyush Anand
2015-08-18  4:47 ` [PATCH 05/37] watchdog: ux500: " Pratyush Anand
2015-08-18  4:47 ` [PATCH 06/37] watchdog: txx9wdt: " Pratyush Anand
2015-08-18  4:47 ` [PATCH 07/37] watchdog: twl4030: " Pratyush Anand
     [not found] ` <cover.1439524806.git.panand-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-08-18  4:47   ` [PATCH 08/37] watchdog: tegra: " Pratyush Anand
2015-08-18  4:47     ` Pratyush Anand
2015-08-18  4:47 ` [PATCH 09/37] watchdog: stmp3xxx_rtc: " Pratyush Anand
2015-08-18  4:47 ` [PATCH 10/37] watchdog: st_lpc: " Pratyush Anand
2015-08-18  6:38   ` Lee Jones
2015-08-18  4:47 ` [PATCH 11/37] watchdog: sp805: " Pratyush Anand
2015-08-18  6:41   ` Viresh Kumar
2015-08-18  4:47 ` [PATCH 12/37] watchdog: sirfsoc: " Pratyush Anand
2015-08-18  4:47 ` [PATCH 13/37] watchdog: sh: " Pratyush Anand
2015-08-18  4:47 ` [PATCH 14/37] watchdog: s3c2410: " Pratyush Anand
2015-08-18  4:47 ` [PATCH 15/37] watchdog: rt2880: " Pratyush Anand
2015-08-18  4:47 ` [PATCH 16/37] watchdog: retu: " Pratyush Anand
2015-08-18  4:47 ` [PATCH 17/37] watchdog: qcom: " Pratyush Anand
2015-08-18  4:47 ` [PATCH 18/37] watchdog: pnx4008: " Pratyush Anand
2015-08-18  4:47 ` [PATCH 19/37] watchdog: orion: " Pratyush Anand
2015-08-18  4:47 ` [PATCH 20/37] watchdog: omap: " Pratyush Anand
2015-08-18  4:47 ` [PATCH 21/37] watchdog: menf21bmc: " Pratyush Anand
2015-08-18  4:47 ` [PATCH 22/37] watchdog: mena21: " Pratyush Anand
2015-08-18  6:48   ` Johannes Thumshirn [this message]
2015-08-18  4:47 ` [PATCH 23/37] watchdog: jz4740: " Pratyush Anand
2015-08-18  4:47 ` [PATCH 24/37] watchdog: intel-mid: " Pratyush Anand
2015-08-20 18:24   ` David Cohen
2015-08-18  4:47 ` [PATCH 25/37] watchdog: ie6xx: " Pratyush Anand
2015-08-18  4:47 ` [PATCH 26/37] watchdog: gpio: " Pratyush Anand
2015-08-18  4:48 ` [PATCH 27/37] watchdog: ep93xx: " Pratyush Anand
2015-08-18  4:48 ` [PATCH 28/37] watchdog: digicolor: " Pratyush Anand
2015-08-18  5:41   ` Baruch Siach
2015-08-18  6:03     ` Pratyush Anand
2015-08-18  4:48 ` [PATCH 29/37] watchdog: davinci: " Pratyush Anand
2015-08-18  4:48 ` [PATCH 30/37] watchdog: da9063: " Pratyush Anand
2015-08-18  4:48 ` [PATCH 31/37] watchdog: da9062: " Pratyush Anand
2015-08-18  4:48 ` [PATCH 32/37] watchdog: da9055: " Pratyush Anand
2015-08-18  4:48 ` [PATCH 33/37] watchdog: da9052: " Pratyush Anand
2015-08-18  4:48 ` [PATCH 34/37] watchdog: coh901327: " Pratyush Anand
2015-08-18  4:48 ` [PATCH 35/37] watchdog: bcm_kona: " Pratyush Anand
2015-08-18  4:48 ` [PATCH 36/37] watchdog: bcm47xx: " Pratyush Anand
2015-08-18  4:48 ` [PATCH 37/37] watchdog: bcm2835: " Pratyush Anand
2015-08-18 20:25   ` Lubomir Rintel
2015-08-18 15:48 ` [PATCH 00/37] watchdog: Fix parent of watchdog devices Guenter Roeck
2015-08-18 16:39   ` Pratyush Anand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mqdbne55bys.fsf@c203.arch.suse.de \
    --to=jthumshirn@suse.de \
    --cc=dyoung@redhat.com \
    --cc=dzickus@redhat.com \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=panand@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.