From: Dan Carpenter <dan.carpenter@oracle.com>
To: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: QLogic-Storage-Upstream@qlogic.com,
Vikas Chaudhary <vikas.chaudhary@qlogic.com>,
"James E.J. Bottomley" <JBottomley@odin.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] qla4xxx: remove some bogus casts
Date: Tue, 18 Aug 2015 08:47:26 +0000 [thread overview]
Message-ID: <20150818084726.GG5610@mwanda> (raw)
In-Reply-To: <55D2B879.7040906@sandisk.com>
On Mon, Aug 17, 2015 at 09:45:45PM -0700, Bart Van Assche wrote:
> On 08/17/2015 07:36 AM, Dan Carpenter wrote:
> >These casts are wrong and unnecessary. They annoy static checkers
> >because they imply we are planning to write sizeof(long) bytes to a
> >sizeof(u32) buffer which would corrupt memory.
>
> Hello Dan,
>
> Can you verify whether that patch is still needed after having
> applied the patch series I posted in July (and that was acknowledged
> by QLogic): http://thread.gmane.org/gmane.linux.scsi/103135 ?
>
I think it is needed still?
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: QLogic-Storage-Upstream@qlogic.com,
Vikas Chaudhary <vikas.chaudhary@qlogic.com>,
"James E.J. Bottomley" <JBottomley@odin.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] qla4xxx: remove some bogus casts
Date: Tue, 18 Aug 2015 11:47:26 +0300 [thread overview]
Message-ID: <20150818084726.GG5610@mwanda> (raw)
In-Reply-To: <55D2B879.7040906@sandisk.com>
On Mon, Aug 17, 2015 at 09:45:45PM -0700, Bart Van Assche wrote:
> On 08/17/2015 07:36 AM, Dan Carpenter wrote:
> >These casts are wrong and unnecessary. They annoy static checkers
> >because they imply we are planning to write sizeof(long) bytes to a
> >sizeof(u32) buffer which would corrupt memory.
>
> Hello Dan,
>
> Can you verify whether that patch is still needed after having
> applied the patch series I posted in July (and that was acknowledged
> by QLogic): http://thread.gmane.org/gmane.linux.scsi/103135 ?
>
I think it is needed still?
regards,
dan carpenter
next prev parent reply other threads:[~2015-08-18 8:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-17 14:36 [patch] qla4xxx: remove some bogus casts Dan Carpenter
2015-08-17 14:36 ` Dan Carpenter
2015-08-18 4:45 ` Bart Van Assche
2015-08-18 4:45 ` Bart Van Assche
2015-08-18 8:47 ` Dan Carpenter [this message]
2015-08-18 8:47 ` Dan Carpenter
2015-08-23 1:41 ` Bart Van Assche
2015-08-23 1:41 ` Bart Van Assche
2017-01-25 16:35 ` Bart Van Assche
2017-01-26 2:54 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150818084726.GG5610@mwanda \
--to=dan.carpenter@oracle.com \
--cc=JBottomley@odin.com \
--cc=QLogic-Storage-Upstream@qlogic.com \
--cc=bart.vanassche@sandisk.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=vikas.chaudhary@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.