All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars Ellenberg <lars.ellenberg@linbit.com>
To: Nick Wang <nwang@suse.com>
Cc: linux-kernel@vger.kernel.org,
	Philipp Reisner <philipp.reisner@linbit.com>,
	drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] [PATCH] drbd: Support zeroout device instead of initial full sync
Date: Tue, 18 Aug 2015 17:03:19 +0200	[thread overview]
Message-ID: <20150818150319.GL19958@soda.linbit> (raw)
In-Reply-To: <1438855462-3757-2-git-send-email-nwang@suse.com>

On Thu, Aug 06, 2015 at 06:04:22PM +0800, Nick Wang wrote:
> Patch set for zeroing out device on both side
> instead of initial full sync. Useful for high
> latency network environment.
> 
> Implement --zeroout-devices and --discard-devices
> for new-current-uuid

I still think this does not belong into the kernel at all.
I may not yet have properly explained why.

This is a lot of stuff to add to the DRBD module,
introducing write protocol incompatibility/protocol version bump.

For no good reason.

you want to create a new drbd,
and want to make sure the backing devices are discarded:

# blkdiscard /dev/backing
and then proceed with
# drbdadm create-md ...
as normal, and skip the initial sync as documented.

You want to grow an existing drbd,
you have to grow the backend first, anyways,
you can then (if necessary)
# blkdiscard --offset $o --length $l /dev/backing,
# drbdadm resize ... --assume-clean ...

No need to touch either the DRBD module, or the DRBD utils at all.
All there already.

	Lars Ellenberg


WARNING: multiple messages have this Message-ID (diff)
From: Lars Ellenberg <lars.ellenberg@linbit.com>
To: Nick Wang <nwang@suse.com>
Cc: Philipp Reisner <philipp.reisner@linbit.com>,
	drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drbd: Support zeroout device instead of initial full sync
Date: Tue, 18 Aug 2015 17:03:19 +0200	[thread overview]
Message-ID: <20150818150319.GL19958@soda.linbit> (raw)
In-Reply-To: <1438855462-3757-2-git-send-email-nwang@suse.com>

On Thu, Aug 06, 2015 at 06:04:22PM +0800, Nick Wang wrote:
> Patch set for zeroing out device on both side
> instead of initial full sync. Useful for high
> latency network environment.
> 
> Implement --zeroout-devices and --discard-devices
> for new-current-uuid

I still think this does not belong into the kernel at all.
I may not yet have properly explained why.

This is a lot of stuff to add to the DRBD module,
introducing write protocol incompatibility/protocol version bump.

For no good reason.

you want to create a new drbd,
and want to make sure the backing devices are discarded:

# blkdiscard /dev/backing
and then proceed with
# drbdadm create-md ...
as normal, and skip the initial sync as documented.

You want to grow an existing drbd,
you have to grow the backend first, anyways,
you can then (if necessary)
# blkdiscard --offset $o --length $l /dev/backing,
# drbdadm resize ... --assume-clean ...

No need to touch either the DRBD module, or the DRBD utils at all.
All there already.

	Lars Ellenberg


  reply	other threads:[~2015-08-18 15:03 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-13  8:38 [Drbd-dev] [Patch v2 00/10] Zero out devices instead of initial full sync Nick Wang
2015-07-13  8:38 ` Nick Wang
2015-07-13  8:38 ` [Drbd-dev] [Patch v2 01/10] drbd: Fix the wrong logic of moving history Nick Wang
2015-07-13  8:38   ` Nick Wang
2015-07-13  8:38 ` [Drbd-dev] [Patch v2 02/10] drbd: Add option zap_devices to new-current-uuid Nick Wang
2015-07-13  8:38   ` Nick Wang
2015-07-31 12:50   ` [Drbd-dev] " Philipp Reisner
2015-07-31 12:50     ` Philipp Reisner
2015-07-13  8:38 ` [Drbd-dev] [Patch v2 03/10] drbd: A function to zero out drbd backing device Nick Wang
2015-07-13  8:38   ` Nick Wang
2015-07-13  8:38 ` [Drbd-dev] [Patch v2 04/10] drbd: New packet P_ZERO_OUT Nick Wang
2015-07-13  8:38   ` Nick Wang
2015-07-13  8:38 ` [Drbd-dev] [Patch v2 05/10] drbd: Functions to notify peer node to zero out Nick Wang
2015-07-13  8:38   ` Nick Wang
2015-07-13  8:39 ` [Drbd-dev] [Patch v2 06/10] drbd: Wapper for zeroing out device by worker Nick Wang
2015-07-13  8:39   ` Nick Wang
2015-07-13  8:39 ` [Drbd-dev] [Patch v2 07/10] drbd: Flags for background drbd device work Nick Wang
2015-07-13  8:39   ` Nick Wang
2015-07-13  8:39 ` [Drbd-dev] [Patch v2 08/10] drbd: Function to work with packet P_ZERO_OUT Nick Wang
2015-07-13  8:39   ` Nick Wang
2015-07-13  8:39 ` [Drbd-dev] [Patch v2 09/10] drbd: Handle zero out command from peer node Nick Wang
2015-07-13  8:39   ` Nick Wang
2015-07-13  8:39 ` [Drbd-dev] [Patch v2 10/10] drbd: Handle new-current-uuid --zap-devices Nick Wang
2015-07-13  8:39   ` Nick Wang
2015-07-31 12:48 ` [Drbd-dev] [Patch v2 00/10] Zero out devices instead of initial full sync Philipp Reisner
2015-07-31 12:48   ` Philipp Reisner
2015-08-06 10:04   ` [Drbd-dev] [PATCH v3 0/1] Zeroout/discard " Nick Wang
2015-08-06 10:04     ` Nick Wang
2015-08-06 10:04     ` [Drbd-dev] [PATCH] drbd: Support zeroout device " Nick Wang
2015-08-06 10:04       ` Nick Wang
2015-08-18 15:03       ` Lars Ellenberg [this message]
2015-08-18 15:03         ` Lars Ellenberg
2015-08-21  3:26         ` [Drbd-dev] 答复: " Nick Wang
2015-08-21  3:26           ` Nick Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150818150319.GL19958@soda.linbit \
    --to=lars.ellenberg@linbit.com \
    --cc=drbd-dev@lists.linbit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nwang@suse.com \
    --cc=philipp.reisner@linbit.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.