From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Michal Hocko <mhocko@kernel.org>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Dave Hansen <dave.hansen@intel.com>,
Vlastimil Babka <vbabka@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
David Rientjes <rientjes@google.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCHv2 3/4] mm: pack compound_dtor and compound_order into one word in struct page
Date: Tue, 18 Aug 2015 21:22:59 +0300 [thread overview]
Message-ID: <20150818182259.GB21383@node.dhcp.inet.fi> (raw)
In-Reply-To: <20150818160530.GM5033@dhcp22.suse.cz>
On Tue, Aug 18, 2015 at 06:05:31PM +0200, Michal Hocko wrote:
> On Mon 17-08-15 18:09:04, Kirill A. Shutemov wrote:
> [...]
> > +/* Keep the enum in sync with compound_page_dtors array in mm/page_alloc.c */
> > +enum {
> > + NULL_COMPOUND_DTOR,
> > + COMPOUND_PAGE_DTOR,
> > + HUGETLB_PAGE_DTOR,
> > + NR_COMPOUND_DTORS,
> > +};
> [...]
> > +static void free_compound_page(struct page *page);
> > +compound_page_dtor * const compound_page_dtors[] = {
> > + NULL,
> > + free_compound_page,
> > + free_huge_page,
> > +};
> > +
>
> Both need ifdef CONFIG_HUGETLB_PAGE as my compile test batter just found
> out.
I'll fix that.
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Michal Hocko <mhocko@kernel.org>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Dave Hansen <dave.hansen@intel.com>,
Vlastimil Babka <vbabka@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
David Rientjes <rientjes@google.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCHv2 3/4] mm: pack compound_dtor and compound_order into one word in struct page
Date: Tue, 18 Aug 2015 21:22:59 +0300 [thread overview]
Message-ID: <20150818182259.GB21383@node.dhcp.inet.fi> (raw)
In-Reply-To: <20150818160530.GM5033@dhcp22.suse.cz>
On Tue, Aug 18, 2015 at 06:05:31PM +0200, Michal Hocko wrote:
> On Mon 17-08-15 18:09:04, Kirill A. Shutemov wrote:
> [...]
> > +/* Keep the enum in sync with compound_page_dtors array in mm/page_alloc.c */
> > +enum {
> > + NULL_COMPOUND_DTOR,
> > + COMPOUND_PAGE_DTOR,
> > + HUGETLB_PAGE_DTOR,
> > + NR_COMPOUND_DTORS,
> > +};
> [...]
> > +static void free_compound_page(struct page *page);
> > +compound_page_dtor * const compound_page_dtors[] = {
> > + NULL,
> > + free_compound_page,
> > + free_huge_page,
> > +};
> > +
>
> Both need ifdef CONFIG_HUGETLB_PAGE as my compile test batter just found
> out.
I'll fix that.
--
Kirill A. Shutemov
next prev parent reply other threads:[~2015-08-18 18:23 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-17 15:09 [PATCHv2 0/4] Fix compound_head() race Kirill A. Shutemov
2015-08-17 15:09 ` Kirill A. Shutemov
2015-08-17 15:09 ` [PATCHv2 1/4] mm: drop page->slab_page Kirill A. Shutemov
2015-08-17 15:09 ` Kirill A. Shutemov
2015-08-18 0:43 ` David Rientjes
2015-08-18 0:43 ` David Rientjes
2015-08-17 15:09 ` [PATCHv2 2/4] zsmalloc: use page->private instead of page->first_page Kirill A. Shutemov
2015-08-17 15:09 ` Kirill A. Shutemov
2015-08-25 1:49 ` Sergey Senozhatsky
2015-08-25 1:49 ` Sergey Senozhatsky
2015-08-25 2:17 ` Sergey Senozhatsky
2015-08-25 2:17 ` Sergey Senozhatsky
2015-08-25 17:10 ` Kirill A. Shutemov
2015-08-25 17:10 ` Kirill A. Shutemov
2015-08-17 15:09 ` [PATCHv2 3/4] mm: pack compound_dtor and compound_order into one word in struct page Kirill A. Shutemov
2015-08-17 15:09 ` Kirill A. Shutemov
2015-08-17 22:59 ` Hugh Dickins
2015-08-17 22:59 ` Hugh Dickins
2015-08-18 15:43 ` Michal Hocko
2015-08-18 15:43 ` Michal Hocko
2015-08-18 18:22 ` Kirill A. Shutemov
2015-08-18 18:22 ` Kirill A. Shutemov
2015-08-18 16:05 ` Michal Hocko
2015-08-18 16:05 ` Michal Hocko
2015-08-18 18:22 ` Kirill A. Shutemov [this message]
2015-08-18 18:22 ` Kirill A. Shutemov
2015-08-17 15:09 ` [PATCHv2 4/4] mm: make compound_head() robust Kirill A. Shutemov
2015-08-17 15:09 ` Kirill A. Shutemov
2015-08-18 11:20 ` Michal Hocko
2015-08-18 11:20 ` Michal Hocko
2015-08-18 16:41 ` Michal Hocko
2015-08-18 16:41 ` Michal Hocko
2015-08-18 18:24 ` Kirill A. Shutemov
2015-08-18 18:24 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150818182259.GB21383@node.dhcp.inet.fi \
--to=kirill@shutemov.name \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.