From: olof@lixom.net (Olof Johansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: multi_v7_defconfig: Enable CROS_EC_PROTO for ChromeOS EC mfd driver
Date: Tue, 18 Aug 2015 14:46:08 -0700 [thread overview]
Message-ID: <20150818214608.GA21855@localhost> (raw)
In-Reply-To: <1439881827-22613-1-git-send-email-javier@osg.samsung.com>
On Tue, Aug 18, 2015 at 09:10:27AM +0200, Javier Martinez Canillas wrote:
> The ChromeOS mfd driver (MFD_CROS_EC) select the CROS_EC_PROTO config
> symbol because the driver uses some communication helper functions in
> drivers/platform/chrome/cros_ec_proto.c but other drivers depends on
> CROS_EC_PROTO instead. Mixing select and depends can lead to circular
> Kconfig dependencies so the MFD_CROS_EC select should be changed to a
> depends on CROS_EC_PROTO instead.
>
> But doing so will break git bisect-ability since MFD_CROS_EC will not
> be enabled anymore unless the default configs first explicitly enable
> the CROS_EC_PROTO dependency.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Applied to cros/ec-config in arm-soc, which will stay stable in case others
need to bring in as a prereq.
-Olof
WARNING: multiple messages have this Message-ID (diff)
From: Olof Johansson <olof@lixom.net>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: arm@kernel.org, Arnd Bergmann <arnd@arndb.de>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Doug Anderson <dianders@chromium.org>,
Gwendal Grignou <gwendal@chromium.org>,
Sjoerd Simons <sjoerd.simons@collabora.co.uk>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: multi_v7_defconfig: Enable CROS_EC_PROTO for ChromeOS EC mfd driver
Date: Tue, 18 Aug 2015 14:46:08 -0700 [thread overview]
Message-ID: <20150818214608.GA21855@localhost> (raw)
In-Reply-To: <1439881827-22613-1-git-send-email-javier@osg.samsung.com>
On Tue, Aug 18, 2015 at 09:10:27AM +0200, Javier Martinez Canillas wrote:
> The ChromeOS mfd driver (MFD_CROS_EC) select the CROS_EC_PROTO config
> symbol because the driver uses some communication helper functions in
> drivers/platform/chrome/cros_ec_proto.c but other drivers depends on
> CROS_EC_PROTO instead. Mixing select and depends can lead to circular
> Kconfig dependencies so the MFD_CROS_EC select should be changed to a
> depends on CROS_EC_PROTO instead.
>
> But doing so will break git bisect-ability since MFD_CROS_EC will not
> be enabled anymore unless the default configs first explicitly enable
> the CROS_EC_PROTO dependency.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Applied to cros/ec-config in arm-soc, which will stay stable in case others
need to bring in as a prereq.
-Olof
next prev parent reply other threads:[~2015-08-18 21:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 7:10 [PATCH] ARM: multi_v7_defconfig: Enable CROS_EC_PROTO for ChromeOS EC mfd driver Javier Martinez Canillas
2015-08-18 7:10 ` Javier Martinez Canillas
2015-08-18 21:46 ` Olof Johansson [this message]
2015-08-18 21:46 ` Olof Johansson
2015-08-18 22:28 ` Javier Martinez Canillas
2015-08-18 22:28 ` Javier Martinez Canillas
2015-08-19 16:18 ` Olof Johansson
2015-08-19 16:18 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150818214608.GA21855@localhost \
--to=olof@lixom.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.