From: David Gibson <david@gibson.dropbear.id.au>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>,
"qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>,
Gavin Shan <gwshan@linux.vnet.ibm.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v5 2/4] linux-headers: Add eeh.h
Date: Tue, 18 Aug 2015 15:53:25 -0700 [thread overview]
Message-ID: <20150818225325.GF3157@voom> (raw)
In-Reply-To: <CAFEAcA_8Y0gMfdk4Evga6dUibfYB46W4FQifYYBCa-75BD+4zQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1185 bytes --]
On Tue, Aug 18, 2015 at 01:26:39PM +0100, Peter Maydell wrote:
> On 18 August 2015 at 02:47, Gavin Shan <gwshan@linux.vnet.ibm.com> wrote:
> > The header file was introduced by following Linux upstream commits:
> >
> > commit ed3e81f ("powerpc/eeh: Move PE state constants around")
> > commit ec33d36 ("powerpc/eeh: Introduce eeh_pe_inject_err()")
> >
> > Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
> > ---
> > I didn't include all changes from scripts/update-linux-headers.sh
> > as too many unrelated changes introduced by the script.
>
> Please just have a commit which does a "sync linux headers
> from kernel version $WHATEVER". The whole point of the script
> is to keep our headers completely synchronized with the kernel.
>
> (The only exception to this is RFC patchsets where the kernel
> header changes haven't yet hit mainline.)
Seconded. Please include the SHA ID of the upstream kernel you
updated from in your commit message, too.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-08-18 23:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 1:47 [Qemu-devel] [PATCH v5 0/4] sPAPR: Support EEH Error Injection Gavin Shan
2015-08-18 1:47 ` [Qemu-devel] [PATCH v5 1/4] scripts: Include arch/powerpc/include/uapi/asm/eeh.h Gavin Shan
2015-08-18 1:47 ` [Qemu-devel] [PATCH v5 2/4] linux-headers: Add eeh.h Gavin Shan
2015-08-18 12:26 ` Peter Maydell
2015-08-18 22:53 ` David Gibson [this message]
2015-08-18 23:42 ` Gavin Shan
2015-08-18 23:46 ` Peter Maydell
2015-08-19 0:03 ` David Gibson
2015-08-18 1:47 ` [Qemu-devel] [PATCH v5 3/4] sPAPR: Support RTAS call ibm, {open, close}-errinjct Gavin Shan
2015-08-18 17:32 ` Thomas Huth
2015-08-18 23:52 ` Gavin Shan
2015-08-19 1:15 ` David Gibson
2015-08-19 16:15 ` Thomas Huth
2015-08-20 0:16 ` Gavin Shan
2015-10-02 8:26 ` Alexey Kardashevskiy
2015-08-18 1:47 ` [Qemu-devel] [PATCH v5 4/4] sPAPR: Support RTAS call ibm,errinjct Gavin Shan
2015-08-18 18:04 ` [Qemu-devel] [PATCH v5 4/4] sPAPR: Support RTAS call ibm, errinjct Thomas Huth
2015-08-19 0:26 ` Gavin Shan
2015-08-19 1:20 ` David Gibson
2015-08-19 15:48 ` Thomas Huth
2015-08-20 0:17 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150818225325.GF3157@voom \
--to=david@gibson.dropbear.id.au \
--cc=aik@ozlabs.ru \
--cc=gwshan@linux.vnet.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.