Re: [Qemu-devel] [PATCH v5 2/4] linux-headers: Add eeh.h

[Gavin Shan <gwshan@linux.vnet.ibm.com>]

On Tue, Aug 18, 2015 at 03:53:25PM -0700, David Gibson wrote:
>On Tue, Aug 18, 2015 at 01:26:39PM +0100, Peter Maydell wrote:
>> On 18 August 2015 at 02:47, Gavin Shan <gwshan@linux.vnet.ibm.com> wrote:
>> > The header file was introduced by following Linux upstream commits:
>> >
>> >     commit ed3e81f ("powerpc/eeh: Move PE state constants around")
>> >     commit ec33d36 ("powerpc/eeh: Introduce eeh_pe_inject_err()")
>> >
>> > Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
>> > ---
>> > I didn't include all changes from scripts/update-linux-headers.sh
>> > as too many unrelated changes introduced by the script.
>> 
>> Please just have a commit which does a "sync linux headers
>> from kernel version $WHATEVER". The whole point of the script
>> is to keep our headers completely synchronized with the kernel.
>> 
>> (The only exception to this is RFC patchsets where the kernel
>> header changes haven't yet hit mainline.)
>
>Seconded.  Please include the SHA ID of the upstream kernel you
>updated from in your commit message, too.
>

Ok. I'll do. Thanks!

>-- 
>David Gibson			| I'll have my music baroque, and my code
>david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
>				| _way_ _around_!
>http://www.ozlabs.org/~dgibson