From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2] arm64: dts: Add base stratix 10 dtsi
Date: Thu, 20 Aug 2015 18:23:08 +0100 [thread overview]
Message-ID: <20150820172308.GA2711@svinekod> (raw)
In-Reply-To: <1439308127-7412-1-git-send-email-dinguyen@opensource.altera.com>
Hi,
> +/ {
> + compatible = "altr,socfpga-stratix10";
> + #address-cells = <1>;
> + #size-cells = <1>;
I would recommend that you make your root #address-cells and #size-cells equal
to 2, as that will simplify matters later if/when you need to add anything
beyond the first 4GB for some particular board.
If everything in the SoC falls within the first 4GB you can have a ranges
property on your /soc node and have only one cell below that.
[...]
> + intc: intc at ffff8000 {
The unit-address doesn't match the first address in the reg entry.
> + compatible = "arm,gic-400", "arm,cortex-a15-gic";
> + #interrupt-cells = <3>;
> + interrupt-controller;
> + reg = <0x0 0xffff9000 0x1000>,
> + <0x0 0xffffa000 0x2000>,
> + <0x0 0xffffc000 0x1000>,
> + <0x0 0xffffd000 0x1000>;
> + };
Shouldn't the virtual CPU interface also be 0x2000 long?
Mark.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: "dinguyen@opensource.altera.com" <dinguyen@opensource.altera.com>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
"galak@codeaurora.org" <galak@codeaurora.org>,
Pawel Moll <Pawel.Moll@arm.com>,
Catalin Marinas <Catalin.Marinas@arm.com>,
Will Deacon <Will.Deacon@arm.com>,
"dinh.linux@gmail.com" <dinh.linux@gmail.com>,
"jszhang@marvell.com" <jszhang@marvell.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv2] arm64: dts: Add base stratix 10 dtsi
Date: Thu, 20 Aug 2015 18:23:08 +0100 [thread overview]
Message-ID: <20150820172308.GA2711@svinekod> (raw)
In-Reply-To: <1439308127-7412-1-git-send-email-dinguyen@opensource.altera.com>
Hi,
> +/ {
> + compatible = "altr,socfpga-stratix10";
> + #address-cells = <1>;
> + #size-cells = <1>;
I would recommend that you make your root #address-cells and #size-cells equal
to 2, as that will simplify matters later if/when you need to add anything
beyond the first 4GB for some particular board.
If everything in the SoC falls within the first 4GB you can have a ranges
property on your /soc node and have only one cell below that.
[...]
> + intc: intc@ffff8000 {
The unit-address doesn't match the first address in the reg entry.
> + compatible = "arm,gic-400", "arm,cortex-a15-gic";
> + #interrupt-cells = <3>;
> + interrupt-controller;
> + reg = <0x0 0xffff9000 0x1000>,
> + <0x0 0xffffa000 0x2000>,
> + <0x0 0xffffc000 0x1000>,
> + <0x0 0xffffd000 0x1000>;
> + };
Shouldn't the virtual CPU interface also be 0x2000 long?
Mark.
next prev parent reply other threads:[~2015-08-20 17:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-11 15:48 [PATCHv2] arm64: dts: Add base stratix 10 dtsi dinguyen at opensource.altera.com
2015-08-11 15:48 ` dinguyen
2015-08-11 15:48 ` dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx
2015-08-18 16:04 ` Dinh Nguyen
2015-08-18 16:04 ` Dinh Nguyen
2015-08-18 16:04 ` Dinh Nguyen
2015-08-20 17:23 ` Mark Rutland [this message]
2015-08-20 17:23 ` Mark Rutland
2015-08-20 18:37 ` Dinh Nguyen
2015-08-20 18:37 ` Dinh Nguyen
2015-08-20 18:37 ` Dinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150820172308.GA2711@svinekod \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.