All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Norris <computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Javier Martinez Canillas
	<javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Javier Martinez Canillas
	<javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>,
	linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 18/18] spi: (RFC, don't apply) report OF style modalias when probing using DT
Date: Thu, 20 Aug 2015 14:08:22 -0700	[thread overview]
Message-ID: <20150820210822.GH74600@google.com> (raw)
In-Reply-To: <20150820183634.GN12027-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>

On Thu, Aug 20, 2015 at 11:36:34AM -0700, Mark Brown wrote:
> On Thu, Aug 20, 2015 at 09:07:31AM +0200, Javier Martinez Canillas wrote:
> > From: Javier Martinez Canillas <javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
> > 
> > An SPI driver that supports both OF and legacy platforms, will have
> > both an OF and SPI ID table. This means that when built as a module,
> > the aliases will be filled from both tables, e.g:
> 
> This is tagged as something that can't be applied but you've not
> explained why it can't be applied or what comments might be useful :(

I believe that's mostly addressed in the cover letter [1].

  Patch #18 changes the logic of spi_uevent() to report an OF modalias
  if the device was registered using OF. But this patch is included in
  the series only as an RFC for illustration purposes since changing
  that without first applying all the other patches in this series, will
  break module autoloading for the drivers of devices registered using
  OF but that lacks an of_match_table. I'll repost patch #18 once all
  the patches in this series have landed.

IOW, it's labeled as such mostly for safety, since it has quite a few
distributed dependencies.

Brian

[1] https://lkml.org/lkml/2015/8/20/109
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Brian Norris <computersforpeace@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Javier Martinez Canillas <javier@osg.samsung.com>,
	linux-kernel@vger.kernel.org,
	Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
	linux-spi@vger.kernel.org
Subject: Re: [PATCH 18/18] spi: (RFC, don't apply) report OF style modalias when probing using DT
Date: Thu, 20 Aug 2015 14:08:22 -0700	[thread overview]
Message-ID: <20150820210822.GH74600@google.com> (raw)
In-Reply-To: <20150820183634.GN12027@sirena.org.uk>

On Thu, Aug 20, 2015 at 11:36:34AM -0700, Mark Brown wrote:
> On Thu, Aug 20, 2015 at 09:07:31AM +0200, Javier Martinez Canillas wrote:
> > From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> > 
> > An SPI driver that supports both OF and legacy platforms, will have
> > both an OF and SPI ID table. This means that when built as a module,
> > the aliases will be filled from both tables, e.g:
> 
> This is tagged as something that can't be applied but you've not
> explained why it can't be applied or what comments might be useful :(

I believe that's mostly addressed in the cover letter [1].

  Patch #18 changes the logic of spi_uevent() to report an OF modalias
  if the device was registered using OF. But this patch is included in
  the series only as an RFC for illustration purposes since changing
  that without first applying all the other patches in this series, will
  break module autoloading for the drivers of devices registered using
  OF but that lacks an of_match_table. I'll repost patch #18 once all
  the patches in this series have landed.

IOW, it's labeled as such mostly for safety, since it has quite a few
distributed dependencies.

Brian

[1] https://lkml.org/lkml/2015/8/20/109

  parent reply	other threads:[~2015-08-20 21:08 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-20  7:07 [PATCH 00/18] Export SPI and OF module aliases in missing drivers Javier Martinez Canillas
2015-08-20  7:07 ` Javier Martinez Canillas
2015-08-20  7:07 ` Javier Martinez Canillas
2015-08-20  7:07 ` [PATCH 01/18] iio: Export SPI module alias information " Javier Martinez Canillas
2015-08-20 15:49   ` Lars-Peter Clausen
2015-08-22 18:08     ` Jonathan Cameron
2015-08-20  7:07 ` [PATCH 02/18] staging: iio: hmc5843: Export missing SPI module alias information Javier Martinez Canillas
2015-08-22 17:59   ` Jonathan Cameron
2015-08-31 23:09     ` Javier Martinez Canillas
2015-09-05 16:31       ` Jonathan Cameron
2015-09-05 23:34         ` Javier Martinez Canillas
2015-08-20  7:07 ` [PATCH 03/18] mtd: dataflash: Export OF " Javier Martinez Canillas
2015-08-20 21:54   ` Brian Norris
2015-08-20 22:13     ` Javier Martinez Canillas
2015-08-20 22:34       ` Brian Norris
2015-08-20 22:57         ` Javier Martinez Canillas
2015-08-21 22:47           ` Brian Norris
2015-08-22  0:26             ` Javier Martinez Canillas
2015-08-22  1:05               ` Brian Norris
2015-08-22  1:10                 ` Javier Martinez Canillas
2015-08-20  7:07 ` [PATCH 04/18] OMAPDSS: panel-sony-acx565akm: " Javier Martinez Canillas
2015-08-20  7:07   ` Javier Martinez Canillas
2015-08-20  7:07 ` [PATCH 05/18] mmc: mmc_spi: " Javier Martinez Canillas
2015-08-20  7:07 ` [PATCH 06/18] staging: mt29f_spinand: " Javier Martinez Canillas
2015-08-20  7:07 ` [PATCH 07/18] net: ks8851: " Javier Martinez Canillas
2015-08-20  7:07 ` [PATCH 08/18] [media] s5c73m3: " Javier Martinez Canillas
2015-09-11  1:19   ` Javier Martinez Canillas
2015-09-11  9:37     ` Andrzej Hajda
2015-09-11 10:10     ` Andrzej Hajda
2015-09-11 10:33       ` Javier Martinez Canillas
2015-08-20  7:07 ` [PATCH 09/18] mfd: cros_ec: spi: Add OF match table Javier Martinez Canillas
2015-08-24 14:00   ` Lee Jones
2015-08-20  7:07 ` [PATCH 10/18] iio: dac: ad7303: " Javier Martinez Canillas
2015-08-20 15:49   ` Lars-Peter Clausen
2015-08-22 18:06     ` Jonathan Cameron
2015-08-20  7:07 ` [PATCH 11/18] iio: adc: max1027: Set struct spi_driver .of_match_table Javier Martinez Canillas
2015-08-22 18:00   ` Jonathan Cameron
2015-08-20  7:07 ` [PATCH 12/18] mfd: stmpe: Add OF match table Javier Martinez Canillas
2015-08-24 13:59   ` Lee Jones
2015-08-20  7:07 ` [PATCH 13/18] iio: adc: mcp320x: Set struct spi_driver .of_match_table Javier Martinez Canillas
2015-08-20 20:09   ` Michael Welling
2015-08-20 22:02     ` Javier Martinez Canillas
2015-08-20 22:29       ` Michael Welling
2015-08-20 22:48         ` Javier Martinez Canillas
2015-08-20 23:53           ` Michael Welling
2015-08-22 18:09             ` Jonathan Cameron
2015-08-22 17:48           ` Jonathan Cameron
2015-08-22 17:48             ` Jonathan Cameron
2015-08-23 22:10             ` Rob Herring
2015-08-23 22:10               ` Rob Herring
2015-08-24  7:19               ` Javier Martinez Canillas
2015-08-24  7:19                 ` Javier Martinez Canillas
2015-08-20  7:07 ` [PATCH 14/18] iio: as3935: Add OF match table Javier Martinez Canillas
2015-08-22 18:02   ` Jonathan Cameron
2015-08-20  7:07 ` [PATCH 15/18] iio: adc128s052: " Javier Martinez Canillas
2015-08-22 18:03   ` Jonathan Cameron
2015-08-20  7:07 ` [PATCH 16/18] iio: frequency: adf4350: " Javier Martinez Canillas
2015-08-20 15:49   ` Lars-Peter Clausen
2015-08-22 18:04     ` Jonathan Cameron
2015-08-20  7:07 ` [PATCH 17/18] NFC: trf7970a: " Javier Martinez Canillas
2015-08-20  7:07 ` [PATCH 18/18] spi: (RFC, don't apply) report OF style modalias when probing using DT Javier Martinez Canillas
     [not found]   ` <1440054451-1223-19-git-send-email-javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2015-08-20 18:36     ` Mark Brown
2015-08-20 18:36       ` Mark Brown
     [not found]       ` <20150820183634.GN12027-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-08-20 21:08         ` Brian Norris [this message]
2015-08-20 21:08           ` Brian Norris
     [not found]           ` <20150820210822.GH74600-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2015-08-20 21:45             ` Javier Martinez Canillas
2015-08-20 21:45               ` Javier Martinez Canillas
     [not found]               ` <55D64A65.7030905-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2015-08-20 23:25                 ` Mark Brown
2015-08-20 23:25                   ` Mark Brown
2015-08-20 23:47                   ` Javier Martinez Canillas
     [not found]                     ` <55D666F4.2080801-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2015-08-21 17:29                       ` Mark Brown
2015-08-21 17:29                         ` Mark Brown
     [not found]                         ` <20150821172931.GK12027-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-08-24  8:00                           ` Javier Martinez Canillas
2015-08-24  8:00                             ` Javier Martinez Canillas
2015-08-20 21:11 ` [PATCH 00/18] Export SPI and OF module aliases in missing drivers Brian Norris
2015-08-20 21:11   ` Brian Norris
2015-08-20 21:11   ` Brian Norris
2015-08-20 21:50   ` Javier Martinez Canillas
2015-08-20 21:50     ` Javier Martinez Canillas
2015-08-20 21:50     ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150820210822.GH74600@google.com \
    --to=computersforpeace-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org \
    --cc=javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.