* [Buildroot] [PATCH] package/libcgroup: allow to build cgroup-tools
@ 2015-08-24 9:13 Bartosz Golaszewski
2015-08-24 9:41 ` Yann E. MORIN
2015-08-24 11:29 ` Vicente Olivert Riera
0 siblings, 2 replies; 4+ messages in thread
From: Bartosz Golaszewski @ 2015-08-24 9:13 UTC (permalink / raw)
To: buildroot
Add a new config option that allows to build cgroup-tools - a set of
command-line utils for managing cgroups.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
package/libcgroup/Config.in | 6 ++++++
package/libcgroup/libcgroup.mk | 7 ++++++-
2 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/package/libcgroup/Config.in b/package/libcgroup/Config.in
index b7a84e0..2d7a808 100644
--- a/package/libcgroup/Config.in
+++ b/package/libcgroup/Config.in
@@ -9,5 +9,11 @@ config BR2_PACKAGE_LIBCGROUP
http://libcg.sourceforge.net/
+config BR2_PACKAGE_CGROUP_TOOLS
+ bool "build cgroup-tools"
+ depends on BR2_PACKAGE_LIBCGROUP
+ help
+ Include a set of command-line tools for managing cgroups.
+
comment "libcgroup needs an (e)glibc toolchain w/ C++"
depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_USES_GLIBC
diff --git a/package/libcgroup/libcgroup.mk b/package/libcgroup/libcgroup.mk
index ace2744..f3dbf18 100644
--- a/package/libcgroup/libcgroup.mk
+++ b/package/libcgroup/libcgroup.mk
@@ -20,10 +20,15 @@ LIBCGROUP_CONF_ENV = \
CFLAGS="$(TARGET_CFLAGS) -U_FILE_OFFSET_BITS"
LIBCGROUP_CONF_OPTS = \
- --disable-tools \
--disable-daemon \
--disable-initscript-install
+ifeq ($(BR2_PACKAGE_CGROUP_TOOLS),y)
+LIBCGROUP_CONF_OPTS += --enable-tools
+else
+LIBCGROUP_CONF_OPTS += --disable-tools
+endif
+
ifeq ($(BR2_PACKAGE_LINUX_PAM),y)
LIBCGROUP_DEPENDENCIES += linux-pam
LIBCGROUP_CONF_OPTS += --enable-pam
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] package/libcgroup: allow to build cgroup-tools
2015-08-24 9:13 [Buildroot] [PATCH] package/libcgroup: allow to build cgroup-tools Bartosz Golaszewski
@ 2015-08-24 9:41 ` Yann E. MORIN
2015-08-24 11:29 ` Vicente Olivert Riera
1 sibling, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2015-08-24 9:41 UTC (permalink / raw)
To: buildroot
Bartosz, All,
On 2015-08-24 11:13 +0200, Bartosz Golaszewski spake thusly:
> Add a new config option that allows to build cgroup-tools - a set of
> command-line utils for managing cgroups.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
> package/libcgroup/Config.in | 6 ++++++
> package/libcgroup/libcgroup.mk | 7 ++++++-
> 2 files changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/package/libcgroup/Config.in b/package/libcgroup/Config.in
> index b7a84e0..2d7a808 100644
> --- a/package/libcgroup/Config.in
> +++ b/package/libcgroup/Config.in
> @@ -9,5 +9,11 @@ config BR2_PACKAGE_LIBCGROUP
>
> http://libcg.sourceforge.net/
>
> +config BR2_PACKAGE_CGROUP_TOOLS
Options should be prefixed with the package name:
config BR2_PACKAGE_LIBCGROUP_TOOLS
> + bool "build cgroup-tools"
> + depends on BR2_PACKAGE_LIBCGROUP
That's technically correct, but I think we'd prefer an enclosing
if-endif construct, like so:
if BR2_PACKAGE_LIBCGROUP
config BR2_PACKAGE_LIBCGROUP_TOOLS
bool "cgroup tools"
help
Include a set of command-line tools for managing cgroups.
endif
> + help
> + Include a set of command-line tools for managing cgroups.
> +
> comment "libcgroup needs an (e)glibc toolchain w/ C++"
> depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_USES_GLIBC
> diff --git a/package/libcgroup/libcgroup.mk b/package/libcgroup/libcgroup.mk
> index ace2744..f3dbf18 100644
> --- a/package/libcgroup/libcgroup.mk
> +++ b/package/libcgroup/libcgroup.mk
> @@ -20,10 +20,15 @@ LIBCGROUP_CONF_ENV = \
> CFLAGS="$(TARGET_CFLAGS) -U_FILE_OFFSET_BITS"
>
> LIBCGROUP_CONF_OPTS = \
> - --disable-tools \
> --disable-daemon \
> --disable-initscript-install
>
> +ifeq ($(BR2_PACKAGE_CGROUP_TOOLS),y)
Of course, fix the variable name above, too.
Regards,
Yann E. MORIN.
> +LIBCGROUP_CONF_OPTS += --enable-tools
> +else
> +LIBCGROUP_CONF_OPTS += --disable-tools
> +endif
> +
> ifeq ($(BR2_PACKAGE_LINUX_PAM),y)
> LIBCGROUP_DEPENDENCIES += linux-pam
> LIBCGROUP_CONF_OPTS += --enable-pam
> --
> 2.1.4
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] package/libcgroup: allow to build cgroup-tools
2015-08-24 9:13 [Buildroot] [PATCH] package/libcgroup: allow to build cgroup-tools Bartosz Golaszewski
2015-08-24 9:41 ` Yann E. MORIN
@ 2015-08-24 11:29 ` Vicente Olivert Riera
2015-08-24 11:33 ` Bartosz Golaszewski
1 sibling, 1 reply; 4+ messages in thread
From: Vicente Olivert Riera @ 2015-08-24 11:29 UTC (permalink / raw)
To: buildroot
Dear Bartosz Golaszewski,
On 08/24/2015 10:13 AM, Bartosz Golaszewski wrote:
> Add a new config option that allows to build cgroup-tools - a set of
> command-line utils for managing cgroups.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
> package/libcgroup/Config.in | 6 ++++++
> package/libcgroup/libcgroup.mk | 7 ++++++-
> 2 files changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/package/libcgroup/Config.in b/package/libcgroup/Config.in
> index b7a84e0..2d7a808 100644
> --- a/package/libcgroup/Config.in
> +++ b/package/libcgroup/Config.in
> @@ -9,5 +9,11 @@ config BR2_PACKAGE_LIBCGROUP
>
> http://libcg.sourceforge.net/
>
> +config BR2_PACKAGE_CGROUP_TOOLS
> + bool "build cgroup-tools"
> + depends on BR2_PACKAGE_LIBCGROUP
> + help
> + Include a set of command-line tools for managing cgroups.
> +
> comment "libcgroup needs an (e)glibc toolchain w/ C++"
> depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_USES_GLIBC
> diff --git a/package/libcgroup/libcgroup.mk b/package/libcgroup/libcgroup.mk
> index ace2744..f3dbf18 100644
> --- a/package/libcgroup/libcgroup.mk
> +++ b/package/libcgroup/libcgroup.mk
> @@ -20,10 +20,15 @@ LIBCGROUP_CONF_ENV = \
> CFLAGS="$(TARGET_CFLAGS) -U_FILE_OFFSET_BITS"
>
> LIBCGROUP_CONF_OPTS = \
> - --disable-tools \
> --disable-daemon \
> --disable-initscript-install
>
> +ifeq ($(BR2_PACKAGE_CGROUP_TOOLS),y)
> +LIBCGROUP_CONF_OPTS += --enable-tools
> +else
> +LIBCGROUP_CONF_OPTS += --disable-tools
> +endif
> +
> ifeq ($(BR2_PACKAGE_LINUX_PAM),y)
> LIBCGROUP_DEPENDENCIES += linux-pam
> LIBCGROUP_CONF_OPTS += --enable-pam
>
could you please mark this patch as superseded?
Regards,
Vincent.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] package/libcgroup: allow to build cgroup-tools
2015-08-24 11:29 ` Vicente Olivert Riera
@ 2015-08-24 11:33 ` Bartosz Golaszewski
0 siblings, 0 replies; 4+ messages in thread
From: Bartosz Golaszewski @ 2015-08-24 11:33 UTC (permalink / raw)
To: buildroot
2015-08-24 13:29 GMT+02:00 Vicente Olivert Riera <Vincent.Riera@imgtec.com>:
> Dear Bartosz Golaszewski,
>
> On 08/24/2015 10:13 AM, Bartosz Golaszewski wrote:
>> Add a new config option that allows to build cgroup-tools - a set of
>> command-line utils for managing cgroups.
>>
>> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>> ---
>> package/libcgroup/Config.in | 6 ++++++
>> package/libcgroup/libcgroup.mk | 7 ++++++-
>> 2 files changed, 12 insertions(+), 1 deletion(-)
>>
>> diff --git a/package/libcgroup/Config.in b/package/libcgroup/Config.in
>> index b7a84e0..2d7a808 100644
>> --- a/package/libcgroup/Config.in
>> +++ b/package/libcgroup/Config.in
>> @@ -9,5 +9,11 @@ config BR2_PACKAGE_LIBCGROUP
>>
>> http://libcg.sourceforge.net/
>>
>> +config BR2_PACKAGE_CGROUP_TOOLS
>> + bool "build cgroup-tools"
>> + depends on BR2_PACKAGE_LIBCGROUP
>> + help
>> + Include a set of command-line tools for managing cgroups.
>> +
>> comment "libcgroup needs an (e)glibc toolchain w/ C++"
>> depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_USES_GLIBC
>> diff --git a/package/libcgroup/libcgroup.mk b/package/libcgroup/libcgroup.mk
>> index ace2744..f3dbf18 100644
>> --- a/package/libcgroup/libcgroup.mk
>> +++ b/package/libcgroup/libcgroup.mk
>> @@ -20,10 +20,15 @@ LIBCGROUP_CONF_ENV = \
>> CFLAGS="$(TARGET_CFLAGS) -U_FILE_OFFSET_BITS"
>>
>> LIBCGROUP_CONF_OPTS = \
>> - --disable-tools \
>> --disable-daemon \
>> --disable-initscript-install
>>
>> +ifeq ($(BR2_PACKAGE_CGROUP_TOOLS),y)
>> +LIBCGROUP_CONF_OPTS += --enable-tools
>> +else
>> +LIBCGROUP_CONF_OPTS += --disable-tools
>> +endif
>> +
>> ifeq ($(BR2_PACKAGE_LINUX_PAM),y)
>> LIBCGROUP_DEPENDENCIES += linux-pam
>> LIBCGROUP_CONF_OPTS += --enable-pam
>>
>
> could you please mark this patch as superseded?
> Regards,
>
> Vincent.
Superseded by:
http://patchwork.ozlabs.org/patch/509986/
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-08-24 11:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-24 9:13 [Buildroot] [PATCH] package/libcgroup: allow to build cgroup-tools Bartosz Golaszewski
2015-08-24 9:41 ` Yann E. MORIN
2015-08-24 11:29 ` Vicente Olivert Riera
2015-08-24 11:33 ` Bartosz Golaszewski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.