All of lore.kernel.org
 help / color / mirror / Atom feed
From: "joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org" <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: "Xiao, Nan (Nan@HPS Performance,
	Beijing)" <nan.xiao-VXdhtT5mjnY@public.gmane.org>
Cc: "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org"
	<iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
	"dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org"
	<dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Subject: Re: [PATCH] Documentation/Intel-IOMMU.txt: Modify definition of DRHD
Date: Tue, 25 Aug 2015 10:51:48 +0200	[thread overview]
Message-ID: <20150825085148.GC32055@8bytes.org> (raw)
In-Reply-To: <F9D82F0D71C0024FA18FE771EDDAF149081FAC82-qhK1pdpzgV8SZAcGdq5asR6epYMZPwEe5NbjCUgZEJk@public.gmane.org>

Hi Nan,

I applied this patch with some formatting fixes, thanks. Details below:

From: "Xiao, Nan (Nan@HPS Performance, Beijing)" <nan.xiao-VXdhtT5mjnY@public.gmane.org>

git-am made this author-line out of your patch: "(Nan@HPS <(Nan@HPS>"

Which doesn't even look like a valid email address. I fixed it, but
please include a From: line in your future patches like this:

From: Xiao, Nan <nan.xiao-VXdhtT5mjnY@public.gmane.org>

This will guarantee that your patches will be accounted correctly.

Next is the patch subject. For iommu patches please use a prefix like
this: <arch>/<iommu>

In case of Intel VT-d this would look like "iommu/vt-d:", and my updated
subject line looks like:

Subject: x86/vt-d: Fix documentation of DRHD

On Mon, Aug 24, 2015 at 06:22:42AM +0000, Xiao, Nan (Nan@HPS Performance, Beijing) wrote:
> According to "Intel Virtualization Technology for Directed I/O" specification,
> DRHD stands for "DMA Remapping Hardware Unit Definition" , not "DMA Engine Reporting Structure".

These lines are too long. Please try to limit the line-length in patches
to 60 characters for iommu patches.


Thanks,

	Joerg

  parent reply	other threads:[~2015-08-25  8:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-24  6:22 [PATCH] Documentation/Intel-IOMMU.txt: Modify definition of DRHD Xiao, Nan (Nan@HPS Performance, Beijing)
     [not found] ` <F9D82F0D71C0024FA18FE771EDDAF149081FAC82-qhK1pdpzgV8SZAcGdq5asR6epYMZPwEe5NbjCUgZEJk@public.gmane.org>
2015-08-25  8:51   ` joro-zLv9SwRftAIdnm+yROfE0A [this message]
     [not found]     ` <20150825085148.GC32055-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2015-08-25  9:04       ` Xiao, Nan (Nan@HPservers-Core-OE-PSC)
  -- strict thread matches above, loose matches on Subject: below --
2015-08-20 10:17 Nan Xiao
2015-08-24 17:41 ` Jonathan Corbet
2015-08-24 23:04   ` Nan Xiao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150825085148.GC32055@8bytes.org \
    --to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
    --cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=nan.xiao-VXdhtT5mjnY@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.