From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
Keir Fraser <keir@xen.org>, Wei Liu <wei.liu2@citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] x86/MSI: don't flag non-maskable entries a host-masked
Date: Wed, 26 Aug 2015 09:57:08 -0400 [thread overview]
Message-ID: <20150826135707.GC21769@l.oracle.com> (raw)
In-Reply-To: <55DDE040020000780009D294@prv-mh.provo.novell.com>
On Wed, Aug 26, 2015 at 07:50:24AM -0600, Jan Beulich wrote:
> 'M' debug key output looks confusing without this adjustment.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> --- a/xen/arch/x86/msi.c
> +++ b/xen/arch/x86/msi.c
> @@ -716,8 +716,8 @@ static int msi_capability_init(struct pc
> entry[i].msi_attrib.type = PCI_CAP_ID_MSI;
> entry[i].msi_attrib.is_64 = is_64bit_address(control);
> entry[i].msi_attrib.entry_nr = i;
> + entry[i].msi_attrib.host_masked =
> entry[i].msi_attrib.maskbit = is_mask_bit_support(control);
> - entry[i].msi_attrib.host_masked = 1;
> entry[i].msi_attrib.guest_masked = 0;
> entry[i].msi_attrib.pos = pos;
> if ( entry[i].msi_attrib.maskbit )
>
>
>
> x86/MSI: don't flag non-maskable entries a host-masked
s/a/as/ ?
>
> 'M' debug key output looks confusing without this adjustment.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> --- a/xen/arch/x86/msi.c
> +++ b/xen/arch/x86/msi.c
> @@ -716,8 +716,8 @@ static int msi_capability_init(struct pc
> entry[i].msi_attrib.type = PCI_CAP_ID_MSI;
> entry[i].msi_attrib.is_64 = is_64bit_address(control);
> entry[i].msi_attrib.entry_nr = i;
> + entry[i].msi_attrib.host_masked =
> entry[i].msi_attrib.maskbit = is_mask_bit_support(control);
> - entry[i].msi_attrib.host_masked = 1;
> entry[i].msi_attrib.guest_masked = 0;
> entry[i].msi_attrib.pos = pos;
> if ( entry[i].msi_attrib.maskbit )
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2015-08-26 13:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-26 13:50 [PATCH] x86/MSI: don't flag non-maskable entries a host-masked Jan Beulich
2015-08-26 13:57 ` Konrad Rzeszutek Wilk [this message]
2015-08-26 14:00 ` Jan Beulich
2015-08-26 14:02 ` Andrew Cooper
2015-08-26 14:18 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150826135707.GC21769@l.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=keir@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.