* [PATCH] x86/MSI: don't flag non-maskable entries a host-masked
@ 2015-08-26 13:50 Jan Beulich
2015-08-26 13:57 ` Konrad Rzeszutek Wilk
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Jan Beulich @ 2015-08-26 13:50 UTC (permalink / raw)
To: xen-devel; +Cc: Andrew Cooper, Keir Fraser, Wei Liu
[-- Attachment #1: Type: text/plain, Size: 692 bytes --]
'M' debug key output looks confusing without this adjustment.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/msi.c
+++ b/xen/arch/x86/msi.c
@@ -716,8 +716,8 @@ static int msi_capability_init(struct pc
entry[i].msi_attrib.type = PCI_CAP_ID_MSI;
entry[i].msi_attrib.is_64 = is_64bit_address(control);
entry[i].msi_attrib.entry_nr = i;
+ entry[i].msi_attrib.host_masked =
entry[i].msi_attrib.maskbit = is_mask_bit_support(control);
- entry[i].msi_attrib.host_masked = 1;
entry[i].msi_attrib.guest_masked = 0;
entry[i].msi_attrib.pos = pos;
if ( entry[i].msi_attrib.maskbit )
[-- Attachment #2: x86-MSI-non-maskable-host.patch --]
[-- Type: text/plain, Size: 744 bytes --]
x86/MSI: don't flag non-maskable entries a host-masked
'M' debug key output looks confusing without this adjustment.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/msi.c
+++ b/xen/arch/x86/msi.c
@@ -716,8 +716,8 @@ static int msi_capability_init(struct pc
entry[i].msi_attrib.type = PCI_CAP_ID_MSI;
entry[i].msi_attrib.is_64 = is_64bit_address(control);
entry[i].msi_attrib.entry_nr = i;
+ entry[i].msi_attrib.host_masked =
entry[i].msi_attrib.maskbit = is_mask_bit_support(control);
- entry[i].msi_attrib.host_masked = 1;
entry[i].msi_attrib.guest_masked = 0;
entry[i].msi_attrib.pos = pos;
if ( entry[i].msi_attrib.maskbit )
[-- Attachment #3: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] x86/MSI: don't flag non-maskable entries a host-masked
2015-08-26 13:50 [PATCH] x86/MSI: don't flag non-maskable entries a host-masked Jan Beulich
@ 2015-08-26 13:57 ` Konrad Rzeszutek Wilk
2015-08-26 14:00 ` Jan Beulich
2015-08-26 14:02 ` Andrew Cooper
2015-08-26 14:18 ` Wei Liu
2 siblings, 1 reply; 5+ messages in thread
From: Konrad Rzeszutek Wilk @ 2015-08-26 13:57 UTC (permalink / raw)
To: Jan Beulich; +Cc: xen-devel, Keir Fraser, Wei Liu, Andrew Cooper
On Wed, Aug 26, 2015 at 07:50:24AM -0600, Jan Beulich wrote:
> 'M' debug key output looks confusing without this adjustment.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> --- a/xen/arch/x86/msi.c
> +++ b/xen/arch/x86/msi.c
> @@ -716,8 +716,8 @@ static int msi_capability_init(struct pc
> entry[i].msi_attrib.type = PCI_CAP_ID_MSI;
> entry[i].msi_attrib.is_64 = is_64bit_address(control);
> entry[i].msi_attrib.entry_nr = i;
> + entry[i].msi_attrib.host_masked =
> entry[i].msi_attrib.maskbit = is_mask_bit_support(control);
> - entry[i].msi_attrib.host_masked = 1;
> entry[i].msi_attrib.guest_masked = 0;
> entry[i].msi_attrib.pos = pos;
> if ( entry[i].msi_attrib.maskbit )
>
>
>
> x86/MSI: don't flag non-maskable entries a host-masked
s/a/as/ ?
>
> 'M' debug key output looks confusing without this adjustment.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> --- a/xen/arch/x86/msi.c
> +++ b/xen/arch/x86/msi.c
> @@ -716,8 +716,8 @@ static int msi_capability_init(struct pc
> entry[i].msi_attrib.type = PCI_CAP_ID_MSI;
> entry[i].msi_attrib.is_64 = is_64bit_address(control);
> entry[i].msi_attrib.entry_nr = i;
> + entry[i].msi_attrib.host_masked =
> entry[i].msi_attrib.maskbit = is_mask_bit_support(control);
> - entry[i].msi_attrib.host_masked = 1;
> entry[i].msi_attrib.guest_masked = 0;
> entry[i].msi_attrib.pos = pos;
> if ( entry[i].msi_attrib.maskbit )
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] x86/MSI: don't flag non-maskable entries a host-masked
2015-08-26 13:57 ` Konrad Rzeszutek Wilk
@ 2015-08-26 14:00 ` Jan Beulich
0 siblings, 0 replies; 5+ messages in thread
From: Jan Beulich @ 2015-08-26 14:00 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk; +Cc: Andrew Cooper, Keir Fraser, Wei Liu, xen-devel
>>> On 26.08.15 at 15:57, <konrad.wilk@oracle.com> wrote:
> On Wed, Aug 26, 2015 at 07:50:24AM -0600, Jan Beulich wrote:
>> 'M' debug key output looks confusing without this adjustment.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>
>> --- a/xen/arch/x86/msi.c
>> +++ b/xen/arch/x86/msi.c
>> @@ -716,8 +716,8 @@ static int msi_capability_init(struct pc
>> entry[i].msi_attrib.type = PCI_CAP_ID_MSI;
>> entry[i].msi_attrib.is_64 = is_64bit_address(control);
>> entry[i].msi_attrib.entry_nr = i;
>> + entry[i].msi_attrib.host_masked =
>> entry[i].msi_attrib.maskbit = is_mask_bit_support(control);
>> - entry[i].msi_attrib.host_masked = 1;
>> entry[i].msi_attrib.guest_masked = 0;
>> entry[i].msi_attrib.pos = pos;
>> if ( entry[i].msi_attrib.maskbit )
>>
>>
>>
>
>> x86/MSI: don't flag non-maskable entries a host-masked
>
> s/a/as/ ?
Of course - sorry.
Jan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] x86/MSI: don't flag non-maskable entries a host-masked
2015-08-26 13:50 [PATCH] x86/MSI: don't flag non-maskable entries a host-masked Jan Beulich
2015-08-26 13:57 ` Konrad Rzeszutek Wilk
@ 2015-08-26 14:02 ` Andrew Cooper
2015-08-26 14:18 ` Wei Liu
2 siblings, 0 replies; 5+ messages in thread
From: Andrew Cooper @ 2015-08-26 14:02 UTC (permalink / raw)
To: Jan Beulich, xen-devel; +Cc: Keir Fraser, Wei Liu
On 26/08/15 14:50, Jan Beulich wrote:
> 'M' debug key output looks confusing without this adjustment.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>, with Konrads
suggestion fixed.
>
> --- a/xen/arch/x86/msi.c
> +++ b/xen/arch/x86/msi.c
> @@ -716,8 +716,8 @@ static int msi_capability_init(struct pc
> entry[i].msi_attrib.type = PCI_CAP_ID_MSI;
> entry[i].msi_attrib.is_64 = is_64bit_address(control);
> entry[i].msi_attrib.entry_nr = i;
> + entry[i].msi_attrib.host_masked =
> entry[i].msi_attrib.maskbit = is_mask_bit_support(control);
> - entry[i].msi_attrib.host_masked = 1;
> entry[i].msi_attrib.guest_masked = 0;
> entry[i].msi_attrib.pos = pos;
> if ( entry[i].msi_attrib.maskbit )
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] x86/MSI: don't flag non-maskable entries a host-masked
2015-08-26 13:50 [PATCH] x86/MSI: don't flag non-maskable entries a host-masked Jan Beulich
2015-08-26 13:57 ` Konrad Rzeszutek Wilk
2015-08-26 14:02 ` Andrew Cooper
@ 2015-08-26 14:18 ` Wei Liu
2 siblings, 0 replies; 5+ messages in thread
From: Wei Liu @ 2015-08-26 14:18 UTC (permalink / raw)
To: Jan Beulich; +Cc: xen-devel, Keir Fraser, Wei Liu, Andrew Cooper
On Wed, Aug 26, 2015 at 07:50:24AM -0600, Jan Beulich wrote:
> 'M' debug key output looks confusing without this adjustment.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
Release-acked-by: Wei Liu <wei.liu2@citrix.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-08-26 14:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-26 13:50 [PATCH] x86/MSI: don't flag non-maskable entries a host-masked Jan Beulich
2015-08-26 13:57 ` Konrad Rzeszutek Wilk
2015-08-26 14:00 ` Jan Beulich
2015-08-26 14:02 ` Andrew Cooper
2015-08-26 14:18 ` Wei Liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.