All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yaowei Bai <bywxiaobai@163.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: akpm@linux-foundation.org, mgorman@suse.de, vbabka@suse.cz,
	js1304@gmail.com, hannes@cmpxchg.org,
	alexander.h.duyck@redhat.com, sasha.levin@oracle.com,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Documentation: clarify in calculating zone protection
Date: Wed, 26 Aug 2015 22:29:06 +0800	[thread overview]
Message-ID: <20150826142906.GA4194@bbox> (raw)
In-Reply-To: <20150825150633.GG6285@dhcp22.suse.cz>

On Tue, Aug 25, 2015 at 05:06:33PM +0200, Michal Hocko wrote:
> On Tue 25-08-15 22:01:31, Yaowei Bai wrote:
> > Every zone's protection is calculated from managed_pages not
> > present_pages, to avoid misleading, correct it.
> 
> This can be folded in to your previous patch
> http://marc.info/?l=linux-mm&m=144023106610358&w=2

OK, thanks.

> 
> > 
> > Signed-off-by: Yaowei Bai <bywxiaobai@163.com>
> > ---
> >  Documentation/sysctl/vm.txt | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/Documentation/sysctl/vm.txt b/Documentation/sysctl/vm.txt
> > index 9832ec5..1739b31 100644
> > --- a/Documentation/sysctl/vm.txt
> > +++ b/Documentation/sysctl/vm.txt
> > @@ -349,7 +349,7 @@ zone[i]'s protection[j] is calculated by following expression.
> >  
> >  (i < j):
> >    zone[i]->protection[j]
> > -  = (total sums of present_pages from zone[i+1] to zone[j] on the node)
> > +  = (total sums of managed_pages from zone[i+1] to zone[j] on the node)
> >      / lowmem_reserve_ratio[i];
> >  (i = j):
> >     (should not be protected. = 0;
> > @@ -360,7 +360,7 @@ The default values of lowmem_reserve_ratio[i] are
> >      256 (if zone[i] means DMA or DMA32 zone)
> >      32  (others).
> >  As above expression, they are reciprocal number of ratio.
> > -256 means 1/256. # of protection pages becomes about "0.39%" of total present
> > +256 means 1/256. # of protection pages becomes about "0.39%" of total managed
> >  pages of higher zones on the node.
> >  
> >  If you would like to protect more pages, smaller values are effective.
> > -- 
> > 1.9.1
> > 
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at  http://www.tux.org/lkml/
> 
> -- 
> Michal Hocko
> SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Yaowei Bai <bywxiaobai@163.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: akpm@linux-foundation.org, mgorman@suse.de, vbabka@suse.cz,
	js1304@gmail.com, hannes@cmpxchg.org,
	alexander.h.duyck@redhat.com, sasha.levin@oracle.com,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Documentation: clarify in calculating zone protection
Date: Wed, 26 Aug 2015 22:29:06 +0800	[thread overview]
Message-ID: <20150826142906.GA4194@bbox> (raw)
In-Reply-To: <20150825150633.GG6285@dhcp22.suse.cz>

On Tue, Aug 25, 2015 at 05:06:33PM +0200, Michal Hocko wrote:
> On Tue 25-08-15 22:01:31, Yaowei Bai wrote:
> > Every zone's protection is calculated from managed_pages not
> > present_pages, to avoid misleading, correct it.
> 
> This can be folded in to your previous patch
> http://marc.info/?l=linux-mm&m=144023106610358&w=2

OK, thanks.

> 
> > 
> > Signed-off-by: Yaowei Bai <bywxiaobai@163.com>
> > ---
> >  Documentation/sysctl/vm.txt | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/Documentation/sysctl/vm.txt b/Documentation/sysctl/vm.txt
> > index 9832ec5..1739b31 100644
> > --- a/Documentation/sysctl/vm.txt
> > +++ b/Documentation/sysctl/vm.txt
> > @@ -349,7 +349,7 @@ zone[i]'s protection[j] is calculated by following expression.
> >  
> >  (i < j):
> >    zone[i]->protection[j]
> > -  = (total sums of present_pages from zone[i+1] to zone[j] on the node)
> > +  = (total sums of managed_pages from zone[i+1] to zone[j] on the node)
> >      / lowmem_reserve_ratio[i];
> >  (i = j):
> >     (should not be protected. = 0;
> > @@ -360,7 +360,7 @@ The default values of lowmem_reserve_ratio[i] are
> >      256 (if zone[i] means DMA or DMA32 zone)
> >      32  (others).
> >  As above expression, they are reciprocal number of ratio.
> > -256 means 1/256. # of protection pages becomes about "0.39%" of total present
> > +256 means 1/256. # of protection pages becomes about "0.39%" of total managed
> >  pages of higher zones on the node.
> >  
> >  If you would like to protect more pages, smaller values are effective.
> > -- 
> > 1.9.1
> > 
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at  http://www.tux.org/lkml/
> 
> -- 
> Michal Hocko
> SUSE Labs


  reply	other threads:[~2015-08-26 14:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-25 14:01 [PATCH 1/2] mm/page_alloc: change sysctl_lower_zone_reserve_ratio to sysctl_lowmem_reserve_ratio Yaowei Bai
2015-08-25 14:01 ` Yaowei Bai
2015-08-25 14:01 ` [PATCH 2/2] Documentation: clarify in calculating zone protection Yaowei Bai
2015-08-25 14:01   ` Yaowei Bai
2015-08-25 15:06   ` Michal Hocko
2015-08-25 15:06     ` Michal Hocko
2015-08-26 14:29     ` Yaowei Bai [this message]
2015-08-26 14:29       ` Yaowei Bai
2015-08-25 23:33   ` David Rientjes
2015-08-25 23:33     ` David Rientjes
2015-08-25 15:28 ` [PATCH 1/2] mm/page_alloc: change sysctl_lower_zone_reserve_ratio to sysctl_lowmem_reserve_ratio Michal Hocko
2015-08-25 15:28   ` Michal Hocko
2015-08-25 23:33 ` David Rientjes
2015-08-25 23:33   ` David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150826142906.GA4194@bbox \
    --to=bywxiaobai@163.com \
    --cc=akpm@linux-foundation.org \
    --cc=alexander.h.duyck@redhat.com \
    --cc=hannes@cmpxchg.org \
    --cc=js1304@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=mhocko@kernel.org \
    --cc=sasha.levin@oracle.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.