All of lore.kernel.org
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: perf: Add event descriptions
Date: Wed, 26 Aug 2015 17:51:49 +0100	[thread overview]
Message-ID: <20150826165148.GF30466@arm.com> (raw)
In-Reply-To: <20150817205809.GA16506@dreric01-gentoo.localdomain>

On Mon, Aug 17, 2015 at 09:58:09PM +0100, Drew Richardson wrote:
> On Tue, Aug 04, 2015 at 01:15:23AM +0100, Drew Richardson wrote:
> > Add additional information about hardware events to make counters self
> > describing. This makes the hardware PMUs easier to use as perf list
> > contains the possible events instead of users having to refer to
> > documentation like the ARM TRMs. This could also allow tools like
> > oprofile to support PMUs without requiring an update.
> > 
> > Signed-off-by: Drew Richardson <drew.richardson@arm.com>
> > ---
> >  arch/arm/kernel/perf_event.c    |   1 +
> >  arch/arm/kernel/perf_event_v7.c | 617 ++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 618 insertions(+)
> 
> Any concerns with merging this?

We should revisit this after the merge window (since the ARM perf code is
moving out to drivers/), but I do have reservations about putting all these
strings into the kernel. Why can't we put this into something like libpfm
instead?

Will

WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Drew Richardson <drew.richardson@arm.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Russell King <linux@arm.linux.org.uk>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	Wade Cherry <Wade.Cherry@arm.com>
Subject: Re: [PATCH] arm: perf: Add event descriptions
Date: Wed, 26 Aug 2015 17:51:49 +0100	[thread overview]
Message-ID: <20150826165148.GF30466@arm.com> (raw)
In-Reply-To: <20150817205809.GA16506@dreric01-gentoo.localdomain>

On Mon, Aug 17, 2015 at 09:58:09PM +0100, Drew Richardson wrote:
> On Tue, Aug 04, 2015 at 01:15:23AM +0100, Drew Richardson wrote:
> > Add additional information about hardware events to make counters self
> > describing. This makes the hardware PMUs easier to use as perf list
> > contains the possible events instead of users having to refer to
> > documentation like the ARM TRMs. This could also allow tools like
> > oprofile to support PMUs without requiring an update.
> > 
> > Signed-off-by: Drew Richardson <drew.richardson@arm.com>
> > ---
> >  arch/arm/kernel/perf_event.c    |   1 +
> >  arch/arm/kernel/perf_event_v7.c | 617 ++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 618 insertions(+)
> 
> Any concerns with merging this?

We should revisit this after the merge window (since the ARM perf code is
moving out to drivers/), but I do have reservations about putting all these
strings into the kernel. Why can't we put this into something like libpfm
instead?

Will

  reply	other threads:[~2015-08-26 16:51 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-04  0:15 [PATCH] arm: perf: Add event descriptions Drew Richardson
2015-08-04  0:15 ` Drew Richardson
2015-08-17 20:58 ` Drew Richardson
2015-08-17 20:58   ` Drew Richardson
2015-08-26 16:51   ` Will Deacon [this message]
2015-08-26 16:51     ` Will Deacon
2015-08-17 21:40     ` Drew Richardson
2015-08-17 21:40       ` Drew Richardson
2015-09-24 17:31       ` Drew Richardson
2015-09-24 17:31         ` Drew Richardson
2015-09-24 17:52       ` Will Deacon
2015-09-24 17:52         ` Will Deacon
2015-10-07 11:20         ` Will Deacon
2015-10-07 11:20           ` Will Deacon
2015-10-27 15:46           ` Christopher Covington
2015-10-27 15:46             ` Christopher Covington
2015-10-27 16:04             ` Mark Rutland
2015-10-27 16:04               ` Mark Rutland
2015-10-28 14:14               ` Christopher Covington
2015-10-28 14:14                 ` Christopher Covington
2015-10-28 14:29                 ` Mark Rutland
2015-10-28 14:29                   ` Mark Rutland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150826165148.GF30466@arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.