All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, sameo@linux.intel.com,
	patches@opensource.wolfsonmicro.com, lgirdwood@gmail.com,
	linux-kernel@vger.kernel.org, lee.jones@linaro.org
Subject: Re: [PATCH 2/2] ASoC: wm5110: Add DAPM/routing hookup for the ANC block
Date: Thu, 27 Aug 2015 17:04:45 +0100	[thread overview]
Message-ID: <20150827160445.GC19411@ck-lbox> (raw)
In-Reply-To: <20150827161132.GE5313@sirena.org.uk>

On Thu, Aug 27, 2015 at 05:11:32PM +0100, Mark Brown wrote:
> On Thu, Aug 27, 2015 at 04:31:06PM +0100, Charles Keepax wrote:
> 
> > +	switch (event) {
> > +	case SND_SOC_DAPM_POST_PMU:
> > +		val = 1 << w->shift;
> > +		break;
> > +	case SND_SOC_DAPM_PRE_PMD:
> > +		val = 1 << (w->shift + 1);
> > +	default:
> 
> It looks like there's a missing break here.

Ooops... sorry let me fix that up.

Thanks,
Charles

WARNING: multiple messages have this Message-ID (diff)
From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Mark Brown <broonie@kernel.org>
Cc: <alsa-devel@alsa-project.org>, <sameo@linux.intel.com>,
	<patches@opensource.wolfsonmicro.com>,
	<linux-kernel@vger.kernel.org>, <lgirdwood@gmail.com>,
	<lee.jones@linaro.org>
Subject: Re: [alsa-devel] [PATCH 2/2] ASoC: wm5110: Add DAPM/routing hookup for the ANC block
Date: Thu, 27 Aug 2015 17:04:45 +0100	[thread overview]
Message-ID: <20150827160445.GC19411@ck-lbox> (raw)
In-Reply-To: <20150827161132.GE5313@sirena.org.uk>

On Thu, Aug 27, 2015 at 05:11:32PM +0100, Mark Brown wrote:
> On Thu, Aug 27, 2015 at 04:31:06PM +0100, Charles Keepax wrote:
> 
> > +	switch (event) {
> > +	case SND_SOC_DAPM_POST_PMU:
> > +		val = 1 << w->shift;
> > +		break;
> > +	case SND_SOC_DAPM_PRE_PMD:
> > +		val = 1 << (w->shift + 1);
> > +	default:
> 
> It looks like there's a missing break here.

Ooops... sorry let me fix that up.

Thanks,
Charles

  reply	other threads:[~2015-08-27 16:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-27 15:31 [PATCH 1/2] mfd: arizona: Add register bits to support the ANC block Charles Keepax
2015-08-27 15:31 ` Charles Keepax
2015-08-27 15:31 ` [PATCH 2/2] ASoC: wm5110: Add DAPM/routing hookup for " Charles Keepax
2015-08-27 15:31   ` Charles Keepax
2015-08-27 16:11   ` Mark Brown
2015-08-27 16:04     ` Charles Keepax [this message]
2015-08-27 16:04       ` [alsa-devel] " Charles Keepax

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150827160445.GC19411@ck-lbox \
    --to=ckeepax@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@opensource.wolfsonmicro.com \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.