From: Brian Norris <computersforpeace@gmail.com>
To: linux-mtd@lists.infradead.org,
David Woodhouse <David.Woodhouse@intel.com>
Subject: Re: [PATCH mtd-utils] autogenerated dependency files are not being utilized properly
Date: Thu, 27 Aug 2015 17:20:48 -0700 [thread overview]
Message-ID: <20150828002048.GZ81844@google.com> (raw)
In-Reply-To: <20150827235613.GE29734@vapier>
On Thu, Aug 27, 2015 at 07:56:13PM -0400, Mike Frysinger wrote:
> On 27 Aug 2015 15:48, Brian Norris wrote:
> > - $(Q)$(CC) $(CPPFLAGS) $(CFLAGS) -c -o $@ $< -g -Wp,-MD,$(BUILDDIR)/.$(<F).dep
> > + $(Q)$(CC) $(CPPFLAGS) $(CFLAGS) -c -o $@ $< -g -MD -MF $(BUILDDIR)/.$(<F).dep
>
> fwiw, this has been here since the beginning.
Yeah, at first I thought it was added in your build system refactoring a
few years back, but then I traced it back to the beginning of time^Wgit
history. Anyway, I figured you'd have insight.
> dropping the -Wp makes
> sense to me. independently, i think it should use -MMD, but others might
> prefer the -MD behavior.
-MMD makes sense to me too, but yes it is independent. I can send
another patch.
> Acked-by: Mike Frysinger <vapier@gentoo.org>
Thanks for the review!
Brian
next prev parent reply other threads:[~2015-08-28 0:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-27 22:48 [PATCH mtd-utils] autogenerated dependency files are not being utilized properly Brian Norris
2015-08-27 23:56 ` Mike Frysinger
2015-08-28 0:20 ` Brian Norris [this message]
2015-08-28 16:04 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150828002048.GZ81844@google.com \
--to=computersforpeace@gmail.com \
--cc=David.Woodhouse@intel.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.