Re: [PATCH nf-next 2/2] netfilter: nfnetlink_log: allow to attach conntrack

[Ken-ichirou MATSUZAWA <chamaken@gmail.com>]

On Wed, Aug 26, 2015 at 09:05:53PM +0200, Pablo Neira Ayuso wrote:
> On Tue, Aug 25, 2015 at 08:15:20AM +0900, Ken-ichirou MATSUZAWA wrote:
> > This patch enables to include the conntrack information together
> > with the packet that is sent to user-space via NFLOG, then a
> > user-space program can acquire NATed information by this NFULA_CT
> > attribute.
> > 
> No objections to this series, just several comments below on them.

Thank you for your taking time. But I realize these can not be
statically built into kernel, sorry.

> >  config NETFILTER_NETLINK_QUEUE_CT
> > -        bool "NFQUEUE integration with Connection Tracking"
> > +        bool "NFQUEUE/NFLOG integration with Connection Tracking"
> >          default n
> > -        depends on NETFILTER_NETLINK_QUEUE
> > +        depends on NETFILTER_NETLINK_QUEUE || NETFILTER_NETLINK_LOG
> >  	help
> > -	  If this option is enabled, NFQUEUE can include Connection Tracking
> > -	  information together with the packet is the enqueued via NFNETLINK.
> > +	  If this option is enabled, NFQUEUE and/or NFLOG can include
> > +	  Connection Tracking information together with the packet is
> > +	  enqueued, logged via NFNETLINK.
> 
> You better add another Kconfig for _LOG.

I'll follow your instruction, thanks.
I have to reconsider to enable it statically linked and will be glad
if you review again at the next time.

Thanks,