Re: [PATCH nf-next 2/2] netfilter: nfnetlink_log: allow to attach conntrack

[Ken-ichirou MATSUZAWA <chamaken@gmail.com>]

The compile fails if both nflog and nfqueue are built-in at the
previous patch.

I am trying to link nf_netlink_queue_ct to nf_conntrack_netlink, not
to nf_netlink_queue_core, to avoid the compilation fail in the
following patch series. The idea is that nfqueue and nflog uses the
functions in nf_conntrack_netlink.o, put the conntrack attachment
basis into nf_conntrack_netlink.

On Wed, Aug 26, 2015 at 09:05:53PM +0200, Pablo Neira Ayuso wrote:
> On Tue, Aug 25, 2015 at 08:15:20AM +0900, Ken-ichirou MATSUZAWA wrote:
> >  config NETFILTER_NETLINK_QUEUE_CT
> > -        bool "NFQUEUE integration with Connection Tracking"
> > +        bool "NFQUEUE/NFLOG integration with Connection Tracking"
> >          default n
> > -        depends on NETFILTER_NETLINK_QUEUE
> > +        depends on NETFILTER_NETLINK_QUEUE || NETFILTER_NETLINK_LOG
> >  	help
> > -	  If this option is enabled, NFQUEUE can include Connection Tracking
> > -	  information together with the packet is the enqueued via NFNETLINK.
> > +	  If this option is enabled, NFQUEUE and/or NFLOG can include
> > +	  Connection Tracking information together with the packet is
> > +	  enqueued, logged via NFNETLINK.
> 
> You better add another Kconfig for _LOG.

That idea causes to expose functions in nf_netlink_queue_ct and to
disable to separate config in Kconfig too. Should I separate those
config? and would you please tell me how if I should?

Thanks,