All of lore.kernel.org
 help / color / mirror / Atom feed
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/5] [media] c8sectpfe: Update binding to reset-gpios
Date: Fri, 28 Aug 2015 07:57:40 +0100	[thread overview]
Message-ID: <20150828065740.GD4796@x1> (raw)
In-Reply-To: <1440678575-21646-5-git-send-email-peter.griffin@linaro.org>

On Thu, 27 Aug 2015, Peter Griffin wrote:

> gpio.txt documents that GPIO properties should be named
> "[<name>-]gpios", with <name> being the purpose of this
> GPIO for the device.
> 
> This change has been done as one atomic commit.
> 
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> ---
>  Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt | 6 +++---
>  arch/arm/boot/dts/stihxxx-b2120.dtsi                          | 4 ++--
>  drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c         | 2 +-
>  3 files changed, 6 insertions(+), 6 deletions(-)

Acked-by: Lee Jones <lee.jones@linaro.org>

> diff --git a/Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt b/Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt
> index d4def76..e70d840 100644
> --- a/Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt
> +++ b/Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt
> @@ -35,7 +35,7 @@ Required properties (tsin (child) node):
>  
>  - tsin-num	: tsin id of the InputBlock (must be between 0 to 6)
>  - i2c-bus	: phandle to the I2C bus DT node which the demodulators & tuners on this tsin channel are connected.
> -- rst-gpio	: reset gpio for this tsin channel.
> +- reset-gpios	: reset gpio for this tsin channel.
>  
>  Optional properties (tsin (child) node):
>  
> @@ -75,7 +75,7 @@ Example:
>  			tsin-num		= <0>;
>  			serial-not-parallel;
>  			i2c-bus			= <&ssc2>;
> -			rst-gpio		= <&pio15 4 0>;
> +			reset-gpios		= <&pio15 4 GPIO_ACTIVE_HIGH>;
>  			dvb-card		= <STV0367_TDA18212_NIMA_1>;
>  		};
>  
> @@ -83,7 +83,7 @@ Example:
>  			tsin-num		= <3>;
>  			serial-not-parallel;
>  			i2c-bus			= <&ssc3>;
> -			rst-gpio		= <&pio15 7 0>;
> +			reset-gpios		= <&pio15 7 GPIO_ACTIVE_HIGH>;
>  			dvb-card		= <STV0367_TDA18212_NIMB_1>;
>  		};
>  	};
> diff --git a/arch/arm/boot/dts/stihxxx-b2120.dtsi b/arch/arm/boot/dts/stihxxx-b2120.dtsi
> index c014173..f932bfd 100644
> --- a/arch/arm/boot/dts/stihxxx-b2120.dtsi
> +++ b/arch/arm/boot/dts/stihxxx-b2120.dtsi
> @@ -6,8 +6,8 @@
>   * it under the terms of the GNU General Public License version 2 as
>   * published by the Free Software Foundation.
>   */
> -
>  #include <dt-bindings/clock/stih407-clks.h>
> +#include <dt-bindings/gpio/gpio.h>
>  #include <dt-bindings/media/c8sectpfe.h>
>  / {
>  	soc {
> @@ -115,7 +115,7 @@
>  				tsin-num	= <0>;
>  				serial-not-parallel;
>  				i2c-bus		= <&ssc2>;
> -				rst-gpio	= <&pio15 4 0>;
> +				reset-gpios	= <&pio15 4 GPIO_ACTIVE_HIGH>;
>  				dvb-card	= <STV0367_TDA18212_NIMA_1>;
>  			};
>  		};
> diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
> index 3a91093..c691e13 100644
> --- a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
> +++ b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
> @@ -822,7 +822,7 @@ static int c8sectpfe_probe(struct platform_device *pdev)
>  		}
>  		of_node_put(i2c_bus);
>  
> -		tsin->rst_gpio = of_get_named_gpio(child, "rst-gpio", 0);
> +		tsin->rst_gpio = of_get_named_gpio(child, "reset-gpios", 0);
>  
>  		ret = gpio_is_valid(tsin->rst_gpio);
>  		if (!ret) {

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Peter Griffin <peter.griffin@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, maxime.coquelin@st.com,
	srinivas.kandagatla@gmail.com, patrice.chotard@st.com,
	mchehab@osg.samsung.com, devicetree@vger.kernel.org,
	linux-media@vger.kernel.org
Subject: Re: [PATCH v2 4/5] [media] c8sectpfe: Update binding to reset-gpios
Date: Fri, 28 Aug 2015 07:57:40 +0100	[thread overview]
Message-ID: <20150828065740.GD4796@x1> (raw)
In-Reply-To: <1440678575-21646-5-git-send-email-peter.griffin@linaro.org>

On Thu, 27 Aug 2015, Peter Griffin wrote:

> gpio.txt documents that GPIO properties should be named
> "[<name>-]gpios", with <name> being the purpose of this
> GPIO for the device.
> 
> This change has been done as one atomic commit.
> 
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> ---
>  Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt | 6 +++---
>  arch/arm/boot/dts/stihxxx-b2120.dtsi                          | 4 ++--
>  drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c         | 2 +-
>  3 files changed, 6 insertions(+), 6 deletions(-)

Acked-by: Lee Jones <lee.jones@linaro.org>

> diff --git a/Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt b/Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt
> index d4def76..e70d840 100644
> --- a/Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt
> +++ b/Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt
> @@ -35,7 +35,7 @@ Required properties (tsin (child) node):
>  
>  - tsin-num	: tsin id of the InputBlock (must be between 0 to 6)
>  - i2c-bus	: phandle to the I2C bus DT node which the demodulators & tuners on this tsin channel are connected.
> -- rst-gpio	: reset gpio for this tsin channel.
> +- reset-gpios	: reset gpio for this tsin channel.
>  
>  Optional properties (tsin (child) node):
>  
> @@ -75,7 +75,7 @@ Example:
>  			tsin-num		= <0>;
>  			serial-not-parallel;
>  			i2c-bus			= <&ssc2>;
> -			rst-gpio		= <&pio15 4 0>;
> +			reset-gpios		= <&pio15 4 GPIO_ACTIVE_HIGH>;
>  			dvb-card		= <STV0367_TDA18212_NIMA_1>;
>  		};
>  
> @@ -83,7 +83,7 @@ Example:
>  			tsin-num		= <3>;
>  			serial-not-parallel;
>  			i2c-bus			= <&ssc3>;
> -			rst-gpio		= <&pio15 7 0>;
> +			reset-gpios		= <&pio15 7 GPIO_ACTIVE_HIGH>;
>  			dvb-card		= <STV0367_TDA18212_NIMB_1>;
>  		};
>  	};
> diff --git a/arch/arm/boot/dts/stihxxx-b2120.dtsi b/arch/arm/boot/dts/stihxxx-b2120.dtsi
> index c014173..f932bfd 100644
> --- a/arch/arm/boot/dts/stihxxx-b2120.dtsi
> +++ b/arch/arm/boot/dts/stihxxx-b2120.dtsi
> @@ -6,8 +6,8 @@
>   * it under the terms of the GNU General Public License version 2 as
>   * published by the Free Software Foundation.
>   */
> -
>  #include <dt-bindings/clock/stih407-clks.h>
> +#include <dt-bindings/gpio/gpio.h>
>  #include <dt-bindings/media/c8sectpfe.h>
>  / {
>  	soc {
> @@ -115,7 +115,7 @@
>  				tsin-num	= <0>;
>  				serial-not-parallel;
>  				i2c-bus		= <&ssc2>;
> -				rst-gpio	= <&pio15 4 0>;
> +				reset-gpios	= <&pio15 4 GPIO_ACTIVE_HIGH>;
>  				dvb-card	= <STV0367_TDA18212_NIMA_1>;
>  			};
>  		};
> diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
> index 3a91093..c691e13 100644
> --- a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
> +++ b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
> @@ -822,7 +822,7 @@ static int c8sectpfe_probe(struct platform_device *pdev)
>  		}
>  		of_node_put(i2c_bus);
>  
> -		tsin->rst_gpio = of_get_named_gpio(child, "rst-gpio", 0);
> +		tsin->rst_gpio = of_get_named_gpio(child, "reset-gpios", 0);
>  
>  		ret = gpio_is_valid(tsin->rst_gpio);
>  		if (!ret) {

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2015-08-28  6:57 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-27 12:29 [PATCH v2 0/5] [media] c8sectpfe: Various fixups Peter Griffin
2015-08-27 12:29 ` Peter Griffin
2015-08-27 12:29 ` [PATCH v2 1/5] ARM: DT: STi: stihxxx-b2120: Add pulse-width properties to ssc2 & ssc3 Peter Griffin
2015-08-27 12:29   ` Peter Griffin
2015-08-28  7:01   ` Lee Jones
2015-08-28  7:01     ` Lee Jones
2015-08-27 12:29 ` [PATCH v2 2/5] ARM: DT: STi: STiH407: Add c8sectpfe LinuxDVB DT node Peter Griffin
2015-08-27 12:29   ` Peter Griffin
2015-08-28  7:01   ` Lee Jones
2015-08-28  7:01     ` Lee Jones
2015-08-28 17:07     ` Peter Griffin
2015-08-28 17:07       ` Peter Griffin
2015-08-27 12:29 ` [PATCH v2 3/5] [media] c8sectpfe: Remove select on undefined LIBELF_32 Peter Griffin
2015-08-27 12:29   ` Peter Griffin
2015-08-27 12:29   ` Peter Griffin
2015-08-28  6:58   ` Lee Jones
2015-08-28  6:58     ` Lee Jones
2015-08-28 17:09     ` Peter Griffin
2015-08-28 17:09       ` Peter Griffin
2015-08-28 17:09       ` Peter Griffin
2015-08-27 12:29 ` [PATCH v2 4/5] [media] c8sectpfe: Update binding to reset-gpios Peter Griffin
2015-08-27 12:29   ` Peter Griffin
2015-08-27 12:29   ` Peter Griffin
2015-08-28  6:57   ` Lee Jones [this message]
2015-08-28  6:57     ` Lee Jones
2015-08-27 12:29 ` [PATCH v2 5/5] [media] c8sectpfe: Update DT binding doc with some minor fixes Peter Griffin
2015-08-27 12:29   ` Peter Griffin
2015-08-28  6:57   ` Lee Jones
2015-08-28  6:57     ` Lee Jones
2015-08-28 17:25     ` Peter Griffin
2015-08-28 17:25       ` Peter Griffin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150828065740.GD4796@x1 \
    --to=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.