From: Peter Jones <pjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
Cc: Paul Gortmaker
<paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Matt Fleming
<matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] drivers/firmware: make efi/esrt.c driver explicitly non-modular
Date: Mon, 31 Aug 2015 09:52:02 -0400 [thread overview]
Message-ID: <20150831135201.GA17921@redhat.com> (raw)
In-Reply-To: <20150826171128.GA2837-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
On Wed, Aug 26, 2015 at 06:11:28PM +0100, Matt Fleming wrote:
> On Tue, 25 Aug, at 07:00:48PM, Paul Gortmaker wrote:
> > The Kconfig for this driver is currently hidden with:
> >
> > config EFI_ESRT
> > bool
> >
> > ...meaning that it currently is not being built as a module by anyone.
> > Lets remove the modular code that is essentially orphaned, so that
> > when reading the driver there is no doubt it is builtin-only.
> >
> > Since module_init translates to device_initcall in the non-modular
> > case, the init ordering remains unchanged with this commit.
> >
> > We leave some tags like MODULE_AUTHOR for documentation purposes.
> >
> > We don't replace module.h with init.h since the file already has that.
> >
> > Cc: Matt Fleming <matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > Cc: Peter Jones <pjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> > Cc: linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > Signed-off-by: Paul Gortmaker <paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
>
> Looks good to me. I know Peter is on vacation right now, so I'm still
> expecting a response from him. In the meantime, I'll queue this up in
> the EFI 'next' branch. Thanks!
Looks fine to me as well.
--
Peter
WARNING: multiple messages have this Message-ID (diff)
From: Peter Jones <pjones@redhat.com>
To: Matt Fleming <matt@codeblueprint.co.uk>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
linux-kernel@vger.kernel.org,
Matt Fleming <matt.fleming@intel.com>,
linux-efi@vger.kernel.org
Subject: Re: [PATCH] drivers/firmware: make efi/esrt.c driver explicitly non-modular
Date: Mon, 31 Aug 2015 09:52:02 -0400 [thread overview]
Message-ID: <20150831135201.GA17921@redhat.com> (raw)
In-Reply-To: <20150826171128.GA2837@codeblueprint.co.uk>
On Wed, Aug 26, 2015 at 06:11:28PM +0100, Matt Fleming wrote:
> On Tue, 25 Aug, at 07:00:48PM, Paul Gortmaker wrote:
> > The Kconfig for this driver is currently hidden with:
> >
> > config EFI_ESRT
> > bool
> >
> > ...meaning that it currently is not being built as a module by anyone.
> > Lets remove the modular code that is essentially orphaned, so that
> > when reading the driver there is no doubt it is builtin-only.
> >
> > Since module_init translates to device_initcall in the non-modular
> > case, the init ordering remains unchanged with this commit.
> >
> > We leave some tags like MODULE_AUTHOR for documentation purposes.
> >
> > We don't replace module.h with init.h since the file already has that.
> >
> > Cc: Matt Fleming <matt.fleming@intel.com>
> > Cc: Peter Jones <pjones@redhat.com>
> > Cc: linux-efi@vger.kernel.org
> > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
>
> Looks good to me. I know Peter is on vacation right now, so I'm still
> expecting a response from him. In the meantime, I'll queue this up in
> the EFI 'next' branch. Thanks!
Looks fine to me as well.
--
Peter
next prev parent reply other threads:[~2015-08-31 13:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-25 23:00 [PATCH] drivers/firmware: make efi/esrt.c driver explicitly non-modular Paul Gortmaker
2015-08-25 23:00 ` Paul Gortmaker
2015-08-26 17:11 ` Matt Fleming
[not found] ` <20150826171128.GA2837-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2015-08-31 13:52 ` Peter Jones [this message]
2015-08-31 13:52 ` Peter Jones
[not found] ` <20150831135201.GA17921-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-01 8:57 ` Matt Fleming
2015-09-01 8:57 ` Matt Fleming
[not found] ` <20150901085708.GD2823-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2015-09-01 13:19 ` Peter Jones
2015-09-01 13:19 ` Peter Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150831135201.GA17921@redhat.com \
--to=pjones-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org \
--cc=matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.