Re: [oe-commits] Christopher Larson : update-rc.d.bbclass: explicitly dep on initscripts

Re: [oe-commits] Christopher Larson : update-rc.d.bbclass: explicitly dep on initscripts

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 2443 bytes --]

On Sun, Aug 30, 2015 at 11:48:19AM +0000, git@git.openembedded.org wrote:
> Module: openembedded-core.git
> Branch: master
> Commit: 833302761df924bb503cc2ad04ecae1023381f8f
> URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=833302761df924bb503cc2ad04ecae1023381f8f
> 
> Author: Christopher Larson <chris_larson@mentor.com>
> Date:   Mon Aug 24 15:18:34 2015 -0700
> 
> update-rc.d.bbclass: explicitly dep on initscripts
> 
> update-rc.d doesn't just want an initscripts package, it wants
> initscripts-functions. In the case where VIRTUAL-RUNTIME_initscripts is set to
> nothing, update-rc.d still needs initscripts-functions to satisfy its runtime
> dependencies. Further, we shouldn't be using a *runtime* virtual in a *build
> time* variable. This should resolve image creation failures with
> configurations without sysv initscripts when a recipe inherits update-rc.d and
> doesn't inherit systemd.
> 
> (From OE-Core rev: e6642ae0849e5ac3174c643a7693af25d829d6d1)

Unfortunately this means that I cannot PNBLACKLIST initscripts recipe in
DISTRO which provides own initscripts implementation (which also
provides initscripts-functions).

What's even worse is that I'll have to overlay whole bbclass to get rid
of this dependency :/

Regards,

> 
> Signed-off-by: Christopher Larson <chris_larson@mentor.com>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> 
> ---
> 
>  meta/classes/update-rc.d.bbclass | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/meta/classes/update-rc.d.bbclass b/meta/classes/update-rc.d.bbclass
> index 6a08315..2a0a74a 100644
> --- a/meta/classes/update-rc.d.bbclass
> +++ b/meta/classes/update-rc.d.bbclass
> @@ -1,8 +1,6 @@
>  UPDATERCPN ?= "${PN}"
>  
> -DEPENDS_append_class-target = " update-rc.d-native update-rc.d"
> -VIRTUAL-RUNTIME_initscripts ?= "initscripts"
> -DEPENDS_append_class-target = " ${VIRTUAL-RUNTIME_initscripts}"
> +DEPENDS_append_class-target = " update-rc.d-native update-rc.d initscripts"
>  UPDATERCD = "update-rc.d"
>  UPDATERCD_class-cross = ""
>  UPDATERCD_class-native = ""
> 
> -- 
> _______________________________________________
> Openembedded-commits mailing list
> Openembedded-commits@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-commits

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

Re: [oe-commits] Christopher Larson : update-rc.d.bbclass: explicitly dep on initscripts

[Christopher Larson]

[-- Attachment #1: Type: text/plain, Size: 1770 bytes --]

On Mon, Aug 31, 2015 at 11:41 AM, Martin Jansa <martin.jansa@gmail.com>
wrote:

> On Sun, Aug 30, 2015 at 11:48:19AM +0000, git@git.openembedded.org wrote:
> > Module: openembedded-core.git
> > Branch: master
> > Commit: 833302761df924bb503cc2ad04ecae1023381f8f
> > URL:
> http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=833302761df924bb503cc2ad04ecae1023381f8f
> >
> > Author: Christopher Larson <chris_larson@mentor.com>
> > Date:   Mon Aug 24 15:18:34 2015 -0700
> >
> > update-rc.d.bbclass: explicitly dep on initscripts
> >
> > update-rc.d doesn't just want an initscripts package, it wants
> > initscripts-functions. In the case where VIRTUAL-RUNTIME_initscripts is
> set to
> > nothing, update-rc.d still needs initscripts-functions to satisfy its
> runtime
> > dependencies. Further, we shouldn't be using a *runtime* virtual in a
> *build
> > time* variable. This should resolve image creation failures with
> > configurations without sysv initscripts when a recipe inherits
> update-rc.d and
> > doesn't inherit systemd.
> >
> > (From OE-Core rev: e6642ae0849e5ac3174c643a7693af25d829d6d1)
>
> Unfortunately this means that I cannot PNBLACKLIST initscripts recipe in
> DISTRO which provides own initscripts implementation (which also
> provides initscripts-functions).
>
> What's even worse is that I'll have to overlay whole bbclass to get rid
> of this dependency :/
>

Of course you can. This is a build dependency. Add a PROVIDES +=
"initscripts" + appropriate preferences. Alternatively, we could introduce
a virtual/initscripts-functions.
-- 
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics

[-- Attachment #2: Type: text/html, Size: 2570 bytes --]

Re: [oe-commits] Christopher Larson : update-rc.d.bbclass: explicitly dep on initscripts

[Khem Raj]

On Mon, Aug 31, 2015 at 11:41 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
>> update-rc.d.bbclass: explicitly dep on initscripts
>>
>> update-rc.d doesn't just want an initscripts package, it wants
>> initscripts-functions. In the case where VIRTUAL-RUNTIME_initscripts is set to
>> nothing, update-rc.d still needs initscripts-functions to satisfy its runtime
>> dependencies. Further, we shouldn't be using a *runtime* virtual in a *build
>> time* variable. This should resolve image creation failures with
>> configurations without sysv initscripts when a recipe inherits update-rc.d and
>> doesn't inherit systemd.
>>
>> (From OE-Core rev: e6642ae0849e5ac3174c643a7693af25d829d6d1)
>
> Unfortunately this means that I cannot PNBLACKLIST initscripts recipe in
> DISTRO which provides own initscripts implementation (which also
> provides initscripts-functions).
>
> What's even worse is that I'll have to overlay whole bbclass to get rid
> of this dependency :/
>

would it help if initscript-functions was also PROVIDED by initscript
replacement ?

Re: [oe-commits] Christopher Larson : update-rc.d.bbclass: explicitly dep on initscripts

[Christopher Larson]

[-- Attachment #1: Type: text/plain, Size: 1987 bytes --]

On Monday, August 31, 2015, Martin Jansa <martin.jansa@gmail.com
<javascript:_e(%7B%7D,'cvml','martin.jansa@gmail.com');>> wrote:

> On Sun, Aug 30, 2015 at 11:48:19AM +0000, git@git.openembedded.org wrote:
> > Module: openembedded-core.git
> > Branch: master
> > Commit: 833302761df924bb503cc2ad04ecae1023381f8f
> > URL:
> http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=833302761df924bb503cc2ad04ecae1023381f8f
> >
> > Author: Christopher Larson <chris_larson@mentor.com>
> > Date:   Mon Aug 24 15:18:34 2015 -0700
> >
> > update-rc.d.bbclass: explicitly dep on initscripts
> >
> > update-rc.d doesn't just want an initscripts package, it wants
> > initscripts-functions. In the case where VIRTUAL-RUNTIME_initscripts is
> set to
> > nothing, update-rc.d still needs initscripts-functions to satisfy its
> runtime
> > dependencies. Further, we shouldn't be using a *runtime* virtual in a
> *build
> > time* variable. This should resolve image creation failures with
> > configurations without sysv initscripts when a recipe inherits
> update-rc.d and
> > doesn't inherit systemd.
> >
> > (From OE-Core rev: e6642ae0849e5ac3174c643a7693af25d829d6d1)
>
> Unfortunately this means that I cannot PNBLACKLIST initscripts recipe in
> DISTRO which provides own initscripts implementation (which also
> provides initscripts-functions).
>
> What's even worse is that I'll have to overlay whole bbclass to get rid
> of this dependency :/


Of course you can. This is a build dependency. Add a PROVIDES +=
"initscripts" + appropriate preferences (or keep your PNBLACKLIST). This is
precisely what provides is for. Alternatively, we could introduce a
virtual/initscripts-functions rather than using 'initscripts' for this. In
either case, you don't need to override anything.


-- 
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics

[-- Attachment #2: Type: text/html, Size: 2628 bytes --]