From: Anders Roxell <anders.roxell-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
Cc: kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org,
ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
khilman-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
linux-rt-users-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] drivers: i2c: exynos5: irq spinlock rt-safe
Date: Mon, 31 Aug 2015 23:28:44 +0200 [thread overview]
Message-ID: <20150831212844.GI13774@localhost.localdomain> (raw)
In-Reply-To: <alpine.DEB.2.11.1508252349070.15006@nanos>
On 2015-08-25 23:51, Thomas Gleixner wrote:
> On Tue, 25 Aug 2015, Anders Roxell wrote:
>
> > The exynos5_i2c_message_start enables interrupts while holding the i2c
> > lock which is sought by the irq handler. If an IRQ is received before
> > this lock is released then a deadlock occurs.
>
> That's crap. The interrupt handler runs in an irq thread as RT forces
> all normal interrupts to that.
You are right, I will send a v2 with a better changelog.
Cheers,
Anders
WARNING: multiple messages have this Message-ID (diff)
From: anders.roxell@linaro.org (Anders Roxell)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drivers: i2c: exynos5: irq spinlock rt-safe
Date: Mon, 31 Aug 2015 23:28:44 +0200 [thread overview]
Message-ID: <20150831212844.GI13774@localhost.localdomain> (raw)
In-Reply-To: <alpine.DEB.2.11.1508252349070.15006@nanos>
On 2015-08-25 23:51, Thomas Gleixner wrote:
> On Tue, 25 Aug 2015, Anders Roxell wrote:
>
> > The exynos5_i2c_message_start enables interrupts while holding the i2c
> > lock which is sought by the irq handler. If an IRQ is received before
> > this lock is released then a deadlock occurs.
>
> That's crap. The interrupt handler runs in an irq thread as RT forces
> all normal interrupts to that.
You are right, I will send a v2 with a better changelog.
Cheers,
Anders
WARNING: multiple messages have this Message-ID (diff)
From: Anders Roxell <anders.roxell@linaro.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: kgene@kernel.org, k.kozlowski@samsung.com, wsa@the-dreams.de,
ch.naveen@samsung.com, linux-i2c@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
khilman@linaro.org, linux-rt-users@vger.kernel.org
Subject: Re: [PATCH] drivers: i2c: exynos5: irq spinlock rt-safe
Date: Mon, 31 Aug 2015 23:28:44 +0200 [thread overview]
Message-ID: <20150831212844.GI13774@localhost.localdomain> (raw)
In-Reply-To: <alpine.DEB.2.11.1508252349070.15006@nanos>
On 2015-08-25 23:51, Thomas Gleixner wrote:
> On Tue, 25 Aug 2015, Anders Roxell wrote:
>
> > The exynos5_i2c_message_start enables interrupts while holding the i2c
> > lock which is sought by the irq handler. If an IRQ is received before
> > this lock is released then a deadlock occurs.
>
> That's crap. The interrupt handler runs in an irq thread as RT forces
> all normal interrupts to that.
You are right, I will send a v2 with a better changelog.
Cheers,
Anders
next prev parent reply other threads:[~2015-08-31 21:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-25 7:52 [PATCH] drivers: i2c: exynos5: irq spinlock rt-safe Anders Roxell
2015-08-25 7:52 ` Anders Roxell
2015-08-25 7:52 ` Anders Roxell
2015-08-25 21:51 ` Thomas Gleixner
2015-08-25 21:51 ` Thomas Gleixner
2015-08-31 21:28 ` Anders Roxell [this message]
2015-08-31 21:28 ` Anders Roxell
2015-08-31 21:28 ` Anders Roxell
2015-09-03 21:06 ` [PATCHv2] " Anders Roxell
2015-09-03 21:06 ` Anders Roxell
[not found] ` <1441314363-9836-1-git-send-email-anders.roxell-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-09-03 21:31 ` Thomas Gleixner
2015-09-03 21:31 ` Thomas Gleixner
2015-09-03 21:31 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150831212844.GI13774@localhost.localdomain \
--to=anders.roxell-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=khilman-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rt-users-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.