From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: fix a migrating irq bug when hotplug cpu
Date: Tue, 1 Sep 2015 09:48:14 +0100 [thread overview]
Message-ID: <20150901084814.GB1612@arm.com> (raw)
In-Reply-To: <20150831132031.2a017df1@arm.com>
On Mon, Aug 31, 2015 at 01:20:31PM +0100, Marc Zyngier wrote:
> On Sun, 30 Aug 2015 21:15:56 +0800
> Hanjun Guo <hanjun.guo@linaro.org> wrote:
> > I agree. In arch/arm64/kernel/irq.c the irq migrate code is the same
> > as ARM32, and it's duplicate. But this is a bugfix, can we fix it in
> > a simple way, and refactor the code later?
>
> I'm not buying this.
>
> I really can't see how adding more duplication can be beneficial. It is
> not so much that there is duplication between arm and arm64 that
> bothers me (as if that was the only thing...). The real issue is that
> there is duplication between the arch code and the core code.
>
> Migrating interrupts is a core code matter, and that's were it should
> be handled IMHO. Plus, we're in the merge window, and there is plenty
> of time to get this fixed the proper way.
Yup. I suggested this over a year ago but not sure why nothing happened:
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-June/266923.html
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: "hanjun.guo@linaro.org" <hanjun.guo@linaro.org>,
Jiang Liu <jiang.liu@linux.intel.com>,
Yang Yingliang <yangyingliang@huawei.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Mark Rutland <Mark.Rutland@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: fix a migrating irq bug when hotplug cpu
Date: Tue, 1 Sep 2015 09:48:14 +0100 [thread overview]
Message-ID: <20150901084814.GB1612@arm.com> (raw)
In-Reply-To: <20150831132031.2a017df1@arm.com>
On Mon, Aug 31, 2015 at 01:20:31PM +0100, Marc Zyngier wrote:
> On Sun, 30 Aug 2015 21:15:56 +0800
> Hanjun Guo <hanjun.guo@linaro.org> wrote:
> > I agree. In arch/arm64/kernel/irq.c the irq migrate code is the same
> > as ARM32, and it's duplicate. But this is a bugfix, can we fix it in
> > a simple way, and refactor the code later?
>
> I'm not buying this.
>
> I really can't see how adding more duplication can be beneficial. It is
> not so much that there is duplication between arm and arm64 that
> bothers me (as if that was the only thing...). The real issue is that
> there is duplication between the arch code and the core code.
>
> Migrating interrupts is a core code matter, and that's were it should
> be handled IMHO. Plus, we're in the merge window, and there is plenty
> of time to get this fixed the proper way.
Yup. I suggested this over a year ago but not sure why nothing happened:
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-June/266923.html
Will
next prev parent reply other threads:[~2015-09-01 8:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-29 13:00 [PATCH] arm64: fix a migrating irq bug when hotplug cpu Yang Yingliang
2015-08-29 13:00 ` Yang Yingliang
2015-08-29 15:12 ` Jiang Liu
2015-08-29 15:12 ` Jiang Liu
2015-08-29 18:12 ` Marc Zyngier
2015-08-29 18:12 ` Marc Zyngier
2015-08-30 13:15 ` Hanjun Guo
2015-08-30 13:15 ` Hanjun Guo
2015-08-31 12:20 ` Marc Zyngier
2015-08-31 12:20 ` Marc Zyngier
2015-09-01 8:48 ` Will Deacon [this message]
2015-09-01 8:48 ` Will Deacon
2015-09-01 10:02 ` Yang Yingliang
2015-09-01 10:02 ` Yang Yingliang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150901084814.GB1612@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.