From: Tony Lindgren <tony@atomide.com>
To: Frans Klaver <frans.klaver@xsens.com>
Cc: Frans Klaver <fransklaver@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
David Binderman <dcb314@hotmail.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm: omap2: vc: fix 'or' always true warning
Date: Tue, 1 Sep 2015 08:46:09 -0700 [thread overview]
Message-ID: <20150901154609.GK4215@atomide.com> (raw)
In-Reply-To: <1440756632-14043-1-git-send-email-frans.klaver@xsens.com>
* Frans Klaver <frans.klaver@xsens.com> [150828 03:14]:
> From: Frans Klaver <fransklaver@gmail.com>
>
> Fix the warning:
> arch/arm/mach-omap2/vc.c:302:47: warning: logical ‘or’ of collectively exhaustive tests is always true [-Wlogical-op]
>
> As we're toggling both CLKREQ and OFFMODE, we should also be checking
> OFFMODE.
>
> Signed-off-by: Frans Klaver <fransklaver@gmail.com>
Thanks apppying into omap-for-v4.3/fixes.
Tony
> ---
> arch/arm/mach-omap2/vc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/vc.c b/arch/arm/mach-omap2/vc.c
> index 076fd20d7e5a..807bc79e3e3d 100644
> --- a/arch/arm/mach-omap2/vc.c
> +++ b/arch/arm/mach-omap2/vc.c
> @@ -300,7 +300,7 @@ static void __init omap3_vc_init_pmic_signaling(struct voltagedomain *voltdm)
>
> val = voltdm->read(OMAP3_PRM_POLCTRL_OFFSET);
> if (!(val & OMAP3430_PRM_POLCTRL_CLKREQ_POL) ||
> - (val & OMAP3430_PRM_POLCTRL_CLKREQ_POL)) {
> + (val & OMAP3430_PRM_POLCTRL_OFFMODE_POL)) {
> val |= OMAP3430_PRM_POLCTRL_CLKREQ_POL;
> val &= ~OMAP3430_PRM_POLCTRL_OFFMODE_POL;
> pr_debug("PM: fixing sys_clkreq and sys_off_mode polarity to 0x%x\n",
> --
> 2.3.4
>
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: omap2: vc: fix 'or' always true warning
Date: Tue, 1 Sep 2015 08:46:09 -0700 [thread overview]
Message-ID: <20150901154609.GK4215@atomide.com> (raw)
In-Reply-To: <1440756632-14043-1-git-send-email-frans.klaver@xsens.com>
* Frans Klaver <frans.klaver@xsens.com> [150828 03:14]:
> From: Frans Klaver <fransklaver@gmail.com>
>
> Fix the warning:
> arch/arm/mach-omap2/vc.c:302:47: warning: logical ?or? of collectively exhaustive tests is always true [-Wlogical-op]
>
> As we're toggling both CLKREQ and OFFMODE, we should also be checking
> OFFMODE.
>
> Signed-off-by: Frans Klaver <fransklaver@gmail.com>
Thanks apppying into omap-for-v4.3/fixes.
Tony
> ---
> arch/arm/mach-omap2/vc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/vc.c b/arch/arm/mach-omap2/vc.c
> index 076fd20d7e5a..807bc79e3e3d 100644
> --- a/arch/arm/mach-omap2/vc.c
> +++ b/arch/arm/mach-omap2/vc.c
> @@ -300,7 +300,7 @@ static void __init omap3_vc_init_pmic_signaling(struct voltagedomain *voltdm)
>
> val = voltdm->read(OMAP3_PRM_POLCTRL_OFFSET);
> if (!(val & OMAP3430_PRM_POLCTRL_CLKREQ_POL) ||
> - (val & OMAP3430_PRM_POLCTRL_CLKREQ_POL)) {
> + (val & OMAP3430_PRM_POLCTRL_OFFMODE_POL)) {
> val |= OMAP3430_PRM_POLCTRL_CLKREQ_POL;
> val &= ~OMAP3430_PRM_POLCTRL_OFFMODE_POL;
> pr_debug("PM: fixing sys_clkreq and sys_off_mode polarity to 0x%x\n",
> --
> 2.3.4
>
next prev parent reply other threads:[~2015-09-01 15:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-28 9:25 arch/arm/mach-omap2/vc.c:302: bad if test ? David Binderman
2015-08-28 10:10 ` [PATCH] arm: omap2: vc: fix 'or' always true warning Frans Klaver
2015-08-28 10:10 ` Frans Klaver
2015-08-28 10:10 ` Frans Klaver
2015-09-01 15:46 ` Tony Lindgren [this message]
2015-09-01 15:46 ` Tony Lindgren
2015-09-01 18:21 ` Frans Klaver
2015-09-01 18:21 ` Frans Klaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150901154609.GK4215@atomide.com \
--to=tony@atomide.com \
--cc=dcb314@hotmail.com \
--cc=frans.klaver@xsens.com \
--cc=fransklaver@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.