Question about patch "pinctrl: cherryview: Do not mask all interrupts on probe"

Question about patch "pinctrl: cherryview: Do not mask all interrupts on probe"

[João Paulo Rechi Vita]

Hello Mika,

About a month ago I've sent a message [1] to linux-gpio querying about
the state of the patch mentioned on the subject, which you had sent
and later resigned. It seems I've failed to address my message while
trying to send it through gmane as a reply to the original message, as
it did not get to your attention.

[1] https://www.mail-archive.com/linux-gpio%40vger.kernel.org/msg09093.html

I'm working on a ASUS E202SA laptop, in which the brightness keys
depend on this patch to work. Are any plans to have it integrated, in
the original form or in any other?

Thanks,

--
João Paulo Rechi Vita
http://about.me/jprvita
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Question about patch "pinctrl: cherryview: Do not mask all interrupts on probe"

[Mika Westerberg]

On Tue, Sep 01, 2015 at 04:09:12PM -0400, João Paulo Rechi Vita wrote:
> Hello Mika,
> 
> About a month ago I've sent a message [1] to linux-gpio querying about
> the state of the patch mentioned on the subject, which you had sent
> and later resigned. It seems I've failed to address my message while
> trying to send it through gmane as a reply to the original message, as
> it did not get to your attention.

Looks like I never got that email.

> [1] https://www.mail-archive.com/linux-gpio%40vger.kernel.org/msg09093.html
> 
> I'm working on a ASUS E202SA laptop, in which the brightness keys
> depend on this patch to work. Are any plans to have it integrated, in
> the original form or in any other?

Adding Yu to the loop.

Yu was investigating alternative ways to fix this. Did you come to
some conclusion?
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: Question about patch "pinctrl: cherryview: Do not mask all interrupts on probe"

[Chen, Yu C]

> -----Original Message-----
> From: Mika Westerberg [mailto:mika.westerberg@linux.intel.com]
> Sent: Wednesday, September 02, 2015 3:37 PM
> To: João Paulo Rechi Vita
> Cc: linux-gpio@vger.kernel.org; Chen, Yu C
> Subject: Re: Question about patch "pinctrl: cherryview: Do not mask all
> interrupts on probe"
> 
> On Tue, Sep 01, 2015 at 04:09:12PM -0400, João Paulo Rechi Vita wrote:
> >
> > I'm working on a ASUS E202SA laptop, in which the brightness keys
> > depend on this patch to work. Are any plans to have it integrated, in
> > the original form or in any other?
> 
> Adding Yu to the loop.
> 
> Yu was investigating alternative ways to fix this. Did you come to some
> conclusion?

Once I wrote a quirk patch to re-enable gpio irq in Embedded Controller driver, and since 
ec driver is loaded before pinctrl driver , I need to modify the patch to add a delay 'request_irq' 
in ec driver, maybe a workqueue mechanism. Then I switched to some other bugs..
Yes, I'll continue this work recently, please stay tuned.
Thanks
Best Regards,
Yu
 
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: Question about patch "pinctrl: cherryview: Do not mask all interrupts on probe"

[Zheng, Lv]

Hi,

> From: Chen, Yu C
> Sent: Wednesday, September 02, 2015 4:07 PM
> 
> 
> > From: Mika Westerberg [mailto:mika.westerberg@linux.intel.com]
> > Sent: Wednesday, September 02, 2015 3:37 PM
> >
> > On Tue, Sep 01, 2015 at 04:09:12PM -0400, João Paulo Rechi Vita wrote:
> > >
> > > I'm working on a ASUS E202SA laptop, in which the brightness keys
> > > depend on this patch to work. Are any plans to have it integrated, in
> > > the original form or in any other?
> >
> > Adding Yu to the loop.
> >
> > Yu was investigating alternative ways to fix this. Did you come to some
> > conclusion?
> 
> Once I wrote a quirk patch to re-enable gpio irq in Embedded Controller driver, and since
> ec driver is loaded before pinctrl driver , I need to modify the patch to add a delay 'request_irq'
> in ec driver, maybe a workqueue mechanism. Then I switched to some other bugs..
> Yes, I'll continue this work recently, please stay tuned.

EC contains early initialization and late initialization.
During early initialization, IMO, you needn't do anything related to the gpio irq.
The late initialization is invoked in the ACPI driver probe callback.
You can locate gpiolib there before proceeding.
If gpiolib is not found, you can return EPROBE_DEFER in this case.
So what's the problem now?

Thanks and best regards
-Lv

> Thanks
> Best Regards,
> Yu
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Question about patch "pinctrl: cherryview: Do not mask all interrupts on probe"

[João Paulo Rechi Vita]

On 2 September 2015 at 04:06, Chen, Yu C <yu.c.chen@intel.com> wrote:
>
>> -----Original Message-----
>> From: Mika Westerberg [mailto:mika.westerberg@linux.intel.com]
>> Sent: Wednesday, September 02, 2015 3:37 PM
>> To: João Paulo Rechi Vita
>> Cc: linux-gpio@vger.kernel.org; Chen, Yu C
>> Subject: Re: Question about patch "pinctrl: cherryview: Do not mask all
>> interrupts on probe"
>>
>> On Tue, Sep 01, 2015 at 04:09:12PM -0400, João Paulo Rechi Vita wrote:
>> >
>> > I'm working on a ASUS E202SA laptop, in which the brightness keys
>> > depend on this patch to work. Are any plans to have it integrated, in
>> > the original form or in any other?
>>
>> Adding Yu to the loop.
>>
>> Yu was investigating alternative ways to fix this. Did you come to some
>> conclusion?
>
> Once I wrote a quirk patch to re-enable gpio irq in Embedded Controller driver, and since
> ec driver is loaded before pinctrl driver , I need to modify the patch to add a delay 'request_irq'
> in ec driver, maybe a workqueue mechanism. Then I switched to some other bugs..
> Yes, I'll continue this work recently, please stay tuned.

That's good news, thank you very much for the info! I'll keep checking
for updates about this on linux-gpio, but I can also do some testing
if needed, just let me know.

Cheers,

--
João Paulo Rechi Vita
http://about.me/jprvita
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html