* [Buildroot] [PATCH 1/1] package/pkg-kernel-module.mk: module build fails
@ 2015-09-02 1:37 Doug Kehn
2015-09-02 7:11 ` Thomas Petazzoni
2015-09-02 9:26 ` Yann E. MORIN
0 siblings, 2 replies; 6+ messages in thread
From: Doug Kehn @ 2015-09-02 1:37 UTC (permalink / raw)
To: buildroot
Observed the following when building cryptodev-linux:
>>> cryptodev-linux 1.7 Building kernel module(s)
grep: /.config: No such file or directory
ERROR: Kernel does not support loadable modules
Fix LINUX_DIR reference when determining if kernel configuration
supports loadable modules.
Signed-off-by: Doug Kehn <rdkehn@yahoo.com>
---
package/pkg-kernel-module.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/pkg-kernel-module.mk b/package/pkg-kernel-module.mk
index 6fb7704..7628352 100644
--- a/package/pkg-kernel-module.mk
+++ b/package/pkg-kernel-module.mk
@@ -60,7 +60,7 @@ $(2)_MODULE_SUBDIRS ?= .
# includes and other support files (Booo!)
define $(2)_KERNEL_MODULES_BUILD
@$$(call MESSAGE,"Building kernel module(s)")
- @if ! grep -Fqx 'CONFIG_MODULES=y' $(LINUX_DIR)/.config; then \
+ @if ! grep -Fqx 'CONFIG_MODULES=y' $$(LINUX_DIR)/.config; then \
echo "ERROR: Kernel does not support loadable modules"; \
exit 1; \
fi
--
2.5.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/pkg-kernel-module.mk: module build fails
2015-09-02 1:37 [Buildroot] [PATCH 1/1] package/pkg-kernel-module.mk: module build fails Doug Kehn
@ 2015-09-02 7:11 ` Thomas Petazzoni
2015-09-02 9:26 ` Yann E. MORIN
1 sibling, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2015-09-02 7:11 UTC (permalink / raw)
To: buildroot
Dear Doug Kehn,
On Tue, 1 Sep 2015 20:37:53 -0500, Doug Kehn wrote:
> Observed the following when building cryptodev-linux:
> >>> cryptodev-linux 1.7 Building kernel module(s)
> grep: /.config: No such file or directory
> ERROR: Kernel does not support loadable modules
>
> Fix LINUX_DIR reference when determining if kernel configuration
> supports loadable modules.
>
> Signed-off-by: Doug Kehn <rdkehn@yahoo.com>
Indeed:
Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/pkg-kernel-module.mk: module build fails
2015-09-02 1:37 [Buildroot] [PATCH 1/1] package/pkg-kernel-module.mk: module build fails Doug Kehn
2015-09-02 7:11 ` Thomas Petazzoni
@ 2015-09-02 9:26 ` Yann E. MORIN
2015-09-04 10:08 ` Peter Korsgaard
1 sibling, 1 reply; 6+ messages in thread
From: Yann E. MORIN @ 2015-09-02 9:26 UTC (permalink / raw)
To: buildroot
Doug, All,
On 2015-09-01 20:37 -0500, Doug Kehn spake thusly:
> Observed the following when building cryptodev-linux:
> >>> cryptodev-linux 1.7 Building kernel module(s)
> grep: /.config: No such file or directory
> ERROR: Kernel does not support loadable modules
>
> Fix LINUX_DIR reference when determining if kernel configuration
> supports loadable modules.
Dang.. I let that skip before the release...
> Signed-off-by: Doug Kehn <rdkehn@yahoo.com>
On principle:
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
However, there's a series that did not have time to make it to master
before the release, and that is an improvement over the current
situation, which would render this patch moot:
https://patchwork.ozlabs.org/patch/510186/
https://patchwork.ozlabs.org/patch/510187/
https://patchwork.ozlabs.org/patch/510188/
So, even though this patch is good, I'd prefer we aply the series
instead.
Still, the kernel-module infra is indeed broken in the release, thus
making all kernel module packages broken. I'll Oeter and Thomas decide
whether we want to put out a .1 release to fix just that.
Regards,
Yann E. MORIN.
> ---
> package/pkg-kernel-module.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/pkg-kernel-module.mk b/package/pkg-kernel-module.mk
> index 6fb7704..7628352 100644
> --- a/package/pkg-kernel-module.mk
> +++ b/package/pkg-kernel-module.mk
> @@ -60,7 +60,7 @@ $(2)_MODULE_SUBDIRS ?= .
> # includes and other support files (Booo!)
> define $(2)_KERNEL_MODULES_BUILD
> @$$(call MESSAGE,"Building kernel module(s)")
> - @if ! grep -Fqx 'CONFIG_MODULES=y' $(LINUX_DIR)/.config; then \
> + @if ! grep -Fqx 'CONFIG_MODULES=y' $$(LINUX_DIR)/.config; then \
> echo "ERROR: Kernel does not support loadable modules"; \
> exit 1; \
> fi
> --
> 2.5.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/pkg-kernel-module.mk: module build fails
2015-09-02 9:26 ` Yann E. MORIN
@ 2015-09-04 10:08 ` Peter Korsgaard
2015-09-04 10:22 ` Romain Naour
0 siblings, 1 reply; 6+ messages in thread
From: Peter Korsgaard @ 2015-09-04 10:08 UTC (permalink / raw)
To: buildroot
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
Hi,
>> Fix LINUX_DIR reference when determining if kernel configuration
>> supports loadable modules.
> Dang.. I let that skip before the release...
>> Signed-off-by: Doug Kehn <rdkehn@yahoo.com>
> On principle:
> Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> However, there's a series that did not have time to make it to master
> before the release, and that is an improvement over the current
> situation, which would render this patch moot:
> https://patchwork.ozlabs.org/patch/510186/
> https://patchwork.ozlabs.org/patch/510187/
> https://patchwork.ozlabs.org/patch/510188/
> So, even though this patch is good, I'd prefer we aply the series
> instead.
Yes, I'll do so shortly for master.
> Still, the kernel-module infra is indeed broken in the release, thus
> making all kernel module packages broken. I'll Oeter and Thomas decide
> whether we want to put out a .1 release to fix just that.
I've created a 2015.08.x branch and applied it. I'll wait a few days and
see if anything else shows up before releasing 2015.08.1.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/pkg-kernel-module.mk: module build fails
2015-09-04 10:08 ` Peter Korsgaard
@ 2015-09-04 10:22 ` Romain Naour
2015-09-04 10:57 ` Peter Korsgaard
0 siblings, 1 reply; 6+ messages in thread
From: Romain Naour @ 2015-09-04 10:22 UTC (permalink / raw)
To: buildroot
Hi Peter,
----- Mail original -----
> De: "Peter Korsgaard" <peter@korsgaard.com>
> ?: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: "buildroot" <buildroot@buildroot.org>
> Envoy?: Vendredi 4 Septembre 2015 12:08:32
> Objet: Re: [Buildroot] [PATCH 1/1] package/pkg-kernel-module.mk: module build fails
>>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
>
> Hi,
>
> >> Fix LINUX_DIR reference when determining if kernel configuration
> >> supports loadable modules.
>
> > Dang.. I let that skip before the release...
>
> >> Signed-off-by: Doug Kehn <rdkehn@yahoo.com>
>
> > On principle:
>
> > Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> > However, there's a series that did not have time to make it to master
> > before the release, and that is an improvement over the current
> > situation, which would render this patch moot:
>
> > https://patchwork.ozlabs.org/patch/510186/
> > https://patchwork.ozlabs.org/patch/510187/
> > https://patchwork.ozlabs.org/patch/510188/
>
> > So, even though this patch is good, I'd prefer we aply the series
> > instead.
>
> Yes, I'll do so shortly for master.
>
> > Still, the kernel-module infra is indeed broken in the release, thus
> > making all kernel module packages broken. I'll Oeter and Thomas decide
> > whether we want to put out a .1 release to fix just that.
>
> I've created a 2015.08.x branch and applied it. I'll wait a few days and
> see if anything else shows up before releasing 2015.08.1.
Since you are preparing a bug fix release, can you backport this little
patch ? ;-)
http://patchwork.ozlabs.org/patch/512785/
Thanks!
Best regards,
Romain
>
> --
> Bye, Peter Korsgaard
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/pkg-kernel-module.mk: module build fails
2015-09-04 10:22 ` Romain Naour
@ 2015-09-04 10:57 ` Peter Korsgaard
0 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2015-09-04 10:57 UTC (permalink / raw)
To: buildroot
>>>>> "Romain" == Romain Naour <romain.naour@openwide.fr> writes:
Hi,
> Hi Peter,
>> I've created a 2015.08.x branch and applied it. I'll wait a few days and
>> see if anything else shows up before releasing 2015.08.1.
> Since you are preparing a bug fix release, can you backport this little
> patch ? ;-)
> http://patchwork.ozlabs.org/patch/512785/
Cherrypicked, thanks. Please let me know if there are any other fixes
that should go in 2015.08.1.
--
Venlig hilsen,
Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-09-04 10:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-02 1:37 [Buildroot] [PATCH 1/1] package/pkg-kernel-module.mk: module build fails Doug Kehn
2015-09-02 7:11 ` Thomas Petazzoni
2015-09-02 9:26 ` Yann E. MORIN
2015-09-04 10:08 ` Peter Korsgaard
2015-09-04 10:22 ` Romain Naour
2015-09-04 10:57 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.